| Message ID | 20241119104521.575377-9-arun.r.murthy@intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Display Global Histogram | expand |
> -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Arun > R Murthy > Sent: Tuesday, November 19, 2024 4:15 PM > To: intel-xe@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dri- > devel@lists.freedesktop.org > Cc: Murthy, Arun R <arun.r.murthy@intel.com> > Subject: [PATCH 8/8] drm/i915/histogram: Enable pipe dithering > > Enable pipe dithering while enabling histogram to overcome some atrifacts > seen on the screen. Where does it say this. I don't see it in the bspec. Is this from testing that this was concluded in that case we perhaps need to make sure that the bspec captures this Regards, Suraj Kandpal > > Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> > --- > drivers/gpu/drm/i915/display/intel_histogram.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c > b/drivers/gpu/drm/i915/display/intel_histogram.c > index beaad9256e01..d3c63da7e491 100644 > --- a/drivers/gpu/drm/i915/display/intel_histogram.c > +++ b/drivers/gpu/drm/i915/display/intel_histogram.c > @@ -29,6 +29,13 @@ struct intel_histogram { > u32 bin_data[HISTOGRAM_BIN_COUNT]; > }; > > +static void intel_histogram_enable_dithering(struct intel_display *display, > + enum pipe pipe) > +{ > + intel_de_rmw(display, PIPE_MISC(pipe), PIPE_MISC_DITHER_ENABLE, > + PIPE_MISC_DITHER_ENABLE); > +} > + > static void set_bin_index_0(struct intel_display *display, enum pipe pipe) { > if (DISPLAY_VER(display) >= 20) > @@ -205,6 +212,9 @@ static int intel_histogram_enable(struct intel_crtc > *intel_crtc) > if (histogram->enable) > return 0; > > + /* Pipe Dithering should be enabled with histogram */ > + intel_histogram_enable_dithering(display, pipe); > + > if (DISPLAY_VER(display) >= 20) > intel_de_rmw(display, DPST_CTL(pipe), > DPST_CTL_IE_HIST_EN | > -- > 2.25.1
> > -----Original Message----- > > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > > Arun R Murthy > > Sent: Tuesday, November 19, 2024 4:15 PM > > To: intel-xe@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; > > dri- devel@lists.freedesktop.org > > Cc: Murthy, Arun R <arun.r.murthy@intel.com> > > Subject: [PATCH 8/8] drm/i915/histogram: Enable pipe dithering > > > > Enable pipe dithering while enabling histogram to overcome some > > atrifacts seen on the screen. > > Where does it say this. I don't see it in the bspec. > Is this from testing that this was concluded in that case we perhaps need to > make sure that the bspec captures this > Will check on updating the spec Thanks and Regards, Arun R Murthy --------------------
diff --git a/drivers/gpu/drm/i915/display/intel_histogram.c b/drivers/gpu/drm/i915/display/intel_histogram.c index beaad9256e01..d3c63da7e491 100644 --- a/drivers/gpu/drm/i915/display/intel_histogram.c +++ b/drivers/gpu/drm/i915/display/intel_histogram.c @@ -29,6 +29,13 @@ struct intel_histogram { u32 bin_data[HISTOGRAM_BIN_COUNT]; }; +static void intel_histogram_enable_dithering(struct intel_display *display, + enum pipe pipe) +{ + intel_de_rmw(display, PIPE_MISC(pipe), PIPE_MISC_DITHER_ENABLE, + PIPE_MISC_DITHER_ENABLE); +} + static void set_bin_index_0(struct intel_display *display, enum pipe pipe) { if (DISPLAY_VER(display) >= 20) @@ -205,6 +212,9 @@ static int intel_histogram_enable(struct intel_crtc *intel_crtc) if (histogram->enable) return 0; + /* Pipe Dithering should be enabled with histogram */ + intel_histogram_enable_dithering(display, pipe); + if (DISPLAY_VER(display) >= 20) intel_de_rmw(display, DPST_CTL(pipe), DPST_CTL_IE_HIST_EN |
Enable pipe dithering while enabling histogram to overcome some atrifacts seen on the screen. Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com> --- drivers/gpu/drm/i915/display/intel_histogram.c | 10 ++++++++++ 1 file changed, 10 insertions(+)