| Message ID | 20241120095428.1122935-4-quic_chejiang@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add qcom,product-variant properties in Qualcomm | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | fail | error: patch failed: arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi:856 error: arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch |
On Wed, Nov 20, 2024 at 05:54:27PM +0800, Cheng Jiang wrote: > Add product-variant property to specify the IoT product line. > Update the chip soc type, SA8775P-ride platform uses the QCA6698 > chip, which is compatible with the WCN6855. It's necessary to use this > new SoC type to distinguish it from projects using WCN chips. Why? > > Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > index 3fc62e123689..da52f425c676 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > @@ -856,7 +856,8 @@ &uart17 { > status = "okay"; > > bluetooth { > - compatible = "qcom,wcn6855-bt"; > + compatible = "qcom,qca6698-bt"; > + qcom,product-variant = <0x20000>; > > vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > vddaon-supply = <&vreg_pmu_aon_0p59>; > -- > 2.25.1 >
On 20/11/2024 10:54, Cheng Jiang wrote: > Add product-variant property to specify the IoT product line. > Update the chip soc type, SA8775P-ride platform uses the QCA6698 > chip, which is compatible with the WCN6855. It's necessary to use this > new SoC type to distinguish it from projects using WCN chips. > > Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > index 3fc62e123689..da52f425c676 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > @@ -856,7 +856,8 @@ &uart17 { > status = "okay"; > > bluetooth { > - compatible = "qcom,wcn6855-bt"; > + compatible = "qcom,qca6698-bt"; Breaks users. > + qcom,product-variant = <0x20000>; Nope. > > vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; > vddaon-supply = <&vreg_pmu_aon_0p59>; Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi index 3fc62e123689..da52f425c676 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi @@ -856,7 +856,8 @@ &uart17 { status = "okay"; bluetooth { - compatible = "qcom,wcn6855-bt"; + compatible = "qcom,qca6698-bt"; + qcom,product-variant = <0x20000>; vddrfacmn-supply = <&vreg_pmu_rfa_cmn>; vddaon-supply = <&vreg_pmu_aon_0p59>;
Add product-variant property to specify the IoT product line. Update the chip soc type, SA8775P-ride platform uses the QCA6698 chip, which is compatible with the WCN6855. It's necessary to use this new SoC type to distinguish it from projects using WCN chips. Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)