| Message ID | 20241120105954.9665-3-quic_mukhopad@quicinc.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Enable Display Port for Qualcomm SA8775P-ride platform | expand |
On Wed, Nov 20, 2024 at 04:29:54PM +0530, Soutrik Mukhopadhyay wrote: > Enable DPTX0 and DPTX1 along with their corresponding PHYs for > sa8775p-ride platform. > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> > --- > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++ > 1 file changed, 80 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > index adb71aeff339..4847e4942386 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > @@ -27,6 +27,30 @@ > chosen { > stdout-path = "serial0:115200n8"; > }; > + > + dp0-connector { > + compatible = "dp-connector"; > + label = "DP0"; Thundercomm's SA8775p RIDE platform doesn't show such a connector. At least not on a device advertised on the web pages. > + type = "full-size"; > + > + port { > + dp0_connector_in: endpoint { > + remote-endpoint = <&mdss0_dp0_out>; > + }; > + }; > + }; > + > + dp1-connector { > + compatible = "dp-connector"; > + label = "DP1"; Same comment here. > + type = "full-size"; > + > + port { > + dp1_connector_in: endpoint { > + remote-endpoint = <&mdss0_dp1_out>; > + }; > + }; > + }; > }; > > &apps_rsc {
On 11/20/2024 4:42 PM, Dmitry Baryshkov wrote: > On Wed, Nov 20, 2024 at 04:29:54PM +0530, Soutrik Mukhopadhyay wrote: > > Enable DPTX0 and DPTX1 along with their corresponding PHYs for > > sa8775p-ride platform. > > > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++ > > 1 file changed, 80 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > index adb71aeff339..4847e4942386 100644 > > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > @@ -27,6 +27,30 @@ > > chosen { > > stdout-path = "serial0:115200n8"; > > }; > > + > > + dp0-connector { > > + compatible = "dp-connector"; > > + label = "DP0"; > > Thundercomm's SA8775p RIDE platform doesn't show such a connector. At > least not on a device advertised on the web pages. Are you referring to this product in the Thundercomm web page : SA8225P and SA8775P Ride SX 4.0 Automotive Development Platform ? For this particular product we can see eDP 0/1/2/3 serving as the dp connectors. > > > + type = "full-size"; > > + > > + port { > > + dp0_connector_in: endpoint { > > + remote-endpoint = <&mdss0_dp0_out>; > > + }; > > + }; > > + }; > > + > > + dp1-connector { > > + compatible = "dp-connector"; > > + label = "DP1"; > > Same comment here. > > > + type = "full-size"; > > + > > + port { > > + dp1_connector_in: endpoint { > > + remote-endpoint = <&mdss0_dp1_out>; > > + }; > > + }; > > + }; > > }; > > > > &apps_rsc { >
On Wed, Nov 20, 2024 at 05:05:50PM +0530, Soutrik Mukhopadhyay wrote: > > On 11/20/2024 4:42 PM, Dmitry Baryshkov wrote: > > On Wed, Nov 20, 2024 at 04:29:54PM +0530, Soutrik Mukhopadhyay wrote: > > > Enable DPTX0 and DPTX1 along with their corresponding PHYs for > > > sa8775p-ride platform. > > > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> > > > --- > > > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++ > > > 1 file changed, 80 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > index adb71aeff339..4847e4942386 100644 > > > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > @@ -27,6 +27,30 @@ > > > chosen { > > > stdout-path = "serial0:115200n8"; > > > }; > > > + > > > + dp0-connector { > > > + compatible = "dp-connector"; > > > + label = "DP0"; > > > > Thundercomm's SA8775p RIDE platform doesn't show such a connector. At > > least not on a device advertised on the web pages. > > > Are you referring to this product in the Thundercomm web page : SA8225P and > SA8775P > Ride SX 4.0 Automotive Development Platform ? Yes > For this particular product we > can see > eDP 0/1/2/3 serving as the dp connectors. Please correct the labels then. And also please mention why eDP2/3 are not included / tested. > > > > > > > + type = "full-size"; > > > + > > > + port { > > > + dp0_connector_in: endpoint { > > > + remote-endpoint = <&mdss0_dp0_out>; > > > + }; > > > + }; > > > + }; > > > + > > > + dp1-connector { > > > + compatible = "dp-connector"; > > > + label = "DP1"; > > > > Same comment here. > > > > > + type = "full-size"; > > > + > > > + port { > > > + dp1_connector_in: endpoint { > > > + remote-endpoint = <&mdss0_dp1_out>; > > > + }; > > > + }; > > > + }; > > > }; > > > > &apps_rsc { > >
On 11/20/2024 5:13 PM, Dmitry Baryshkov wrote: > On Wed, Nov 20, 2024 at 05:05:50PM +0530, Soutrik Mukhopadhyay wrote: > > > > On 11/20/2024 4:42 PM, Dmitry Baryshkov wrote: > > > On Wed, Nov 20, 2024 at 04:29:54PM +0530, Soutrik Mukhopadhyay wrote: > > > > Enable DPTX0 and DPTX1 along with their corresponding PHYs for > > > > sa8775p-ride platform. > > > > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> > > > > --- > > > > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++ > > > > 1 file changed, 80 insertions(+) > > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > > index adb71aeff339..4847e4942386 100644 > > > > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > > @@ -27,6 +27,30 @@ > > > > chosen { > > > > stdout-path = "serial0:115200n8"; > > > > }; > > > > + > > > > + dp0-connector { > > > > + compatible = "dp-connector"; > > > > + label = "DP0"; > > > > > > Thundercomm's SA8775p RIDE platform doesn't show such a connector. At > > > least not on a device advertised on the web pages. > > > > > > Are you referring to this product in the Thundercomm web page : SA8225P and > > SA8775P > > Ride SX 4.0 Automotive Development Platform ? > > Yes > > > For this particular product we > > can see > > eDP 0/1/2/3 serving as the dp connectors. > > Please correct the labels then. And also please mention why eDP2/3 are > not included / tested. Sure, we will update the labels in the upcoming patchset. edp 0/1 corresponds to mdss0_dptx0 and mdss0_dptx1. We have validated only these. edp 2/3 corresponds to mdss1_dptx0 and mdss1_dptx1, and these are not validated, as already mentioned during the driver changes for the same. Should we mention the same in the commit message for the upcoming patchset ? > > > > > > > > > > > > + type = "full-size"; > > > > + > > > > + port { > > > > + dp0_connector_in: endpoint { > > > > + remote-endpoint = <&mdss0_dp0_out>; > > > > + }; > > > > + }; > > > > + }; > > > > + > > > > + dp1-connector { > > > > + compatible = "dp-connector"; > > > > + label = "DP1"; > > > > > > Same comment here. > > > > > > > + type = "full-size"; > > > > + > > > > + port { > > > > + dp1_connector_in: endpoint { > > > > + remote-endpoint = <&mdss0_dp1_out>; > > > > + }; > > > > + }; > > > > + }; > > > > }; > > > > > &apps_rsc { > > > >
On Wed, Nov 20, 2024 at 05:23:24PM +0530, Soutrik Mukhopadhyay wrote: > > On 11/20/2024 5:13 PM, Dmitry Baryshkov wrote: > > On Wed, Nov 20, 2024 at 05:05:50PM +0530, Soutrik Mukhopadhyay wrote: > > > > On 11/20/2024 4:42 PM, Dmitry Baryshkov wrote: > > > > On Wed, Nov 20, 2024 at 04:29:54PM +0530, Soutrik Mukhopadhyay wrote: > > > > > Enable DPTX0 and DPTX1 along with their corresponding PHYs for > > > > > sa8775p-ride platform. > > > > > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> > > > > > --- > > > > > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++ > > > > > 1 file changed, 80 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > > b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > > > index adb71aeff339..4847e4942386 100644 > > > > > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi > > > > > @@ -27,6 +27,30 @@ > > > > > chosen { > > > > > stdout-path = "serial0:115200n8"; > > > > > }; > > > > > + > > > > > + dp0-connector { > > > > > + compatible = "dp-connector"; > > > > > + label = "DP0"; > > > > > > Thundercomm's SA8775p RIDE platform doesn't show such a > > connector. At > > > > least not on a device advertised on the web pages. > > > > > Are you referring to this product in the Thundercomm web page : > > SA8225P and > > > SA8775P > > > Ride SX 4.0 Automotive Development Platform ? > > > > Yes > > > > > For this particular product we > > > can see > > > eDP 0/1/2/3 serving as the dp connectors. > > > > Please correct the labels then. And also please mention why eDP2/3 are > > not included / tested. > > > Sure, we will update the labels in the upcoming patchset. > edp 0/1 corresponds to mdss0_dptx0 and mdss0_dptx1. We have validated only > these. > edp 2/3 corresponds to mdss1_dptx0 and mdss1_dptx1, and these are not > validated, > as already mentioned during the driver changes for the same. > Should we mention the same in the commit message for the upcoming patchset ? Yes, please mention this in the commit message for this patchset. > > > > > > > > > + type = "full-size"; > > > > > + > > > > > + port { > > > > > + dp0_connector_in: endpoint { > > > > > + remote-endpoint = <&mdss0_dp0_out>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > + > > > > > + dp1-connector { > > > > > + compatible = "dp-connector"; > > > > > + label = "DP1"; > > > > > > Same comment here. > > > > > > > + type = "full-size"; > > > > > + > > > > > + port { > > > > > + dp1_connector_in: endpoint { > > > > > + remote-endpoint = <&mdss0_dp1_out>; > > > > > + }; > > > > > + }; > > > > > + }; > > > > > }; > > > > > > &apps_rsc { > > > > > >
On 20.11.2024 12:53 PM, Soutrik Mukhopadhyay wrote: > > On 11/20/2024 5:13 PM, Dmitry Baryshkov wrote: >> On Wed, Nov 20, 2024 at 05:05:50PM +0530, Soutrik Mukhopadhyay wrote: >> > > On 11/20/2024 4:42 PM, Dmitry Baryshkov wrote: >> > > On Wed, Nov 20, 2024 at 04:29:54PM +0530, Soutrik Mukhopadhyay wrote: >> > > > Enable DPTX0 and DPTX1 along with their corresponding PHYs for >> > > > sa8775p-ride platform. >> > > > > Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> >> > > > --- >> > > > arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++ >> > > > 1 file changed, 80 insertions(+) >> > > > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> > > b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> > > > index adb71aeff339..4847e4942386 100644 >> > > > --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> > > > +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi >> > > > @@ -27,6 +27,30 @@ >> > > > chosen { >> > > > stdout-path = "serial0:115200n8"; >> > > > }; >> > > > + >> > > > + dp0-connector { >> > > > + compatible = "dp-connector"; >> > > > + label = "DP0"; >> > > > > Thundercomm's SA8775p RIDE platform doesn't show such a connector. At >> > > least not on a device advertised on the web pages. >> > > > Are you referring to this product in the Thundercomm web page : SA8225P and >> > SA8775P >> > Ride SX 4.0 Automotive Development Platform ? >> >> Yes >> >> > For this particular product we >> > can see >> > eDP 0/1/2/3 serving as the dp connectors. >> >> Please correct the labels then. And also please mention why eDP2/3 are >> not included / tested. > > > Sure, we will update the labels in the upcoming patchset. > edp 0/1 corresponds to mdss0_dptx0 and mdss0_dptx1. We have validated only these. > edp 2/3 corresponds to mdss1_dptx0 and mdss1_dptx1, and these are not validated, > as already mentioned during the driver changes for the same. > Should we mention the same in the commit message for the upcoming patchset ? So the box on the store page has these 4 ports next to each other.. Please take the additional 2 minutes and plug in a monitor to the other two ones as well. Konrad
diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi index adb71aeff339..4847e4942386 100644 --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi @@ -27,6 +27,30 @@ chosen { stdout-path = "serial0:115200n8"; }; + + dp0-connector { + compatible = "dp-connector"; + label = "DP0"; + type = "full-size"; + + port { + dp0_connector_in: endpoint { + remote-endpoint = <&mdss0_dp0_out>; + }; + }; + }; + + dp1-connector { + compatible = "dp-connector"; + label = "DP1"; + type = "full-size"; + + port { + dp1_connector_in: endpoint { + remote-endpoint = <&mdss0_dp1_out>; + }; + }; + }; }; &apps_rsc { @@ -421,6 +445,50 @@ status = "okay"; }; +&mdss0 { + status = "okay"; +}; + +&mdss0_dp0 { + status = "okay"; + + pinctrl-0 = <&dp0_hot_plug_det>; + pinctrl-names = "default"; +}; + +&mdss0_dp0_out { + data-lanes = <0 1 2 3>; + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; + remote-endpoint = <&dp0_connector_in>; +}; + +&mdss0_dp0_phy { + status = "okay"; + + vdda-phy-supply = <&vreg_l1c>; + vdda-pll-supply = <&vreg_l4a>; +}; + +&mdss0_dp1 { + status = "okay"; + + pinctrl-0 = <&dp1_hot_plug_det>; + pinctrl-names = "default"; +}; + +&mdss0_dp1_out { + data-lanes = <0 1 2 3>; + link-frequencies = /bits/ 64 <1620000000 2700000000 5400000000 8100000000>; + remote-endpoint = <&dp1_connector_in>; +}; + +&mdss0_dp1_phy { + status = "okay"; + + vdda-phy-supply = <&vreg_l1c>; + vdda-pll-supply = <&vreg_l4a>; +}; + &pmm8654au_0_gpios { gpio-line-names = "DS_EN", "POFF_COMPLETE", @@ -527,6 +595,18 @@ }; &tlmm { + dp0_hot_plug_det: dp0-hot-plug-det-state { + pins = "gpio101"; + function = "edp0_hot"; + bias-disable; + }; + + dp1_hot_plug_det: dp1-hot-plug-det-state { + pins = "gpio102"; + function = "edp1_hot"; + bias-disable; + }; + ethernet0_default: ethernet0-default-state { ethernet0_mdc: ethernet0-mdc-pins { pins = "gpio8";
Enable DPTX0 and DPTX1 along with their corresponding PHYs for sa8775p-ride platform. Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@quicinc.com> --- arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 80 ++++++++++++++++++++++ 1 file changed, 80 insertions(+)