mbox series

[v6,0/4] wifi: ath12k: Support Pager, Counter, SoC, Transmit Rate Stats

Message ID 20241115062854.1919672-1-quic_rdevanat@quicinc.com (mailing list archive)
Headers show
Series wifi: ath12k: Support Pager, Counter, SoC, Transmit Rate Stats | expand

Message

Roopni Devanathan Nov. 15, 2024, 6:28 a.m. UTC 
Add support to request HTT stats type 36, 37, 38 and 40 from firmware.
These stat types give downlink pager stats, counter and TPC stats, SoC
common stats and Transmit PER rate stats, respectively.

v6:
 - Removed unused variables.
 - Used le32_get_bits() instead of u32_get_bits().
v5:
 - Addressed Kalle's comments pertaining to variable declaration order.
v4:
 - Addressed Jeff's comments pertaining to data type conversions.
v3:
 - Added macros to fix compilation issues.
v2:
 - Removed dependencies. No change in code.

Dinesh Karthikeyan (4):
  wifi: ath12k: Support Downlink Pager Stats
  wifi: ath12k: Support phy counter and TPC stats
  wifi: ath12k: Support SoC Common Stats
  wifi: ath12k: Support Transmit PER Rate Stats

 .../wireless/ath/ath12k/debugfs_htt_stats.c   | 627 +++++++++++++++++-
 .../wireless/ath/ath12k/debugfs_htt_stats.h   | 204 +++++-
 2 files changed, 827 insertions(+), 4 deletions(-)


base-commit: 0ea161de5e5afa1323e982adc8f59bf4af99a84b

Comments

Jeff Johnson Nov. 15, 2024, 9:25 p.m. UTC | #1 
On 11/14/2024 10:28 PM, Roopni Devanathan wrote:
> Add support to request HTT stats type 36, 37, 38 and 40 from firmware.
> These stat types give downlink pager stats, counter and TPC stats, SoC
> common stats and Transmit PER rate stats, respectively.
> 
> v6:
>  - Removed unused variables.
>  - Used le32_get_bits() instead of u32_get_bits().
> v5:
>  - Addressed Kalle's comments pertaining to variable declaration order.
> v4:
>  - Addressed Jeff's comments pertaining to data type conversions.
> v3:
>  - Added macros to fix compilation issues.
> v2:
>  - Removed dependencies. No change in code.
> 
> Dinesh Karthikeyan (4):
>   wifi: ath12k: Support Downlink Pager Stats
>   wifi: ath12k: Support phy counter and TPC stats
>   wifi: ath12k: Support SoC Common Stats
>   wifi: ath12k: Support Transmit PER Rate Stats
> 
>  .../wireless/ath/ath12k/debugfs_htt_stats.c   | 627 +++++++++++++++++-
>  .../wireless/ath/ath12k/debugfs_htt_stats.h   | 204 +++++-
>  2 files changed, 827 insertions(+), 4 deletions(-)
> 
> 
> base-commit: 0ea161de5e5afa1323e982adc8f59bf4af99a84b

I've acked this series, but since Kalle had reminded you in v5, you really
should have fixed the xmas tree issues when you posted v6.

/jeff
Jeff Johnson Nov. 20, 2024, 3:45 p.m. UTC | #2 
On Fri, 15 Nov 2024 11:58:50 +0530, Roopni Devanathan wrote:
> Add support to request HTT stats type 36, 37, 38 and 40 from firmware.
> These stat types give downlink pager stats, counter and TPC stats, SoC
> common stats and Transmit PER rate stats, respectively.
> 
> v6:
>  - Removed unused variables.
>  - Used le32_get_bits() instead of u32_get_bits().
> v5:
>  - Addressed Kalle's comments pertaining to variable declaration order.
> v4:
>  - Addressed Jeff's comments pertaining to data type conversions.
> v3:
>  - Added macros to fix compilation issues.
> v2:
>  - Removed dependencies. No change in code.
> 
> [...]

Applied, thanks!

[1/4] wifi: ath12k: Support Downlink Pager Stats
      commit: a93d125ebfdd530ea1980a45b7ad2e9471b82c87
[2/4] wifi: ath12k: Support phy counter and TPC stats
      commit: c3527cdfcdf70dcd613c4582283e28e4f81df9ea
[3/4] wifi: ath12k: Support SoC Common Stats
      commit: 3a660e7fa44d556f41cbef6d2430f7227ef3f3ef
[4/4] wifi: ath12k: Support Transmit PER Rate Stats
      commit: c8f314703bcbade1bcef8dfee9ffc6a1d66b9d8f

Best regards,