| Message ID | 20241120154755.1951-1-quic_prathm@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [BlueZ] Fix for broadcast mode, not to add any AD flags in advertise Data | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=911311 ---Test result--- Test Summary: CheckPatch PENDING 0.18 seconds GitLint PENDING 0.19 seconds BuildEll PASS 20.92 seconds BluezMake PASS 1672.66 seconds MakeCheck PASS 12.85 seconds MakeDistcheck PASS 163.69 seconds CheckValgrind PASS 219.04 seconds CheckSmatch PASS 279.28 seconds bluezmakeextell PASS 100.81 seconds IncrementalBuild PENDING 0.30 seconds ScanBuild PASS 879.41 seconds Details ############################## Test: CheckPatch - PENDING Desc: Run checkpatch.pl script Output: ############################## Test: GitLint - PENDING Desc: Run gitlint Output: ############################## Test: IncrementalBuild - PENDING Desc: Incremental build with the patches in the series Output: --- Regards, Linux Bluetooth
diff --git a/src/advertising.c b/src/advertising.c index bd121e525..2fc6f917d 100644 --- a/src/advertising.c +++ b/src/advertising.c @@ -759,10 +759,15 @@ static bool parse_discoverable(DBusMessageIter *iter, dbus_message_iter_get_basic(iter, &discoverable); + /* For broadcast mode, need not add any flags + * just return true without adding flags. + */ if (discoverable) flags = BT_AD_FLAG_GENERAL; - else + else if (client->type != AD_TYPE_BROADCAST) flags = 0x00; + else + return true; if (!set_flags(client , flags)) goto fail;
From: Prathibha Madugonde <quic_prathm@quicinc.com> src/advertising.c Include check for broadcast mode: AD flags shall never be set for broadcast Test steps: From DUT, bluetoothctl go to menu advertise advertise.secondary 1M/2M advertise.name on advertise broadcast --- src/advertising.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)