| Message ID | 20241120035826.3920-2-cedricjustine.encarnacion@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for ADP1051/ADP1055 and LTP8800-1A/-2/-4A | expand |
On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote: > add dt-bindings for adp1051, adp1055, and ltp8800 pmbus. > ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature > ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature > LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator > > Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> > Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> > Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> Why did you drop my ack? https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/ > --- > .../bindings/hwmon/pmbus/adi,adp1050.yaml | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > index 10c2204bc3df..af7530093942 100644 > --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml > @@ -10,16 +10,27 @@ maintainers: > - Radu Sabau <radu.sabau@analog.com> > > description: | > - The ADP1050 is used to monitor system voltages, currents and temperatures. > + The ADP1050 and similar devices are used to monitor system voltages, > + currents, power, and temperatures. > + > Through the PMBus interface, the ADP1050 targets isolated power supplies > and has four individual monitors for input/output voltage, input current > and temperature. > Datasheet: > https://www.analog.com/en/products/adp1050.html > + https://www.analog.com/en/products/adp1051.html > + https://www.analog.com/en/products/adp1055.html > + https://www.analog.com/en/products/ltp8800-1a.html > + https://www.analog.com/en/products/ltp8800-2.html > + https://www.analog.com/en/products/ltp8800-4a.html > > properties: > compatible: > - const: adi,adp1050 > + enum: > + - adi,adp1050 > + - adi,adp1051 > + - adi,adp1055 > + - adi,ltp8800 > > reg: > maxItems: 1 > -- > 2.39.5 >
On 20/11/2024 18:11, Conor Dooley wrote: > On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote: >> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus. >> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature >> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature >> LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator >> >> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> > > Why did you drop my ack? > https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/ So that's a v2? Or v3? Then should be marked correctly. Please start using b4. I already asked analog.com for this in few cases. Feel free not to use b4 if you send correct patches, but this is not the case here. A nit, subject: drop second/last, redundant "bindings for". The "dt-bindings" prefix is already stating that these are bindings. See also: https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 Best regards, Krzysztof
On 11/20/24 09:11, Conor Dooley wrote: > On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote: >> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus. >> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature >> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature >> LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator >> >> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> > > Why did you drop my ack? > https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/ > There: > + enum: > + - adi,adp1050 > + - adi,adp1051 > + - adi,adp1055 > Here: >> + enum: >> + - adi,adp1050 >> + - adi,adp1051 >> + - adi,adp1055 >> + - adi,ltp8800 <-- This is a combination of two patch series. I'd personally hesitant to carry Acks along in such situations. Guenter
On 11/20/24 09:35, Krzysztof Kozlowski wrote: > On 20/11/2024 18:11, Conor Dooley wrote: >> On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote: >>> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus. >>> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature >>> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature >>> LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator >>> >>> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >>> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >>> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> >> >> Why did you drop my ack? >> https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/ > So that's a v2? Or v3? Then should be marked correctly. Please start > using b4. I already asked analog.com for this in few cases. Feel free > not to use b4 if you send correct patches, but this is not the case here. > In general I agree, but this is a combination of two patch series, as mentioned in the summary. I am not sure how to use versioning in such situations. Is it v2 of one series or v3 of the other ? Thanks, Guenter
On 20/11/2024 19:07, Guenter Roeck wrote: > On 11/20/24 09:35, Krzysztof Kozlowski wrote: >> On 20/11/2024 18:11, Conor Dooley wrote: >>> On Wed, Nov 20, 2024 at 11:58:25AM +0800, Cedric Encarnacion wrote: >>>> add dt-bindings for adp1051, adp1055, and ltp8800 pmbus. >>>> ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature >>>> ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature >>>> LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator >>>> >>>> Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >>>> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> >>>> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> >>> >>> Why did you drop my ack? >>> https://lore.kernel.org/all/20241106-linoleum-kebab-decf14f54f76@spud/ >> So that's a v2? Or v3? Then should be marked correctly. Please start >> using b4. I already asked analog.com for this in few cases. Feel free >> not to use b4 if you send correct patches, but this is not the case here. >> > > In general I agree, but this is a combination of two patch series, as mentioned > in the summary. I am not sure how to use versioning in such situations. Is it > v2 of one series or v3 of the other ? I would say the highest and keep the b4 changeset. This allows to use b4 diff easily. Choice done here - v1, no usage of b4 - breaks everything, look: b4 diff '<20241120035826.3920-1-cedricjustine.encarnacion@analog.com>' Grabbing thread from lore.kernel.org/all/20241120035826.3920-1-cedricjustine.encarnacion@analog.com/t.mbox.gz --- Analyzing 13 messages in the thread Could not find lower series to compare against. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml index 10c2204bc3df..af7530093942 100644 --- a/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,adp1050.yaml @@ -10,16 +10,27 @@ maintainers: - Radu Sabau <radu.sabau@analog.com> description: | - The ADP1050 is used to monitor system voltages, currents and temperatures. + The ADP1050 and similar devices are used to monitor system voltages, + currents, power, and temperatures. + Through the PMBus interface, the ADP1050 targets isolated power supplies and has four individual monitors for input/output voltage, input current and temperature. Datasheet: https://www.analog.com/en/products/adp1050.html + https://www.analog.com/en/products/adp1051.html + https://www.analog.com/en/products/adp1055.html + https://www.analog.com/en/products/ltp8800-1a.html + https://www.analog.com/en/products/ltp8800-2.html + https://www.analog.com/en/products/ltp8800-4a.html properties: compatible: - const: adi,adp1050 + enum: + - adi,adp1050 + - adi,adp1051 + - adi,adp1055 + - adi,ltp8800 reg: maxItems: 1
add dt-bindings for adp1051, adp1055, and ltp8800 pmbus. ADP1051: 6 PWM for I/O Voltage, I/O Current, Temperature ADP1055: 6 PWM for I/O Voltage, I/O Current, Power, Temperature LTP8800-1A/-2/-4A: 150A/135A/200A DC/DC µModule Regulator Co-developed-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> Signed-off-by: Alexis Czezar Torreno <alexisczezar.torreno@analog.com> Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@analog.com> --- .../bindings/hwmon/pmbus/adi,adp1050.yaml | 15 +++++++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-)