| Message ID | Zz3YsU2pn-HtWvXn@c8d99ad60702 (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [1/2] crypto: fix -std=c23 build failure | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| prestwoj/iwd-alpine-ci-fetch | success | Fetch PR |
| prestwoj/iwd-ci-gitlint | fail | [2/2] anqputil: fix -std=c23 build failure 5: B1 Line exceeds max length (94>80): " https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212" 9: B1 Line exceeds max length (110>80): " ../src/anqputil.c:134:24: error: incompatible types when returning type '_Bool' but 'char **' was expected" |
| prestwoj/iwd-ci-fetch | success | Fetch PR |
| prestwoj/iwd-alpine-ci-setupell | success | Prep - Setup ELL |
| prestwoj/iwd-ci-setupell | success | Prep - Setup ELL |
| prestwoj/iwd-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-alpine-ci-makedistcheck | success | Make Distcheck |
| prestwoj/iwd-ci-build | success | Build - Configure |
| prestwoj/iwd-alpine-ci-build | success | Build - Configure |
| prestwoj/iwd-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-clang | success | clang PASS |
| prestwoj/iwd-alpine-ci-makecheckvalgrind | success | Make Check w/Valgrind |
| prestwoj/iwd-alpine-ci-makecheck | success | Make Check |
| prestwoj/iwd-ci-incremental_build | success | Incremental Build with patches |
| prestwoj/iwd-alpine-ci-incremental_build | success | Incremental Build with patches |
| prestwoj/iwd-ci-testrunner | success | test-runner PASS |
Hi Rudi, On 11/20/24 6:40 AM, Rudi Heitbaum wrote: > gcc-15 switched to -std=c23 by default: > > https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 > > As a result `iwd` fails the build as: > > ../src/crypto.c:1215:24: error: incompatible types when returning type '_Bool' but 'struct l_ecc_point *' was expected > 1215 | return false; > | ^~~~~ > > Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> > --- > src/crypto.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Both applied, thanks. Regards, -Denis
diff --git a/src/crypto.c b/src/crypto.c index 35941a2e..9dcdb43b 100644 --- a/src/crypto.c +++ b/src/crypto.c @@ -1212,7 +1212,7 @@ struct l_ecc_point *crypto_derive_sae_pwe_from_pt_ecc(const uint8_t *mac1, struct l_ecc_point *pwe; if (!pt || !curve) - return false; + return NULL; hash = crypto_sae_hash_from_ecc_prime_len(CRYPTO_SAE_HASH_TO_ELEMENT, l_ecc_curve_get_scalar_bytes(curve));
gcc-15 switched to -std=c23 by default: https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=55e3bd376b2214e200fa76d12b67ff259b06c212 As a result `iwd` fails the build as: ../src/crypto.c:1215:24: error: incompatible types when returning type '_Bool' but 'struct l_ecc_point *' was expected 1215 | return false; | ^~~~~ Signed-off-by: Rudi Heitbaum <rudi@heitbaum.com> --- src/crypto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)