| Message ID | 20241120083818.1079456-1-yong.liang.choong@linux.intel.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [net,1/1] net: stmmac: set initial EEE policy configuration | expand |
On 11/20/2024 12:38 AM, Choong Yong Liang wrote: > Set the initial eee_cfg values to have 'ethtool --show-eee ' display > the initial EEE configuration. > > Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE") > Cc: <stable@vger.kernel.org> > Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com> > --- > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > index 7bf275f127c9..766213ee82c1 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c > @@ -1205,6 +1205,9 @@ static int stmmac_init_phy(struct net_device *dev) > return -ENODEV; > } > > + if (priv->dma_cap.eee) > + phy_support_eee(phydev); > + Ok, so priv->dma_cap.eee is true, then this device supports EEE, and we call phy_support_eee which will initialize the values indicating that we support the feature for ethtool. Makes sense. Reviewed-by: Jacob Keller <jacob.e.keller@intel.com> > ret = phylink_connect_phy(priv->phylink, phydev); > } else { > fwnode_handle_put(phy_fwnode);
diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c index 7bf275f127c9..766213ee82c1 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c @@ -1205,6 +1205,9 @@ static int stmmac_init_phy(struct net_device *dev) return -ENODEV; } + if (priv->dma_cap.eee) + phy_support_eee(phydev); + ret = phylink_connect_phy(priv->phylink, phydev); } else { fwnode_handle_put(phy_fwnode);
Set the initial eee_cfg values to have 'ethtool --show-eee ' display the initial EEE configuration. Fixes: 49168d1980e2 ("net: phy: Add phy_support_eee() indicating MAC support EEE") Cc: <stable@vger.kernel.org> Signed-off-by: Choong Yong Liang <yong.liang.choong@linux.intel.com> --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +++ 1 file changed, 3 insertions(+)