diff mbox series

[nfs-utils,2/2] nfsdctl: clarify when versions can be set on the man page

Message ID 20241118201902.1115861-3-smayhew@redhat.com (mailing list archive)
State New
Headers show
Series nfsdctl fixes | expand

Commit Message

Scott Mayhew Nov. 18, 2024, 8:19 p.m. UTC
Attempting to make version changes while there are nfsd threads running
fails with -EBUSY, so make note of it on the man page.

Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
 utils/nfsdctl/nfsdctl.8    | 12 ++++++++++--
 utils/nfsdctl/nfsdctl.adoc |  2 ++
 2 files changed, 12 insertions(+), 2 deletions(-)

Comments

Steve Dickson Nov. 20, 2024, 8:53 p.m. UTC | #1
On 11/18/24 3:19 PM, Scott Mayhew wrote:
> Attempting to make version changes while there are nfsd threads running
> fails with -EBUSY, so make note of it on the man page.
> 
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed... (tag: nfs-utils-2-8-2-rc2)

steved.
> ---
>   utils/nfsdctl/nfsdctl.8    | 12 ++++++++++--
>   utils/nfsdctl/nfsdctl.adoc |  2 ++
>   2 files changed, 12 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/nfsdctl/nfsdctl.8 b/utils/nfsdctl/nfsdctl.8
> index dae1863d..38dd1d30 100644
> --- a/utils/nfsdctl/nfsdctl.8
> +++ b/utils/nfsdctl/nfsdctl.8
> @@ -2,12 +2,12 @@
>   .\"     Title: nfsdctl
>   .\"    Author: Jeff Layton
>   .\" Generator: Asciidoctor 2.0.20
> -.\"      Date: 2024-07-22
> +.\"      Date: 2024-11-18
>   .\"    Manual: \ \&
>   .\"    Source: \ \&
>   .\"  Language: English
>   .\"
> -.TH "NFSDCTL" "8" "2024-07-22" "\ \&" "\ \&"
> +.TH "NFSDCTL" "8" "2024-11-18" "\ \&" "\ \&"
>   .ie \n(.g .ds Aq \(aq
>   .el       .ds Aq '
>   .ss \n[.ss] 0
> @@ -176,6 +176,14 @@ all minorversions for that major version.
>   .fam
>   .fi
>   .if n .RE
> +.sp
> +.if n .RS 4
> +.nf
> +.fam C
> +Note that versions can only be set when there are no nfsd threads running.
> +.fam
> +.fi
> +.if n .RE
>   .RE
>   .sp
>   \fBpool\-mode\fP
> diff --git a/utils/nfsdctl/nfsdctl.adoc b/utils/nfsdctl/nfsdctl.adoc
> index 7119b44d..79f07cf0 100644
> --- a/utils/nfsdctl/nfsdctl.adoc
> +++ b/utils/nfsdctl/nfsdctl.adoc
> @@ -93,6 +93,8 @@ Each subcommand can also accept its own set of options and arguments. The
>     The minorversion field is optional. If not given, it will disable or enable
>     all minorversions for that major version.
>   
> +  Note that versions can only be set when there are no nfsd threads running.
> +
>   *pool-mode*::
>   
>     Get/set the host's pool mode. This will cause the server to start threads
diff mbox series

Patch

diff --git a/utils/nfsdctl/nfsdctl.8 b/utils/nfsdctl/nfsdctl.8
index dae1863d..38dd1d30 100644
--- a/utils/nfsdctl/nfsdctl.8
+++ b/utils/nfsdctl/nfsdctl.8
@@ -2,12 +2,12 @@ 
 .\"     Title: nfsdctl
 .\"    Author: Jeff Layton
 .\" Generator: Asciidoctor 2.0.20
-.\"      Date: 2024-07-22
+.\"      Date: 2024-11-18
 .\"    Manual: \ \&
 .\"    Source: \ \&
 .\"  Language: English
 .\"
-.TH "NFSDCTL" "8" "2024-07-22" "\ \&" "\ \&"
+.TH "NFSDCTL" "8" "2024-11-18" "\ \&" "\ \&"
 .ie \n(.g .ds Aq \(aq
 .el       .ds Aq '
 .ss \n[.ss] 0
@@ -176,6 +176,14 @@  all minorversions for that major version.
 .fam
 .fi
 .if n .RE
+.sp
+.if n .RS 4
+.nf
+.fam C
+Note that versions can only be set when there are no nfsd threads running.
+.fam
+.fi
+.if n .RE
 .RE
 .sp
 \fBpool\-mode\fP
diff --git a/utils/nfsdctl/nfsdctl.adoc b/utils/nfsdctl/nfsdctl.adoc
index 7119b44d..79f07cf0 100644
--- a/utils/nfsdctl/nfsdctl.adoc
+++ b/utils/nfsdctl/nfsdctl.adoc
@@ -93,6 +93,8 @@  Each subcommand can also accept its own set of options and arguments. The
   The minorversion field is optional. If not given, it will disable or enable
   all minorversions for that major version.
 
+  Note that versions can only be set when there are no nfsd threads running.
+
 *pool-mode*::
 
   Get/set the host's pool mode. This will cause the server to start threads