| Message ID | 20241119150519.1123365-12-berrange@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | test/functional: improve functional test debugging & fix tuxrun | expand |
On 19/11/2024 16.05, Daniel P. Berrangé wrote: > Set the 'qemu.machine' logger to 'DEBUG' level, to ensure we see log > messages related to the QEMUMachine class. Most importantly this > ensures we capture the full QEMU command line args for instances we > spawn. > > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> > --- > tests/functional/qemu_test/testcase.py | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py > index f9c9de1166..e2a329c3e5 100644 > --- a/tests/functional/qemu_test/testcase.py > +++ b/tests/functional/qemu_test/testcase.py > @@ -57,9 +57,15 @@ def setUp(self, bin_prefix): > self._log_fh.setFormatter(fileFormatter) > self.log.addHandler(self._log_fh) > > + # Capture QEMUMachine logging > + self.machinelog = logging.getLogger('qemu.machine') > + self.machinelog.setLevel(logging.DEBUG) > + self.machinelog.addHandler(self._log_fh) > + > def tearDown(self): > if "QEMU_TEST_KEEP_SCRATCH" not in os.environ: > shutil.rmtree(self.workdir) > + self.machinelog.removeHandler(self._log_fh) > self.log.removeHandler(self._log_fh) > > def main(): That looks better in the logs, indeed! Tested-by: Thomas Huth <thuth@redhat.com>
diff --git a/tests/functional/qemu_test/testcase.py b/tests/functional/qemu_test/testcase.py index f9c9de1166..e2a329c3e5 100644 --- a/tests/functional/qemu_test/testcase.py +++ b/tests/functional/qemu_test/testcase.py @@ -57,9 +57,15 @@ def setUp(self, bin_prefix): self._log_fh.setFormatter(fileFormatter) self.log.addHandler(self._log_fh) + # Capture QEMUMachine logging + self.machinelog = logging.getLogger('qemu.machine') + self.machinelog.setLevel(logging.DEBUG) + self.machinelog.addHandler(self._log_fh) + def tearDown(self): if "QEMU_TEST_KEEP_SCRATCH" not in os.environ: shutil.rmtree(self.workdir) + self.machinelog.removeHandler(self._log_fh) self.log.removeHandler(self._log_fh) def main():
Set the 'qemu.machine' logger to 'DEBUG' level, to ensure we see log messages related to the QEMUMachine class. Most importantly this ensures we capture the full QEMU command line args for instances we spawn. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- tests/functional/qemu_test/testcase.py | 6 ++++++ 1 file changed, 6 insertions(+)