Message ID | 20241119-v6-10-topic-touchscreen-axiom-v1-3-6124925b9718@pengutronix.de (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | Input: Add support for TouchNetix aXiom touchscreen | expand |
On Tue, Nov 19, 2024 at 11:33:52PM +0100, Marco Felsch wrote: > From: Kamel Bouhara <kamel.bouhara@bootlin.com> > > Add vendor prefix for TouchNetix AS (https://www.touchnetix.com/products/). > > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> I think this did not happen (only Ack). Best regards, Krzysztof
On 24-11-20, Krzysztof Kozlowski wrote: > On Tue, Nov 19, 2024 at 11:33:52PM +0100, Marco Felsch wrote: > > From: Kamel Bouhara <kamel.bouhara@bootlin.com> > > > > Add vendor prefix for TouchNetix AS (https://www.touchnetix.com/products/). > > > > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > I think this did not happen (only Ack). Huh.. I used b4 to retrieve the latest Bootlin version. According [1] it was already present :/ I can drop it if you want. [1] https://lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/ Regards, Marco > > Best regards, > Krzysztof > >
On 20/11/2024 09:15, Marco Felsch wrote: > On 24-11-20, Krzysztof Kozlowski wrote: >> On Tue, Nov 19, 2024 at 11:33:52PM +0100, Marco Felsch wrote: >>> From: Kamel Bouhara <kamel.bouhara@bootlin.com> >>> >>> Add vendor prefix for TouchNetix AS (https://www.touchnetix.com/products/). >>> >>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> >>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> I think this did not happen (only Ack). > > Huh.. I used b4 to retrieve the latest Bootlin version. According [1] it > was already present :/ I can drop it if you want. > > [1] https://lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/ > Hm? This points to entirely different patch! Best regards, Krzysztof
Le 2024-11-21 08:47, Krzysztof Kozlowski a écrit : > On 20/11/2024 09:15, Marco Felsch wrote: >> On 24-11-20, Krzysztof Kozlowski wrote: >>> On Tue, Nov 19, 2024 at 11:33:52PM +0100, Marco Felsch wrote: >>>> From: Kamel Bouhara <kamel.bouhara@bootlin.com> >>>> >>>> Add vendor prefix for TouchNetix AS >>>> (https://www.touchnetix.com/products/). >>>> >>>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> >>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> I think this did not happen (only Ack). >> >> Huh.. I used b4 to retrieve the latest Bootlin version. According [1] >> it >> was already present :/ I can drop it if you want. >> >> [1] >> https://lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/ >> > Hm? This points to entirely different patch! > Hello Marco, I think the last review from Krzystof is on v7 [1] ? [1]: https://lore.kernel.org/linux-kernel/821ce1d4-bc15-4764-bbe0-315c57e8536e@linaro.org/ Regards, -- Kamel Bouhara, Bootlin Embedded Linux and kernel engineering https://bootlin.com
On 24-11-21, Kamel BOUHARA wrote: > Le 2024-11-21 08:47, Krzysztof Kozlowski a écrit : > > On 20/11/2024 09:15, Marco Felsch wrote: > > > On 24-11-20, Krzysztof Kozlowski wrote: > > > > On Tue, Nov 19, 2024 at 11:33:52PM +0100, Marco Felsch wrote: > > > > > From: Kamel Bouhara <kamel.bouhara@bootlin.com> > > > > > > > > > > Add vendor prefix for TouchNetix AS > > > > > (https://www.touchnetix.com/products/). > > > > > > > > > > Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> > > > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > > > > > > I think this did not happen (only Ack). > > > > > > Huh.. I used b4 to retrieve the latest Bootlin version. According > > > [1] it > > > was already present :/ I can drop it if you want. > > > > > > [1] https://lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/ > > > > > Hm? This points to entirely different patch! > > > > Hello Marco, > > I think the last review from Krzystof is on v7 [1] ? > > [1]: https://lore.kernel.org/linux-kernel/821ce1d4-bc15-4764-bbe0-315c57e8536e@linaro.org/ Yeah Krzysztof is right, I pointed to the wrong patch, but still I didn't added the reviewed-by tag but b4 did. I ran it again and here it is: $ b4 am https://lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/ Grabbing thread from lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/t.mbox.gz Analyzing 9 messages in the thread Looking for additional code-review trailers on lore.kernel.org Analyzing 137 code-review messages Checking attestation on all messages, may take a moment... --- ✓ [PATCH v16 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS + Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> (✗ DKIM/linaro.org) ✓ [PATCH v16 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen ✓ [PATCH v16 3/3] Input: Add TouchNetix axiom i2c touchscreen driver --- ✓ Signed: DKIM/bootlin.com --- Total patches: 3 Krzysztof I'm sorry, shall I drop it from the next version? Regards, Marco
On 21/11/2024 09:45, Marco Felsch wrote: > On 24-11-21, Kamel BOUHARA wrote: >> Le 2024-11-21 08:47, Krzysztof Kozlowski a écrit : >>> On 20/11/2024 09:15, Marco Felsch wrote: >>>> On 24-11-20, Krzysztof Kozlowski wrote: >>>>> On Tue, Nov 19, 2024 at 11:33:52PM +0100, Marco Felsch wrote: >>>>>> From: Kamel Bouhara <kamel.bouhara@bootlin.com> >>>>>> >>>>>> Add vendor prefix for TouchNetix AS >>>>>> (https://www.touchnetix.com/products/). >>>>>> >>>>>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com> >>>>>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> >>>>> I think this did not happen (only Ack). >>>> >>>> Huh.. I used b4 to retrieve the latest Bootlin version. According >>>> [1] it >>>> was already present :/ I can drop it if you want. >>>> >>>> [1] https://lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/ >>>> >>> Hm? This points to entirely different patch! >>> >> >> Hello Marco, >> >> I think the last review from Krzystof is on v7 [1] ? >> >> [1]: https://lore.kernel.org/linux-kernel/821ce1d4-bc15-4764-bbe0-315c57e8536e@linaro.org/ > > Yeah Krzysztof is right, I pointed to the wrong patch, but still I > didn't added the reviewed-by tag but b4 did. I ran it again and here it > is: I know, it happens sometimes. I also experienced it. > > $ b4 am https://lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/ > Grabbing thread from lore.kernel.org/all/20240703142520.207066-3-kamel.bouhara@bootlin.com/t.mbox.gz > Analyzing 9 messages in the thread > Looking for additional code-review trailers on lore.kernel.org > Analyzing 137 code-review messages > Checking attestation on all messages, may take a moment... > --- > ✓ [PATCH v16 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS > + Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> (✗ DKIM/linaro.org) > ✓ [PATCH v16 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen > ✓ [PATCH v16 3/3] Input: Add TouchNetix axiom i2c touchscreen driver > --- > ✓ Signed: DKIM/bootlin.com > --- > Total patches: 3 > > Krzysztof I'm sorry, shall I drop it from the next version? Yeah, please drop from this patch and keep only Ack here. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index b320a39de7fe..c40170c0c387 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -1515,6 +1515,8 @@ patternProperties: description: Toradex AG "^toshiba,.*": description: Toshiba Corporation + "^touchnetix,.*": + description: TouchNetix AS "^toumaz,.*": description: Toumaz "^tpk,.*":