[net-next,v2,00/21] net:yt6801: Add Motorcomm yt6801 PCIe driver

Message ID	20241120105625.22508-1-Frank.Sae@motor-comm.com (mailing list archive)
Headers	show Received: from out198-12.us.a.mail.aliyun.com (out198-12.us.a.mail.aliyun.com [47.90.198.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0DE5A1A0715; Wed, 20 Nov 2024 10:56:51 +0000 (UTC) From: Frank Sae <Frank.Sae@motor-comm.com> To: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xiaogang.fan@motor-comm.com, fei.zhang@motor-comm.com, hua.sun@motor-comm.com, Frank.Sae@motor-comm.com Subject: [PATCH net-next v2 00/21] net:yt6801: Add Motorcomm yt6801 PCIe driver Date: Wed, 20 Nov 2024 18:56:04 +0800 Message-Id: <20241120105625.22508-1-Frank.Sae@motor-comm.com> Precedence: bulk MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit
Series	net:yt6801: Add Motorcomm yt6801 PCIe driver \| expand [net-next,v2,00/21] net:yt6801: Add Motorcomm yt6801 PCIe driver [net-next,v2,03/21] motorcomm:yt6801: Implement the fxgmac_drv_probe function [net-next,v2,04/21] motorcomm:yt6801: Implement the .ndo_open function [net-next,v2,05/21] motorcomm:yt6801: Implement the fxgmac_start function [net-next,v2,08/21] motorcomm:yt6801: Implement the fxgmac_read_mac_addr function [net-next,v2,12/21] motorcomm:yt6801: Implement .ndo_tx_timeout and .ndo_change_mtu functions [net-next,v2,13/21] motorcomm:yt6801: Implement some ethtool_ops function [net-next,v2,14/21] motorcomm:yt6801: Implement the WOL function of ethtool_ops [net-next,v2,15/21] motorcomm:yt6801: Implement pci_driver suspend and resume [net-next,v2,16/21] motorcomm:yt6801: Add a Makefile in the motorcomm folder [net-next,v2,17/21] motorcomm:yt6801: Update the Makefile and Kconfig in the motorcomm [net-next,v2,18/21] motorcomm:yt6801: Update the Makefile and Kconfig in the ethernet [net-next,v2,19/21] ethernet: Update the index.rst in the ethernet documentation folder [net-next,v2,20/21] motorcomm:yt6801: Add a yt6801.rst in the ethernet documentation folder [net-next,v2,21/21] MAINTAINERS：Add the motorcomm ethernet driver entry [net-next,v2,11/21] motorcomm:yt6801: Implement some net_device_ops function [net-next,v2,09/21] motorcomm:yt6801: Implement some hw_ops function [net-next,v2,07/21] motorcomm:yt6801: Implement the fxgmac_init function [net-next,v2,02/21] motorcomm:yt6801: Implement pci_driver shutdown [net-next,v2,01/21] motorcomm:yt6801: Add support for a pci table in this module [net-next,v2,06/21] motorcomm:yt6801: Implement the poll functions [net-next,v2,10/21] motorcomm:yt6801: Implement .ndo_start_xmit function

Message ID

20241120105625.22508-1-Frank.Sae@motor-comm.com (mailing list archive)

Headers

From: Frank Sae <Frank.Sae@motor-comm.com>
To: davem@davemloft.net,
	edumazet@google.com,
	kuba@kernel.org,
	pabeni@redhat.com
Cc: netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	xiaogang.fan@motor-comm.com,
	fei.zhang@motor-comm.com,
	hua.sun@motor-comm.com,
	Frank.Sae@motor-comm.com
Subject: [PATCH net-next v2 00/21] net:yt6801: Add Motorcomm yt6801 PCIe
 driver
Date: Wed, 20 Nov 2024 18:56:04 +0800
Message-Id: <20241120105625.22508-1-Frank.Sae@motor-comm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Series

net:yt6801: Add Motorcomm yt6801 PCIe driver | expand

Message

Frank Sae Nov. 20, 2024, 10:56 a.m. UTC

This series includes adding Motorcomm YT6801 Gigabit ethernet driver
and adding yt6801 ethernet driver entry in MAINTAINERS file.

YT6801 integrates a YT8531S phy.

v1 -> v2:
- Split this driver into multiple patches.
- Reorganize this driver code and remove redundant code
- Remove PHY handling code and use phylib.
- Remove writing ASPM config
- Use generic power management instead of pci_driver.suspend()/resume()
- Add Space before closing "*/"

Frank Sae (21):
  motorcomm:yt6801: Add support for a pci table in this module
  motorcomm:yt6801: Implement pci_driver shutdown
  motorcomm:yt6801: Implement the fxgmac_drv_probe function
  motorcomm:yt6801: Implement the .ndo_open function
  motorcomm:yt6801: Implement the fxgmac_start function
  motorcomm:yt6801: Implement the poll functions
  motorcomm:yt6801: Implement the fxgmac_init function
  motorcomm:yt6801: Implement the fxgmac_read_mac_addr function
  motorcomm:yt6801: Implement some hw_ops function
  motorcomm:yt6801: Implement .ndo_start_xmit function
  motorcomm:yt6801: Implement some net_device_ops function
  motorcomm:yt6801: Implement .ndo_tx_timeout and .ndo_change_mtu
    functions
  motorcomm:yt6801: Implement some ethtool_ops function
  motorcomm:yt6801: Implement the WOL function of ethtool_ops
  motorcomm:yt6801: Implement pci_driver suspend and resume
  motorcomm:yt6801: Add a Makefile in the motorcomm folder
  motorcomm:yt6801: Update the Makefile and Kconfig in the motorcomm
  motorcomm:yt6801: Update the Makefile and Kconfig in the ethernet
  ethernet: Update the index.rst in the ethernet documentation folder
  motorcomm:yt6801: Add a yt6801.rst in the ethernet documentation
    folder
  MAINTAINERS：Add the motorcomm ethernet driver entry

 .../device_drivers/ethernet/index.rst         |    1 +
 .../ethernet/motorcomm/yt6801.rst             |   20 +
 MAINTAINERS                                   |    8 +
 drivers/net/ethernet/Kconfig                  |    1 +
 drivers/net/ethernet/Makefile                 |    1 +
 drivers/net/ethernet/motorcomm/Kconfig        |   27 +
 drivers/net/ethernet/motorcomm/Makefile       |    6 +
 .../net/ethernet/motorcomm/yt6801/Makefile    |    9 +
 .../net/ethernet/motorcomm/yt6801/yt6801.h    |  617 +++
 .../ethernet/motorcomm/yt6801/yt6801_desc.c   |  638 ++++
 .../ethernet/motorcomm/yt6801/yt6801_desc.h   |   39 +
 .../motorcomm/yt6801/yt6801_ethtool.c         |  907 +++++
 .../net/ethernet/motorcomm/yt6801/yt6801_hw.c | 3383 +++++++++++++++++
 .../ethernet/motorcomm/yt6801/yt6801_net.c    | 2908 ++++++++++++++
 .../ethernet/motorcomm/yt6801/yt6801_net.h    |   32 +
 .../ethernet/motorcomm/yt6801/yt6801_pci.c    |  191 +
 .../ethernet/motorcomm/yt6801/yt6801_type.h   | 1398 +++++++
 17 files changed, 10186 insertions(+)
 create mode 100644 Documentation/networking/device_drivers/ethernet/motorcomm/yt6801.rst
 create mode 100644 drivers/net/ethernet/motorcomm/Kconfig
 create mode 100644 drivers/net/ethernet/motorcomm/Makefile
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/Makefile
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801.h
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_desc.c
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_desc.h
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_ethtool.c
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_hw.c
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_net.c
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_net.h
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_pci.c
 create mode 100644 drivers/net/ethernet/motorcomm/yt6801/yt6801_type.h

Comments

Paolo Abeni Nov. 21, 2024, 9 a.m. UTC | #1

On 11/20/24 11:56, Frank Sae wrote:
> This series includes adding Motorcomm YT6801 Gigabit ethernet driver
> and adding yt6801 ethernet driver entry in MAINTAINERS file.
> 
> YT6801 integrates a YT8531S phy.

Please have a better read to the process documentation and specifically at:

https://elixir.bootlin.com/linux/v6.11.8/source/Documentation/process/maintainer-netdev.rst#L14

before your next submission.

Additionally:

## Form letter - net-next-closed

The merge window for v6.13 has begun and net-next is closed for new
drivers, features, code refactoring and optimizations. We are currently
accepting bug fixes only.

Please repost when net-next reopens after Dec 2nd.

RFC patches sent for review only are welcome at any time.

See:
https://www.kernel.org/doc/html/next/process/maintainer-netdev.html#development-cycle

Andrew Lunn Nov. 22, 2024, 10:14 p.m. UTC | #2

On Wed, Nov 20, 2024 at 06:56:04PM +0800, Frank Sae wrote:
> This series includes adding Motorcomm YT6801 Gigabit ethernet driver
> and adding yt6801 ethernet driver entry in MAINTAINERS file.
> 
> YT6801 integrates a YT8531S phy.
> 
> v1 -> v2:
> - Split this driver into multiple patches.
> - Reorganize this driver code and remove redundant code
> - Remove PHY handling code and use phylib.
> - Remove writing ASPM config
> - Use generic power management instead of pci_driver.suspend()/resume()
> - Add Space before closing "*/"

Looking quickly through the code, i see a lot of yt_dbg(), many more
than typical. It makes it feel like you are still debugging this
driver.

Please consider removing most of them.

	Andrew

Andrew Lunn Nov. 23, 2024, 12:45 a.m. UTC | #3

On Wed, Nov 20, 2024 at 06:56:04PM +0800, Frank Sae wrote:
> This series includes adding Motorcomm YT6801 Gigabit ethernet driver
> and adding yt6801 ethernet driver entry in MAINTAINERS file.
> 
> YT6801 integrates a YT8531S phy.
> 
> v1 -> v2:
> - Split this driver into multiple patches.
> - Reorganize this driver code and remove redundant code

I would say this is still too much code for one submission. You don't
need every feature in the first patch series. Please post just post a
basic driver without all the optional features. Keep to the 15 patch
limit. You can the add more features in follow up patch sets.

	Andrew