| Message ID | 20241119022050.2995511-2-quic_liuxin@quicinc.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Enable UFS on QCS615 | expand |
On 19/11/2024 03:20, Xin Liu wrote: > From: Sayali Lokhande <quic_sayalil@quicinc.com> > > Document the Universal Flash Storage(UFS) Host Controller on the Qualcomm > QCS615 Platform. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com> > Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> > Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> That's a bit odd SoB chain. First, these are just one-liners. Second, who authored the patches? Best regards, Krzysztof
On 20/11/2024 17:57, Krzysztof Kozlowski wrote: > On 19/11/2024 03:20, Xin Liu wrote: >> From: Sayali Lokhande <quic_sayalil@quicinc.com> >> >> Document the Universal Flash Storage(UFS) Host Controller on the Qualcomm >> QCS615 Platform. >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com> >> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> > That's a bit odd SoB chain. First, these are just one-liners. Second, > who authored the patches? To be clear: SoB regarding authorship is correct, but regarding Acks and Reviews is not. Savali did not receive these tags. If so, please point to lore discussion with it. All this needs fixing. Best regards, Krzysztof
在 2024/11/21 15:40, Krzysztof Kozlowski 写道: > On 20/11/2024 17:57, Krzysztof Kozlowski wrote: >> On 19/11/2024 03:20, Xin Liu wrote: >>> From: Sayali Lokhande <quic_sayalil@quicinc.com> >>> >>> Document the Universal Flash Storage(UFS) Host Controller on the Qualcomm >>> QCS615 Platform. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com> >>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >> That's a bit odd SoB chain. First, these are just one-liners. Second, >> who authored the patches? > To be clear: SoB regarding authorship is correct, but regarding Acks and > Reviews is not. Savali did not receive these tags. If so, please point > to lore discussion with it. > > All this needs fixing. Thank you for your comments. These are the two reviews I received. One is your reviewd-by, and the other is Manivannan's acked-by.I have also cc Sayali on the email. https://lore.kernel.org/linux-arm-msm/rv3ukz6rhgp3x32s74nbftmoqmdxjxmoii3zsd4wipmhudyq7q@ha4l2svl5lim/ https://lore.kernel.org/linux-arm-msm/20241112075619.2ilsccnnk4leqmdy@thinkpad/ > > Best regards, > Krzysztof
On 21/11/2024 09:37, Xin Liu wrote: > > > 在 2024/11/21 15:40, Krzysztof Kozlowski 写道: >> On 20/11/2024 17:57, Krzysztof Kozlowski wrote: >>> On 19/11/2024 03:20, Xin Liu wrote: >>>> From: Sayali Lokhande <quic_sayalil@quicinc.com> >>>> >>>> Document the Universal Flash Storage(UFS) Host Controller on the Qualcomm >>>> QCS615 Platform. >>>> >>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>>> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com> >>>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >>> That's a bit odd SoB chain. First, these are just one-liners. Second, >>> who authored the patches? >> To be clear: SoB regarding authorship is correct, but regarding Acks and >> Reviews is not. Savali did not receive these tags. If so, please point >> to lore discussion with it. >> >> All this needs fixing. > Thank you for your comments. These are the two reviews I received. One > is your reviewd-by, and the other is Manivannan's acked-by.I have also > cc Sayali on the email. > > https://lore.kernel.org/linux-arm-msm/rv3ukz6rhgp3x32s74nbftmoqmdxjxmoii3zsd4wipmhudyq7q@ha4l2svl5lim/ > > https://lore.kernel.org/linux-arm-msm/20241112075619.2ilsccnnk4leqmdy@thinkpad/ I meant order of tags. Who received them? You, not Sayali. Then they cannot be before Sayali SoB. Best regards, Krzysztof
在 2024/11/21 18:01, Krzysztof Kozlowski 写道: > On 21/11/2024 09:37, Xin Liu wrote: >> >> >> 在 2024/11/21 15:40, Krzysztof Kozlowski 写道: >>> On 20/11/2024 17:57, Krzysztof Kozlowski wrote: >>>> On 19/11/2024 03:20, Xin Liu wrote: >>>>> From: Sayali Lokhande <quic_sayalil@quicinc.com> >>>>> >>>>> Document the Universal Flash Storage(UFS) Host Controller on the Qualcomm >>>>> QCS615 Platform. >>>>> >>>>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>>>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>>>> Signed-off-by: Sayali Lokhande <quic_sayalil@quicinc.com> >>>>> Co-developed-by: Xin Liu <quic_liuxin@quicinc.com> >>>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >>>> That's a bit odd SoB chain. First, these are just one-liners. Second, >>>> who authored the patches? >>> To be clear: SoB regarding authorship is correct, but regarding Acks and >>> Reviews is not. Savali did not receive these tags. If so, please point >>> to lore discussion with it. >>> >>> All this needs fixing. >> Thank you for your comments. These are the two reviews I received. One >> is your reviewd-by, and the other is Manivannan's acked-by.I have also >> cc Sayali on the email. >> >> https://lore.kernel.org/linux-arm-msm/rv3ukz6rhgp3x32s74nbftmoqmdxjxmoii3zsd4wipmhudyq7q@ha4l2svl5lim/ >> >> https://lore.kernel.org/linux-arm-msm/20241112075619.2ilsccnnk4leqmdy@thinkpad/ > > I meant order of tags. Who received them? You, not Sayali. Then they > cannot be before Sayali SoB. > Thank you for your comments. I will fix it next version. > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index cde334e3206b..a03fff5df5ef 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -26,6 +26,7 @@ properties: - qcom,msm8994-ufshc - qcom,msm8996-ufshc - qcom,msm8998-ufshc + - qcom,qcs615-ufshc - qcom,qcs8300-ufshc - qcom,sa8775p-ufshc - qcom,sc7180-ufshc @@ -243,6 +244,7 @@ allOf: compatible: contains: enum: + - qcom,qcs615-ufshc - qcom,sm6115-ufshc - qcom,sm6125-ufshc then: