| Message ID | 20241119102315.3167607-4-quic_liuxin@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Enable Watchdog on QCS8300 | expand |
On 19/11/2024 11:23, Xin Liu wrote: > Add watchdog clock on the Qualcomm QCS8300 Ride platform. > > Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> > --- > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > index 7eed19a694c3..3024338bcfbc 100644 > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > @@ -265,3 +265,7 @@ &ufs_mem_phy { > vdda-pll-supply = <&vreg_l5a>; > status = "okay"; > }; > + > +&watchdog { > + clocks = <&sleep_clk>; > +}; > \ No newline at end of file Look, your patches have errors... Best regards, Krzysztof
在 2024/11/21 0:59, Krzysztof Kozlowski 写道: > On 19/11/2024 11:23, Xin Liu wrote: >> Add watchdog clock on the Qualcomm QCS8300 Ride platform. >> >> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >> --- >> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> index 7eed19a694c3..3024338bcfbc 100644 >> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >> @@ -265,3 +265,7 @@ &ufs_mem_phy { >> vdda-pll-supply = <&vreg_l5a>; >> status = "okay"; >> }; >> + >> +&watchdog { >> + clocks = <&sleep_clk>; >> +}; >> \ No newline at end of file > > Look, your patches have errors... > This is the information when I apply my patch. ../linux-next$ git am ./wdt/test.patch Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node ../linux-next$ There are no error messages here. > > Best regards, > Krzysztof
On 21/11/2024 10:44, Xin Liu wrote: > > > 在 2024/11/21 0:59, Krzysztof Kozlowski 写道: >> On 19/11/2024 11:23, Xin Liu wrote: >>> Add watchdog clock on the Qualcomm QCS8300 Ride platform. >>> >>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >>> --- >>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>> index 7eed19a694c3..3024338bcfbc 100644 >>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>> @@ -265,3 +265,7 @@ &ufs_mem_phy { >>> vdda-pll-supply = <&vreg_l5a>; >>> status = "okay"; >>> }; >>> + >>> +&watchdog { >>> + clocks = <&sleep_clk>; >>> +}; >>> \ No newline at end of file >> >> Look, your patches have errors... >> > This is the information when I apply my patch. > ../linux-next$ git am ./wdt/test.patch > Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node > ../linux-next$ > > There are no error messages here. So I made up that above error message? You sent patch with an error message. I responded directly under it, so what can I say more? You refuse to fix this, so I NAK this patch. Best regards, Krzysztof
在 2024/11/21 18:19, Krzysztof Kozlowski 写道: > On 21/11/2024 10:44, Xin Liu wrote: >> >> >> 在 2024/11/21 0:59, Krzysztof Kozlowski 写道: >>> On 19/11/2024 11:23, Xin Liu wrote: >>>> Add watchdog clock on the Qualcomm QCS8300 Ride platform. >>>> >>>> Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> >>>> --- >>>> arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>>> index 7eed19a694c3..3024338bcfbc 100644 >>>> --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>>> +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts >>>> @@ -265,3 +265,7 @@ &ufs_mem_phy { >>>> vdda-pll-supply = <&vreg_l5a>; >>>> status = "okay"; >>>> }; >>>> + >>>> +&watchdog { >>>> + clocks = <&sleep_clk>; >>>> +}; >>>> \ No newline at end of file >>> >>> Look, your patches have errors... >>> >> This is the information when I apply my patch. >> ../linux-next$ git am ./wdt/test.patch >> Applying: arm64: dts: qcom: qcs8300-ride: Add watchdog node >> ../linux-next$ >> >> There are no error messages here. > > So I made up that above error message? You sent patch with an error > message. I responded directly under it, so what can I say more? > > You refuse to fix this, so I NAK this patch. Sorry, that's not what I meant. I realize my mistake and I will fix this issue in the next version. Thank you for your comments. > Best regards, > Krzysztof
On Wed, Nov 20, 2024 at 05:59:21PM +0100, Krzysztof Kozlowski wrote: > On 19/11/2024 11:23, Xin Liu wrote: > > Add watchdog clock on the Qualcomm QCS8300 Ride platform. > > > > Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> > > --- > > arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > index 7eed19a694c3..3024338bcfbc 100644 > > --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts > > @@ -265,3 +265,7 @@ &ufs_mem_phy { > > vdda-pll-supply = <&vreg_l5a>; > > status = "okay"; > > }; > > + > > +&watchdog { > > + clocks = <&sleep_clk>; > > +}; > > \ No newline at end of file > > Look, your patches have errors... But it's not an error, it is a part of the patch format, telling that there was no \n on the last line. We might prefer having files with tail \n, but I'd not call it an error. Nevertheless, I agree, it should be fixed.
diff --git a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts index 7eed19a694c3..3024338bcfbc 100644 --- a/arch/arm64/boot/dts/qcom/qcs8300-ride.dts +++ b/arch/arm64/boot/dts/qcom/qcs8300-ride.dts @@ -265,3 +265,7 @@ &ufs_mem_phy { vdda-pll-supply = <&vreg_l5a>; status = "okay"; }; + +&watchdog { + clocks = <&sleep_clk>; +}; \ No newline at end of file
Add watchdog clock on the Qualcomm QCS8300 Ride platform. Signed-off-by: Xin Liu <quic_liuxin@quicinc.com> --- arch/arm64/boot/dts/qcom/qcs8300-ride.dts | 4 ++++ 1 file changed, 4 insertions(+)