mbox series

[RFC,net-next,v3,00/27] Add support for PSE port priority

Message ID 20241121-feature_poe_port_prio-v3-0-83299fa6967c@bootlin.com (mailing list archive)
Headers show
Series Add support for PSE port priority | expand

Message

Kory Maincent Nov. 21, 2024, 2:42 p.m. UTC 
From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

This series brings support for port priority in the PSE subsystem.
PSE controllers can set priorities to decide which ports should be
turned off in case of special events like over-current.

I have added regulator maintainers to have their opinion on adding power
budget regulator constraint see patches 16 and 17.
There are also a few core regulator change along the way, patch 3 and 15.
Not sure if they have to be sent with the Fixes tag.
Also, I suppose I will need to merge them through the regulator tree.
Will it be possible to create an immutable tag to have this PSE series
based on them?

This patch series adds support for two mode port priority modes.
1. Static Method:

   This method involves distributing power based on PD classification.
   It’s straightforward and stable, the PSE core keeping track of the
   budget and subtracting the power requested by each PD’s class.

   Advantages: Every PD gets its promised power at any time, which
   guarantees reliability.

   Disadvantages: PD classification steps are large, meaning devices
   request much more power than they actually need. As a result, the power
   supply may only operate at, say, 50% capacity, which is inefficient and
   wastes money.

2. Dynamic Method:

   To address the inefficiencies of the static method, vendors like
   Microchip have introduced dynamic power budgeting, as seen in the
   PD692x0 firmware. This method monitors the current consumption per port
   and subtracts it from the available power budget. When the budget is
   exceeded, lower-priority ports are shut down.

   Advantages: This method optimizes resource utilization, saving costs.

   Disadvantages: Low-priority devices may experience instability.

The UAPI allows adding support for software port priority mode managed from
userspace later if needed.

This patch series is currently not fully tested. I would appreciate your
feedback on the current implementation of port priority in the PSE core.

Several Reviewed-by have been removed due to the changes.

Thanks Oleksij for your pointers.

Patches 1-7: Cosmetics.
Patch 8: Adds support for last supported features in the TPS23881 drivers.
Patches 9,10: Add support for PSE index in PSE core and ethtool.
Patches 11-13: Add support for interrupt event report in PSE core, ethtool
	     and ethtool specs.
Patch 14: Adds support for interrupt and event report in TPS23881 driver.
Patch 15: Fix regulator resolve supply
Patches 16,17: Add support for power budget in regulator framework.
Patch 18: Cosmetic.
Patches 19,20: Add support for PSE power domain in PSE core and ethtool.
Patches 21-23: Add support for port priority in PSE core, ethtool and
	       ethtool specs.
Patches 24,25: Add support for port priority in PD692x0 drivers.
Patches 26,27: Add support for port priority in TPS23881 drivers.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
Changes in v3:
- Move power budget to regulator core.
- Add disconnection policies with PIs using the same priority.
- Several fixes on the TPS23881 drivers.
- Several new cosmetic patches.
- Link to v2: https://lore.kernel.org/r/20241030-feature_poe_port_prio-v2-0-9559622ee47a@bootlin.com

Changes in v2:
- Rethink the port priority management.
- Add PSE id.
- Add support for PSE power domains.
- Add get power budget regulator constraint.
- Link to v1: https://lore.kernel.org/r/20241002-feature_poe_port_prio-v1-0-787054f74ed5@bootlin.com

---
Kory Maincent (26):
      net: pse-pd: Remove unused pse_ethtool_get_pw_limit function declaration
      regulator: core: Ignore unset max_uA constraints in current limit check
      net: pse-pd: Avoid setting max_uA in regulator constraints
      net: pse-pd: Add power limit check
      net: pse-pd: tps23881: Simplify function returns by removing redundant checks
      net: pse-pd: tps23881: Add missing configuration register after disable
      net: pse-pd: tps23881: Add support for power limit and measurement features
      net: pse-pd: Add support for PSE device index
      net: ethtool: Add support for new PSE device index description
      net: ethtool: Add support for ethnl_info_init_ntf helper function
      net: pse-pd: Add support for reporting events
      netlink: specs: Add support for PSE netlink notifications
      net: pse-pd: tps23881: Add support for PSE events and interrupts
      regulator: core: Resolve supply using of_node from regulator_config
      regulator: Add support for power budget description
      regulator: dt-bindings: Add regulator-power-budget property
      net: pse-pd: Fix missing PI of_node description
      net: pse-pd: Add support for PSE power domains
      net: ethtool: Add support for new power domains index description
      net: pse-pd: Add support for getting and setting port priority
      net: ethtool: Add PSE new port priority support feature
      netlink: specs: Expand the PSE netlink command with newly supported features
      net: pse-pd: pd692x0: Add support for PSE PI priority feature
      dt-bindings: net: pse-pd: microchip,pd692x0: Add manager regulator supply
      net: pse-pd: tps23881: Add support for static port priority feature
      dt-bindings: net: pse-pd: ti,tps23881: Add interrupt description

Kory Maincent (Dent Project) (1):
      net: pse-pd: tps23881: Use helpers to calculate bit offset for a channel

 .../bindings/net/pse-pd/microchip,pd692x0.yaml     |  12 +-
 .../bindings/net/pse-pd/ti,tps23881.yaml           |   6 +
 .../devicetree/bindings/regulator/regulator.yaml   |   3 +
 Documentation/netlink/specs/ethtool.yaml           |  59 ++
 Documentation/networking/ethtool-netlink.rst       |  85 +++
 drivers/net/mdio/fwnode_mdio.c                     |  26 +-
 drivers/net/pse-pd/pd692x0.c                       | 183 +++++
 drivers/net/pse-pd/pse_core.c                      | 798 +++++++++++++++++++-
 drivers/net/pse-pd/tps23881.c                      | 833 +++++++++++++++++++--
 drivers/regulator/core.c                           | 134 +++-
 drivers/regulator/of_regulator.c                   |   3 +
 include/linux/ethtool_netlink.h                    |   9 +
 include/linux/pse-pd/pse.h                         |  91 ++-
 include/linux/regulator/consumer.h                 |  21 +
 include/linux/regulator/driver.h                   |   2 +
 include/linux/regulator/machine.h                  |   2 +
 include/uapi/linux/ethtool.h                       |  84 +++
 include/uapi/linux/ethtool_netlink.h               |  18 +
 net/ethtool/netlink.c                              |   5 +
 net/ethtool/netlink.h                              |   2 +
 net/ethtool/pse-pd.c                               | 123 +++
 21 files changed, 2391 insertions(+), 108 deletions(-)
---
base-commit: 057623b3f6568e5f5c23ae26f6bf3eb367597e03
change-id: 20240913-feature_poe_port_prio-a51aed7332ec

Best regards,

Comments

Mark Brown Nov. 21, 2024, 4:22 p.m. UTC | #1 
On Thu, 21 Nov 2024 15:42:26 +0100, Kory Maincent wrote:
> This series brings support for port priority in the PSE subsystem.
> PSE controllers can set priorities to decide which ports should be
> turned off in case of special events like over-current.
> 
> I have added regulator maintainers to have their opinion on adding power
> budget regulator constraint see patches 16 and 17.
> There are also a few core regulator change along the way, patch 3 and 15.
> Not sure if they have to be sent with the Fixes tag.
> Also, I suppose I will need to merge them through the regulator tree.
> Will it be possible to create an immutable tag to have this PSE series
> based on them?
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[02/27] regulator: core: Ignore unset max_uA constraints in current limit check
        commit: 351f2bfe6362c663f45f5c6111f14365cfd094ab

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark