| Message ID | 20241121130134.29408-4-quic_jseerapu@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Block event interrupt support for I2C protocol | expand |
On Thu, Nov 21, 2024 at 06:31:34PM +0530, Jyothi Kumar Seerapu wrote: > I2C functionality has dependencies on the GPI driver. > Ensure that the GPI driver is enabled when using the I2C > driver functionality. > Therefore, update the I2C GENI driver to depend on the GPI driver. > > Signed-off-by: Jyothi Kumar Seerapu <quic_jseerapu@quicinc.com> > --- > v2 -> v3: > - Moved this change to patch3. > - Updated commit description. > > v1 -> v2: > - This patch is added in v2 to address the kernel test robot > reported compilation error. > ERROR: modpost: "gpi_multi_desc_process" [drivers/i2c/busses/i2c-qcom-geni.ko] undefined! > > drivers/i2c/busses/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig > index 0aa948014008..87634a682855 100644 > --- a/drivers/i2c/busses/Kconfig > +++ b/drivers/i2c/busses/Kconfig > @@ -1049,6 +1049,7 @@ config I2C_QCOM_GENI > tristate "Qualcomm Technologies Inc.'s GENI based I2C controller" > depends on ARCH_QCOM || COMPILE_TEST > depends on QCOM_GENI_SE > + depends on QCOM_GPI_DMA So... without this change the previous patch is broken, which is a no-go. And anyway, adding dependency onto a particular DMA driver is a bad idea. Please make use of the DMA API instead. > help > This driver supports GENI serial engine based I2C controller in > master mode on the Qualcomm Technologies Inc.'s SoCs. If you say > -- > 2.17.1 >
On 11/22/2024 3:40 AM, Dmitry Baryshkov wrote: > On Thu, Nov 21, 2024 at 06:31:34PM +0530, Jyothi Kumar Seerapu wrote: >> I2C functionality has dependencies on the GPI driver. >> Ensure that the GPI driver is enabled when using the I2C >> driver functionality. >> Therefore, update the I2C GENI driver to depend on the GPI driver. >> >> Signed-off-by: Jyothi Kumar Seerapu <quic_jseerapu@quicinc.com> >> --- >> v2 -> v3: >> - Moved this change to patch3. >> - Updated commit description. >> >> v1 -> v2: >> - This patch is added in v2 to address the kernel test robot >> reported compilation error. >> ERROR: modpost: "gpi_multi_desc_process" [drivers/i2c/busses/i2c-qcom-geni.ko] undefined! >> >> drivers/i2c/busses/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig >> index 0aa948014008..87634a682855 100644 >> --- a/drivers/i2c/busses/Kconfig >> +++ b/drivers/i2c/busses/Kconfig >> @@ -1049,6 +1049,7 @@ config I2C_QCOM_GENI >> tristate "Qualcomm Technologies Inc.'s GENI based I2C controller" >> depends on ARCH_QCOM || COMPILE_TEST >> depends on QCOM_GENI_SE >> + depends on QCOM_GPI_DMA > > So... without this change the previous patch is broken, which is a > no-go. And anyway, adding dependency onto a particular DMA driver is a > bad idea. Please make use of the DMA API instead. Sure, thanks for the details. In V4, will withdraw these changes. > >> help >> This driver supports GENI serial engine based I2C controller in >> master mode on the Qualcomm Technologies Inc.'s SoCs. If you say >> -- >> 2.17.1 >> >
diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig index 0aa948014008..87634a682855 100644 --- a/drivers/i2c/busses/Kconfig +++ b/drivers/i2c/busses/Kconfig @@ -1049,6 +1049,7 @@ config I2C_QCOM_GENI tristate "Qualcomm Technologies Inc.'s GENI based I2C controller" depends on ARCH_QCOM || COMPILE_TEST depends on QCOM_GENI_SE + depends on QCOM_GPI_DMA help This driver supports GENI serial engine based I2C controller in master mode on the Qualcomm Technologies Inc.'s SoCs. If you say
I2C functionality has dependencies on the GPI driver. Ensure that the GPI driver is enabled when using the I2C driver functionality. Therefore, update the I2C GENI driver to depend on the GPI driver. Signed-off-by: Jyothi Kumar Seerapu <quic_jseerapu@quicinc.com> --- v2 -> v3: - Moved this change to patch3. - Updated commit description. v1 -> v2: - This patch is added in v2 to address the kernel test robot reported compilation error. ERROR: modpost: "gpi_multi_desc_process" [drivers/i2c/busses/i2c-qcom-geni.ko] undefined! drivers/i2c/busses/Kconfig | 1 + 1 file changed, 1 insertion(+)