diff mbox series

[RFC,net-next,v3,17/27] regulator: dt-bindings: Add regulator-power-budget property

Message ID 20241121-feature_poe_port_prio-v3-17-83299fa6967c@bootlin.com (mailing list archive)
State RFC
Delegated to: Netdev Maintainers
Headers show
Series Add support for PSE port priority | expand

Checks

Context Check Description
netdev/series_format fail Series longer than 15 patches
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; GEN HAS DIFF 2 files changed, 161 insertions(+);
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 3 this patch: 3
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 3 maintainers not CCed: devicetree@vger.kernel.org krzk+dt@kernel.org conor+dt@kernel.org
netdev/build_clang success Errors and warnings before: 3 this patch: 3
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 3 this patch: 3
netdev/checkpatch warning CHECK: From:/Signed-off-by: email comments mismatch: 'From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>' != 'Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>'
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Kory Maincent Nov. 21, 2024, 2:42 p.m. UTC 
From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Introduce a new property to describe the power budget of the regulator.
This property will allow power management support for regulator consumers
like PSE controllers, enabling them to make decisions based on the
available power capacity.

Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---

Changes in v2:
- new patch.
---
 Documentation/devicetree/bindings/regulator/regulator.yaml | 3 +++
 1 file changed, 3 insertions(+)

Comments

Mark Brown Nov. 21, 2024, 2:58 p.m. UTC | #1 
On Thu, Nov 21, 2024 at 03:42:43PM +0100, Kory Maincent wrote:
>    regulator-input-current-limit-microamp:
>      description: maximum input current regulator allows
>  
> +  regulator-power-budget:
> +    description: power budget of the regulator in mW
> +

Properties are supposed to include the unit in the name.
Kory Maincent Nov. 21, 2024, 3:27 p.m. UTC | #2 
On Thu, 21 Nov 2024 14:58:06 +0000
Mark Brown <broonie@kernel.org> wrote:

> On Thu, Nov 21, 2024 at 03:42:43PM +0100, Kory Maincent wrote:
> >    regulator-input-current-limit-microamp:
> >      description: maximum input current regulator allows
> >  
> > +  regulator-power-budget:
> > +    description: power budget of the regulator in mW
> > +  
> 
> Properties are supposed to include the unit in the name.

Oh ok, thanks!
Krzysztof Kozlowski Nov. 22, 2024, 6:57 a.m. UTC | #3 
On 21/11/2024 15:42, Kory Maincent wrote:
> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> 
> Introduce a new property to describe the power budget of the regulator.
> This property will allow power management support for regulator consumers
> like PSE controllers, enabling them to make decisions based on the
> available power capacity.
> 
> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
> ---
> 
Considering:
1. This was not tested,
2. You did not Cc DT folks
so I assume you do not expect review as indicated by RFC. It is fine,
but if that was not the intention, please kindly first test the patch
and then use get_maintainers.pl or b4.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml b/Documentation/devicetree/bindings/regulator/regulator.yaml
index 1ef380d1515e..52a410b51769 100644
--- a/Documentation/devicetree/bindings/regulator/regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/regulator.yaml
@@ -34,6 +34,9 @@  properties:
   regulator-input-current-limit-microamp:
     description: maximum input current regulator allows
 
+  regulator-power-budget:
+    description: power budget of the regulator in mW
+
   regulator-always-on:
     description: boolean, regulator should never be disabled
     type: boolean