mbox series

[0/2] Misc OpenRISC fixes for 9.2.0

Message ID 20241123103828.3157128-1-shorne@gmail.com (mailing list archive)
Headers show
Series Misc OpenRISC fixes for 9.2.0 | expand

Message

Stafford Horne Nov. 23, 2024, 10:38 a.m. UTC
This series has 2 fixes for OpenRISC that came in over that past few months.

Ahmad Fatoum (1):
  hw/openrisc/openrisc_sim: keep serial@90000000 as default

Joel Holdsworth (1):
  hw/openrisc: Fixed undercounting of TTCR in continuous mode

 hw/openrisc/cputimer.c     | 26 +++++++++++++++-----------
 hw/openrisc/openrisc_sim.c | 13 ++++++++-----
 2 files changed, 23 insertions(+), 16 deletions(-)

Comments

Michael Tokarev Nov. 23, 2024, 12:12 p.m. UTC | #1
On 23.11.2024 13:38, Stafford Horne wrote:
> This series has 2 fixes for OpenRISC that came in over that past few months.
> 
> Ahmad Fatoum (1):
>    hw/openrisc/openrisc_sim: keep serial@90000000 as default
> 
> Joel Holdsworth (1):
>    hw/openrisc: Fixed undercounting of TTCR in continuous mode

Is there anything in there which is worth picking up for stable?
The first one above seems to be a good candidate.

Thanks,

/mjt
Stafford Horne Nov. 23, 2024, 5:01 p.m. UTC | #2
On Sat, Nov 23, 2024 at 03:12:12PM +0300, Michael Tokarev wrote:
> On 23.11.2024 13:38, Stafford Horne wrote:
> > This series has 2 fixes for OpenRISC that came in over that past few months.
> > 
> > Ahmad Fatoum (1):
> >    hw/openrisc/openrisc_sim: keep serial@90000000 as default
> > 
> > Joel Holdsworth (1):
> >    hw/openrisc: Fixed undercounting of TTCR in continuous mode
> 
> Is there anything in there which is worth picking up for stable?
> The first one above seems to be a good candidate.

Yes, I think so, would you like me to tag it with anything?  It does have a
Fixes.

-Stafford
Michael Tokarev Nov. 24, 2024, 5:03 a.m. UTC | #3
23.11.2024 20:01, Stafford Horne wrote:
> On Sat, Nov 23, 2024 at 03:12:12PM +0300, Michael Tokarev wrote:
>> On 23.11.2024 13:38, Stafford Horne wrote:
>>> This series has 2 fixes for OpenRISC that came in over that past few months.
>>>
>>> Ahmad Fatoum (1):
>>>     hw/openrisc/openrisc_sim: keep serial@90000000 as default
>>>
>>> Joel Holdsworth (1):
>>>     hw/openrisc: Fixed undercounting of TTCR in continuous mode
>>
>> Is there anything in there which is worth picking up for stable?
>> The first one above seems to be a good candidate.
> 
> Yes, I think so, would you like me to tag it with anything?  It does have a
> Fixes.

Well, there are Fixes and Fixes.  Some are much more important to be
in stable series, while others are hardly relevant.  Obviously you're
much better to judge in your area than others.  After all, maybe  you're
the only one in this world to run or1k, and you don't need stable
series at all :)

 From the two fixes in this series, I (with my very limited understanding)
see first one above is maybe good for stable, while for second I don't know.
So I entirely rely on your call, hence I asked.

As for tagging, you might add Cc: qemu-stable@ tag for all changes which
you  want to be back-ported, or just send a note to qemu-stabl@ with the
changes you'd like to be in stable (note: this email has Cc: there already).
The key point is to make qemu-stable@ aware of what do you think is relevant.

Thanks,

/mjt
Stafford Horne Nov. 24, 2024, 7:39 a.m. UTC | #4
On Sun, Nov 24, 2024 at 08:03:53AM +0300, Michael Tokarev wrote:
> 23.11.2024 20:01, Stafford Horne wrote:
> > On Sat, Nov 23, 2024 at 03:12:12PM +0300, Michael Tokarev wrote:
> > > On 23.11.2024 13:38, Stafford Horne wrote:
> > > > This series has 2 fixes for OpenRISC that came in over that past few months.
> > > > 
> > > > Ahmad Fatoum (1):
> > > >     hw/openrisc/openrisc_sim: keep serial@90000000 as default
> > > > 
> > > > Joel Holdsworth (1):
> > > >     hw/openrisc: Fixed undercounting of TTCR in continuous mode
> > > 
> > > Is there anything in there which is worth picking up for stable?
> > > The first one above seems to be a good candidate.
> > 
> > Yes, I think so, would you like me to tag it with anything?  It does have a
> > Fixes.
> 
> Well, there are Fixes and Fixes.  Some are much more important to be
> in stable series, while others are hardly relevant.  Obviously you're
> much better to judge in your area than others.  After all, maybe  you're
> the only one in this world to run or1k, and you don't need stable
> series at all :)

There are a few more people running or1k qemu for itegration testing of various
ports and every once in a while I get someone coming out of the woodwork using
or1k for real world stuff.

But sooner or later it may only be me.

:)

> From the two fixes in this series, I (with my very limited understanding)
> see first one above is maybe good for stable, while for second I don't know.
> So I entirely rely on your call, hence I asked.
> 
> As for tagging, you might add Cc: qemu-stable@ tag for all changes which
> you  want to be back-ported, or just send a note to qemu-stabl@ with the
> changes you'd like to be in stable (note: this email has Cc: there already).
> The key point is to make qemu-stable@ aware of what do you think is relevant.

Thanks for this.  I will add Cc: qemu-stable in the v2 of the series.

-Stafford