| Message ID | 20241124-asus_qcom_display-v3-1-002b723b1920@hotmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Asus vivobook s15 improvements | expand |
On Sun, Nov 24, 2024 at 11:00:57AM +0100, Maud Spierings wrote: > The Samsung ATNA56AC03 panel is an AMOLED eDP panel. > It is similar to the ATNA33xc20 except it is larger and has a different > resolution. > > Signed-off-by: Maud Spierings <maud_spierings@hotmail.com> > --- <form letter> This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. </form letter> Best regards, Krzysztof
On 11/24/24 12:00 PM, Krzysztof Kozlowski wrote: > On Sun, Nov 24, 2024 at 11:00:57AM +0100, Maud Spierings wrote: >> The Samsung ATNA56AC03 panel is an AMOLED eDP panel. >> It is similar to the ATNA33xc20 except it is larger and has a different >> resolution. >> >> Signed-off-by: Maud Spierings <maud_spierings@hotmail.com> >> --- > <form letter> > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: Please add > Acked-by/Reviewed-by/Tested-by tags when posting new versions, under > or above your Signed-off-by tag. Tag is "received", when provided > in a message replied to you on the mailing list. Tools like b4 can help > here. However, there's no need to repost patches *only* to add the tags. > The upstream maintainer will do that for tags received on the version > they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. > </form letter> > > Best regards, > Krzysztof > I did indeed completely miss it, only focussed on the correction, Should I make a new version? Also this is my first time replying on the list so I hope this goes well. When I add one of these tags it should be in the commit message of that patch below three dashes? Best regards, Maud
On 24/11/2024 13:29, Maud Spierings wrote: >> If a tag was not added on purpose, please state why and what changed. >> </form letter> >> >> Best regards, >> Krzysztof >> > I did indeed completely miss it, only focussed on the correction, Should > I make a new version? > Also this is my first time replying on the list so I hope this goes well. > > When I add one of these tags it should be in the commit message of that > patch below three dashes? b4 trailers -u Best regards, Krzysztof
On 24/11/2024 11:00, Maud Spierings via B4 Relay wrote: > From: Maud Spierings <maud_spierings@hotmail.com> > > The Samsung ATNA56AC03 panel is an AMOLED eDP panel. > It is similar to the ATNA33xc20 except it is larger and has a different > resolution. > > Signed-off-by: Maud Spierings <maud_spierings@hotmail.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi, On Sun, Nov 24, 2024 at 2:01 AM Maud Spierings via B4 Relay <devnull+maud_spierings.hotmail.com@kernel.org> wrote: > > From: Maud Spierings <maud_spierings@hotmail.com> > > The Samsung ATNA56AC03 panel is an AMOLED eDP panel. > It is similar to the ATNA33xc20 except it is larger and has a different > resolution. > > Signed-off-by: Maud Spierings <maud_spierings@hotmail.com> > --- > Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml | 2 ++ > 1 file changed, 2 insertions(+) Pushed just this patch to drm-misc-next: [1/4] dt-bindings: display: panel: samsung,atna56ac03: Document ATNA56AC03 commit: b1fe820d03e2e1b89315faf99f1065bdb4146a8f -Doug
diff --git a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml index 032f783eefc4508df35da10e53ca20ff8b1b9bdf..684c2896d2387077cf2d91cc5a025e0838c0f536 100644 --- a/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml +++ b/Documentation/devicetree/bindings/display/panel/samsung,atna33xc20.yaml @@ -23,6 +23,8 @@ properties: - samsung,atna45af01 # Samsung 14.5" 3K (2944x1840 pixels) eDP AMOLED panel - samsung,atna45dc02 + # Samsung 15.6" 3K (2880x1620 pixels) eDP AMOLED panel + - samsung,atna56ac03 - const: samsung,atna33xc20 enable-gpios: true