| Message ID | 20241125082130.2390310-2-wmacek@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Starmie Chromebook | expand |
Il 25/11/24 09:21, Wojciech Macek ha scritto: > Add an entry for the MT8186 based Starmie Chromebooks, also known as the > ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is > a tablet style chromebook. > > Signed-off-by: Wojciech Macek <wmacek@chromium.org> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Mon, Nov 25, 2024 at 08:21:28AM +0000, Wojciech Macek wrote: > Add an entry for the MT8186 based Starmie Chromebooks, also known as the > ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is > a tablet style chromebook. > > Signed-off-by: Wojciech Macek <wmacek@chromium.org> > --- > > Changelog v2-v1: > - Fixed items/const bidings description in mediatek.yaml > > Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > index 1d4bb50fcd8d9..6191a5320c148 100644 > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > @@ -263,6 +263,19 @@ properties: > - const: google,steelix-sku196608 > - const: google,steelix > - const: mediatek,mt8186 > + - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001)) > + items: > + - const: google,starmie-sku0 > + - const: google,starmie-sku2 > + - const: google,starmie-sku3 Compatible order here is back to making little sense. Why is the oldest SKU, in both cases, appearing first? > + - const: google,starmie > + - const: mediatek,mt8186 > + - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001)) > + items: > + - const: google,starmie-sku1 > + - const: google,starmie-sku4 > + - const: google,starmie > + - const: mediatek,mt8186 > - description: Google Steelix (Lenovo 300e Yoga Chromebook Gen 4) > items: > - enum: > -- > 2.47.0.371.ga323438b13-goog >
On Tue, Nov 26, 2024 at 2:34 AM Conor Dooley <conor@kernel.org> wrote: > > On Mon, Nov 25, 2024 at 08:21:28AM +0000, Wojciech Macek wrote: > > Add an entry for the MT8186 based Starmie Chromebooks, also known as the > > ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is > > a tablet style chromebook. > > > > Signed-off-by: Wojciech Macek <wmacek@chromium.org> > > --- > > > > Changelog v2-v1: > > - Fixed items/const bidings description in mediatek.yaml > > > > Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > index 1d4bb50fcd8d9..6191a5320c148 100644 > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > @@ -263,6 +263,19 @@ properties: > > - const: google,steelix-sku196608 > > - const: google,steelix > > - const: mediatek,mt8186 > > + - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001)) > > + items: > > + - const: google,starmie-sku0 > > + - const: google,starmie-sku2 > > + - const: google,starmie-sku3 > > Compatible order here is back to making little sense. Why is the oldest > SKU, in both cases, appearing first? FWIW the SKU number has no particular ordering. They were released together. SKU denotes different configurations (memory, storage, touchscreen and other component options). OOTH revisions would actually have chronological meaning. ChenYu > > + - const: google,starmie > > + - const: mediatek,mt8186 > > + - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001)) > > + items: > > + - const: google,starmie-sku1 > > + - const: google,starmie-sku4 > > + - const: google,starmie > > + - const: mediatek,mt8186 > > - description: Google Steelix (Lenovo 300e Yoga Chromebook Gen 4) > > items: > > - enum: > > -- > > 2.47.0.371.ga323438b13-goog > >
On Tue, Nov 26, 2024 at 12:36:08PM +0800, Chen-Yu Tsai wrote: > On Tue, Nov 26, 2024 at 2:34 AM Conor Dooley <conor@kernel.org> wrote: > > > > On Mon, Nov 25, 2024 at 08:21:28AM +0000, Wojciech Macek wrote: > > > Add an entry for the MT8186 based Starmie Chromebooks, also known as the > > > ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is > > > a tablet style chromebook. > > > > > > Signed-off-by: Wojciech Macek <wmacek@chromium.org> > > > --- > > > > > > Changelog v2-v1: > > > - Fixed items/const bidings description in mediatek.yaml > > > > > > Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml > > > index 1d4bb50fcd8d9..6191a5320c148 100644 > > > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml > > > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml > > > @@ -263,6 +263,19 @@ properties: > > > - const: google,steelix-sku196608 > > > - const: google,steelix > > > - const: mediatek,mt8186 > > > + - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001)) > > > + items: > > > + - const: google,starmie-sku0 > > > + - const: google,starmie-sku2 > > > + - const: google,starmie-sku3 > > > > Compatible order here is back to making little sense. Why is the oldest > > SKU, in both cases, appearing first? > > FWIW the SKU number has no particular ordering. They were released together. > SKU denotes different configurations (memory, storage, touchscreen and other > component options). OOTH revisions would actually have chronological meaning. I see, that's fine then I suppose. Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml index 1d4bb50fcd8d9..6191a5320c148 100644 --- a/Documentation/devicetree/bindings/arm/mediatek.yaml +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml @@ -263,6 +263,19 @@ properties: - const: google,steelix-sku196608 - const: google,steelix - const: mediatek,mt8186 + - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001)) + items: + - const: google,starmie-sku0 + - const: google,starmie-sku2 + - const: google,starmie-sku3 + - const: google,starmie + - const: mediatek,mt8186 + - description: Google Starmie (ASUS Chromebook Enterprise CM30 (CM3001)) + items: + - const: google,starmie-sku1 + - const: google,starmie-sku4 + - const: google,starmie + - const: mediatek,mt8186 - description: Google Steelix (Lenovo 300e Yoga Chromebook Gen 4) items: - enum:
Add an entry for the MT8186 based Starmie Chromebooks, also known as the ASUS Chromebook Enterprise CM30 Detachable (CM3001). The device is a tablet style chromebook. Signed-off-by: Wojciech Macek <wmacek@chromium.org> --- Changelog v2-v1: - Fixed items/const bidings description in mediatek.yaml Documentation/devicetree/bindings/arm/mediatek.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)