mbox series

[0/2] refs: stylistic improvements to ref migration optimization

Message ID 20241125-pks-refs-migration-optimization-followup-v1-0-0e1b4a2af384@pks.im (mailing list archive)
Headers show
Series refs: stylistic improvements to ref migration optimization | expand

Message

Patrick Steinhardt Nov. 25, 2024, 7:34 a.m. UTC
Hi,

this small patch series addresses some stylistic nits surfaced in the
review of ps/ref-backend-migration-optim. v3 of that series and the
merge to `next` have crossed, so I'm resending the changes from v3 on
top of what we have in `next`.

This version is built on top of 6ea2d9d271 (Sync with Git 2.47.1,
2024-11-25) with ps/ref-backend-migration-optim at d94ac23d3b
(reftable/block: optimize allocations by using scratch buffer,
2024-11-20) merged into it.

Thanks!

Patrick

---
Patrick Steinhardt (2):
      refs: adapt `initial_transaction` flag to be unsigned
      reftable: rename scratch buffer

 refs.c            |  2 +-
 refs.h            |  2 +-
 reftable/block.c  | 10 +++++-----
 reftable/block.h  |  3 ++-
 reftable/writer.c | 22 +++++++++++-----------
 reftable/writer.h |  3 ++-
 6 files changed, 22 insertions(+), 20 deletions(-)


---
base-commit: a468246cedfb3b54b03609be75d9e13f0be1cc29
change-id: 20241125-pks-refs-migration-optimization-followup-d766e86b8925

Comments

Christian Couder Nov. 25, 2024, 9:35 a.m. UTC | #1
Hi,

On Mon, Nov 25, 2024 at 8:35 AM Patrick Steinhardt <ps@pks.im> wrote:
>
> Hi,
>
> this small patch series addresses some stylistic nits surfaced in the
> review of ps/ref-backend-migration-optim. v3 of that series and the
> merge to `next` have crossed, so I'm resending the changes from v3 on
> top of what we have in `next`.

I took a look and both patches in this series look good and correct to me. Ack!
Junio C Hamano Nov. 25, 2024, 11:39 p.m. UTC | #2
Christian Couder <christian.couder@gmail.com> writes:

> On Mon, Nov 25, 2024 at 8:35 AM Patrick Steinhardt <ps@pks.im> wrote:
>>
>> Hi,
>>
>> this small patch series addresses some stylistic nits surfaced in the
>> review of ps/ref-backend-migration-optim. v3 of that series and the
>> merge to `next` have crossed, so I'm resending the changes from v3 on
>> top of what we have in `next`.
>
> I took a look and both patches in this series look good and correct to me. Ack!

Looking good.  Thanks, both of you.