| Message ID | 20241125093316.2357162-16-victor.liu@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Add Freescale i.MX8qxp Display Controller support | expand |
On Mon, Nov 25, 2024 at 05:33:12PM +0800, Liu Ying wrote: > Document SCU controlled display pixel link child nodes. > > Signed-off-by: Liu Ying <victor.liu@nxp.com> > --- > v4: > * No change. > > v3: > * No change. > > v2: > * New patch as needed by display controller subsystem device tree. DO NOT MERGE means also do not review? Your cover letter does not explain what you want here, except not merging. Why posting things which should not be merged, without context? I'll ignore this patch for now. Best regards, Krzysztof
On 11/26/2024, Krzysztof Kozlowski wrote: > On Mon, Nov 25, 2024 at 05:33:12PM +0800, Liu Ying wrote: >> Document SCU controlled display pixel link child nodes. >> >> Signed-off-by: Liu Ying <victor.liu@nxp.com> >> --- >> v4: >> * No change. >> >> v3: >> * No change. >> >> v2: >> * New patch as needed by display controller subsystem device tree. > > DO NOT MERGE means also do not review? According to Rob's comment on v2, DO NOT MERGE means no need to review. https://www.spinics.net/lists/devicetree/msg720125.html > > Your cover letter does not explain what you want here, except not > merging. Why posting things which should not be merged, without context? The patches with "DO NOT MERGE" prefix facilitate testing a LVDS panel on i.MX8qxp MEK as requested by Francesco. Francesco suggested the prefix. https://lkml.org/lkml/2024/7/5/709 The cover letter mentions that the patch series facilitates the test. But, I'll clarify things better in cover letter in next version if needed. > > I'll ignore this patch for now. > > Best regards, > Krzysztof >
On 26/11/2024 08:33, Liu Ying wrote: > On 11/26/2024, Krzysztof Kozlowski wrote: >> On Mon, Nov 25, 2024 at 05:33:12PM +0800, Liu Ying wrote: >>> Document SCU controlled display pixel link child nodes. >>> >>> Signed-off-by: Liu Ying <victor.liu@nxp.com> >>> --- >>> v4: >>> * No change. >>> >>> v3: >>> * No change. >>> >>> v2: >>> * New patch as needed by display controller subsystem device tree. >> >> DO NOT MERGE means also do not review? > > According to Rob's comment on v2, DO NOT MERGE means no need to review. > > https://www.spinics.net/lists/devicetree/msg720125.html I am not Rob. 10 other maintainers here also carry different name. You have cover letter to explain why marking patches like this and what you expect. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml index 557e524786c2..1a920f013ad2 100644 --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml @@ -30,6 +30,26 @@ properties: Clock controller node that provides the clocks controlled by the SCU $ref: /schemas/clock/fsl,scu-clk.yaml + dc0-pixel-link0: + description: + Display pixel link0 in display controller subsystem0 controlled by the SCU + $ref: /schemas/display/bridge/fsl,imx8qxp-pixel-link.yaml + + dc0-pixel-link1: + description: + Display pixel link1 in display controller subsystem0 controlled by the SCU + $ref: /schemas/display/bridge/fsl,imx8qxp-pixel-link.yaml + + dc1-pixel-link0: + description: + Display pixel link0 in display controller subsystem1 controlled by the SCU + $ref: /schemas/display/bridge/fsl,imx8qxp-pixel-link.yaml + + dc1-pixel-link1: + description: + Display pixel link1 in display controller subsystem1 controlled by the SCU + $ref: /schemas/display/bridge/fsl,imx8qxp-pixel-link.yaml + gpio: description: Control the GPIO PINs on SCU domain over the firmware APIs
Document SCU controlled display pixel link child nodes. Signed-off-by: Liu Ying <victor.liu@nxp.com> --- v4: * No change. v3: * No change. v2: * New patch as needed by display controller subsystem device tree. .../devicetree/bindings/firmware/fsl,scu.yaml | 20 +++++++++++++++++++ 1 file changed, 20 insertions(+)