diff mbox series

[v1,1/3] arm64: dts: qcom: sa8775p-ride: Change the BT node

Message ID 20241128120922.3518582-2-quic_chejiang@quicinc.com (mailing list archive)
State New
Headers show
Series bluetooth: qca: Add QCA6698 Bluetooth chip | expand

Checks

Context Check Description
tedd_an/pre-ci_am fail error: patch failed: arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi:856 error: arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi: patch does not apply hint: Use 'git am --show-current-patch' to see the failed patch

Commit Message

Cheng Jiang Nov. 28, 2024, 12:09 p.m. UTC
The SA8775P-Ride uses the QCA6698 chipset, which shares the same IP core
as the WCN6855. However, it has different RF components and RAM sizes,
so new firmware is needed.  This change allows driver to distinguish it
from the WCN6855 and load the specific firmware.

Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

bluez.test.bot@gmail.com Nov. 28, 2024, 12:28 p.m. UTC | #1
This is an automated email and please do not reply to this email.

Dear Submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While preparing the CI tests, the patches you submitted couldn't be applied to the current HEAD of the repository.

----- Output -----

error: patch failed: arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi:856
error: arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi: patch does not apply
hint: Use 'git am --show-current-patch' to see the failed patch

Please resolve the issue and submit the patches again.


---
Regards,
Linux Bluetooth
Krzysztof Kozlowski Nov. 28, 2024, 2:39 p.m. UTC | #2
On 28/11/2024 13:09, Cheng Jiang wrote:
> The SA8775P-Ride uses the QCA6698 chipset, which shares the same IP core
> as the WCN6855. However, it has different RF components and RAM sizes,
> so new firmware is needed.  This change allows driver to distinguish it
> from the WCN6855 and load the specific firmware.
> 
> Signed-off-by: Cheng Jiang <quic_chejiang@quicinc.com>
> ---
>  arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> index 3fc62e123..f95e709bd 100644
> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
> @@ -856,7 +856,7 @@ &uart17 {
>  	status = "okay";
>  
>  	bluetooth {
> -		compatible = "qcom,wcn6855-bt";
> +		compatible = "qcom,qca6698-bt";

This breaks users without mentioning it, without really justifying the
impact. Also it is not clear for me whether devices are or are not
compatible.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
index 3fc62e123..f95e709bd 100644
--- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi
@@ -856,7 +856,7 @@  &uart17 {
 	status = "okay";
 
 	bluetooth {
-		compatible = "qcom,wcn6855-bt";
+		compatible = "qcom,qca6698-bt";
 
 		vddrfacmn-supply = <&vreg_pmu_rfa_cmn>;
 		vddaon-supply = <&vreg_pmu_aon_0p59>;