| Message ID | 20241128152338.4583-2-hdegoede@redhat.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | media: ov2740: Various improvements | expand |
On Thu, Nov 28, 2024 at 4:23 PM Hans de Goede <hdegoede@redhat.com> wrote: > > Calling the identify function may get delayed till the first stream-on, > add a dev_dbg() to it so that we know when it has run. This is useful > to debug bring-up problems related to regulators / clks / GPIOs. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed by: Ricardo Ribalda <ribalda@chromium.org> > --- > drivers/media/i2c/ov2740.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c > index 387c529d9736..e7a611967b40 100644 > --- a/drivers/media/i2c/ov2740.c > +++ b/drivers/media/i2c/ov2740.c > @@ -644,6 +644,8 @@ static int ov2740_identify_module(struct ov2740 *ov2740) > return -ENXIO; > } > > + dev_dbg(&client->dev, "chip id: %x\n", val); > + nit: I would have written 0x%x instead, but the previous lines there is %x != %x.. So up to you :) > ov2740->identified = true; > > return 0; > -- > 2.47.0 > >
On Thu, Nov 28, 2024 at 5:38 PM Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> wrote: > > On Thu, Nov 28, 2024 at 4:23 PM Hans de Goede <hdegoede@redhat.com> wrote: > > > > Calling the identify function may get delayed till the first stream-on, > > add a dev_dbg() to it so that we know when it has run. This is useful > > to debug bring-up problems related to regulators / clks / GPIOs. > > > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> > Reviewed by: Ricardo Ribalda <ribalda@chromium.org> Reviewed-by: Ricardo Ribalda <ribalda@chromium.org> > > --- > > drivers/media/i2c/ov2740.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c > > index 387c529d9736..e7a611967b40 100644 > > --- a/drivers/media/i2c/ov2740.c > > +++ b/drivers/media/i2c/ov2740.c > > @@ -644,6 +644,8 @@ static int ov2740_identify_module(struct ov2740 *ov2740) > > return -ENXIO; > > } > > > > + dev_dbg(&client->dev, "chip id: %x\n", val); > > + > nit: I would have written 0x%x instead, but the previous lines there > is %x != %x.. > So up to you :) > > > ov2740->identified = true; > > > > return 0; > > -- > > 2.47.0 > > > > > > > -- > Ricardo Ribalda
On Thu, Nov 28, 2024 at 04:23:35PM +0100, Hans de Goede wrote: > Calling the identify function may get delayed till the first stream-on, > add a dev_dbg() to it so that we know when it has run. This is useful > to debug bring-up problems related to regulators / clks / GPIOs. > > Signed-off-by: Hans de Goede <hdegoede@redhat.com> Tested-by: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com> > --- > drivers/media/i2c/ov2740.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c > index 387c529d9736..e7a611967b40 100644 > --- a/drivers/media/i2c/ov2740.c > +++ b/drivers/media/i2c/ov2740.c > @@ -644,6 +644,8 @@ static int ov2740_identify_module(struct ov2740 *ov2740) > return -ENXIO; > } > > + dev_dbg(&client->dev, "chip id: %x\n", val); > + > ov2740->identified = true; > > return 0; > -- > 2.47.0 > >
diff --git a/drivers/media/i2c/ov2740.c b/drivers/media/i2c/ov2740.c index 387c529d9736..e7a611967b40 100644 --- a/drivers/media/i2c/ov2740.c +++ b/drivers/media/i2c/ov2740.c @@ -644,6 +644,8 @@ static int ov2740_identify_module(struct ov2740 *ov2740) return -ENXIO; } + dev_dbg(&client->dev, "chip id: %x\n", val); + ov2740->identified = true; return 0;
Calling the identify function may get delayed till the first stream-on, add a dev_dbg() to it so that we know when it has run. This is useful to debug bring-up problems related to regulators / clks / GPIOs. Signed-off-by: Hans de Goede <hdegoede@redhat.com> --- drivers/media/i2c/ov2740.c | 2 ++ 1 file changed, 2 insertions(+)