mbox series

[v2,0/6] drm/i915/display: power conversion to struct intel_display

Message ID cover.1732808222.git.jani.nikula@intel.com (mailing list archive)
Headers show
Series drm/i915/display: power conversion to struct intel_display | expand

Message

Jani Nikula Nov. 28, 2024, 3:38 p.m. UTC
This is v2 of [1] with patch 1 dropped, and some minor checkpatch issues
fixed.

[1] https://lore.kernel.org/r/cover.1732727056.git.jani.nikula@intel.com

Jani Nikula (6):
  drm/i915/display: convert for_each_power_well() to struct
    intel_display
  drm/i915/display: convert for_each_power_domain_well() to struct
    intel_display
  drm/i915/display: convert power wells to struct intel_display
  drm/i915/display: convert power domain code internally to struct
    intel_display
  drm/i915/display: convert high level power interfaces to struct
    intel_display
  drm/i915/display: convert power map to struct intel_display

 .../drm/i915/display/intel_display_debugfs.c  |   3 +-
 .../drm/i915/display/intel_display_driver.c   |   8 +-
 .../gpu/drm/i915/display/intel_display_irq.c  |   3 +-
 .../drm/i915/display/intel_display_power.c    | 948 +++++++++---------
 .../drm/i915/display/intel_display_power.h    |  31 +-
 .../i915/display/intel_display_power_map.c    |  56 +-
 .../i915/display/intel_display_power_well.c   | 548 +++++-----
 .../i915/display/intel_display_power_well.h   |  35 +-
 drivers/gpu/drm/i915/display/intel_dpio_phy.c |   7 +-
 drivers/gpu/drm/i915/display/intel_hdcp.c     |   2 +-
 .../drm/i915/display/intel_modeset_setup.c    |   2 +-
 drivers/gpu/drm/i915/display/intel_pps.c      |   4 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |   6 +-
 drivers/gpu/drm/i915/i915_driver.c            |  32 +-
 drivers/gpu/drm/xe/display/xe_display.c       |  28 +-
 15 files changed, 870 insertions(+), 843 deletions(-)

Comments

Jani Nikula Nov. 29, 2024, 8:19 a.m. UTC | #1
On Thu, 28 Nov 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/display: power conversion to struct intel_display (rev2)
> URL   : https://patchwork.freedesktop.org/series/141846/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_15759 -> Patchwork_141846v2
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_141846v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_141846v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/index.html
>
> Participating hosts (45 -> 44)
> ------------------------------
>
>   Missing    (1): fi-snb-2520m 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_141846v2:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1:
>     - fi-cfl-8109u:       [PASS][1] -> [DMESG-WARN][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/fi-cfl-8109u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/fi-cfl-8109u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1.html

Unrelated, please re-report.

BR,
Jani.


>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_141846v2 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-arlh-3:         [PASS][3] -> [ABORT][4] ([i915#12061]) +1 other test abort
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-arlh-3/igt@i915_selftest@live@workarounds.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-arlh-3/igt@i915_selftest@live@workarounds.html
>     - bat-mtlp-6:         [PASS][5] -> [ABORT][6] ([i915#12061]) +1 other test abort
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>
>   * igt@kms_flip@basic-flip-vs-modeset@b-dp1:
>     - bat-apl-1:          [PASS][7] -> [DMESG-WARN][8] ([i915#12918]) +1 other test dmesg-warn
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-apl-1/igt@kms_flip@basic-flip-vs-modeset@b-dp1.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-apl-1/igt@kms_flip@basic-flip-vs-modeset@b-dp1.html
>
>   * igt@kms_pipe_crc_basic@hang-read-crc:
>     - fi-cfl-8109u:       [PASS][9] -> [DMESG-WARN][10] ([i915#12914]) +1 other test dmesg-warn
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/fi-cfl-8109u/igt@kms_pipe_crc_basic@hang-read-crc.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/fi-cfl-8109u/igt@kms_pipe_crc_basic@hang-read-crc.html
>
>   
> #### Possible fixes ####
>
>   * igt@i915_selftest@live@gt_pm:
>     - bat-twl-2:          [ABORT][11] ([i915#12919]) -> [PASS][12] +1 other test pass
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-twl-2/igt@i915_selftest@live@gt_pm.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-twl-2/igt@i915_selftest@live@gt_pm.html
>
>   * igt@i915_selftest@live@workarounds:
>     - {bat-arls-6}:       [ABORT][13] ([i915#12061]) -> [PASS][14] +1 other test pass
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-arls-6/igt@i915_selftest@live@workarounds.html
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-arls-6/igt@i915_selftest@live@workarounds.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
>   [i915#12914]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12914
>   [i915#12918]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12918
>   [i915#12919]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_15759 -> Patchwork_141846v2
>
>   CI-20190529: 20190529
>   CI_DRM_15759: 5379d0a88558b73308ad82f163e80b863626e90b @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8129: 363499a879fee5b9b7eda8acf7c772bce3423493 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_141846v2: 5379d0a88558b73308ad82f163e80b863626e90b @ git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/index.html
Imre Deak Nov. 29, 2024, 2:18 p.m. UTC | #2
On Thu, Nov 28, 2024 at 05:38:18PM +0200, Jani Nikula wrote:
> This is v2 of [1] with patch 1 dropped, and some minor checkpatch issues
> fixed.
> 
> [1] https://lore.kernel.org/r/cover.1732727056.git.jani.nikula@intel.com

The patchset looks ok:
Reviewed-by: Imre Deak <imre.deak@intel.com>

> 
> Jani Nikula (6):
>   drm/i915/display: convert for_each_power_well() to struct
>     intel_display
>   drm/i915/display: convert for_each_power_domain_well() to struct
>     intel_display
>   drm/i915/display: convert power wells to struct intel_display
>   drm/i915/display: convert power domain code internally to struct
>     intel_display
>   drm/i915/display: convert high level power interfaces to struct
>     intel_display
>   drm/i915/display: convert power map to struct intel_display
> 
>  .../drm/i915/display/intel_display_debugfs.c  |   3 +-
>  .../drm/i915/display/intel_display_driver.c   |   8 +-
>  .../gpu/drm/i915/display/intel_display_irq.c  |   3 +-
>  .../drm/i915/display/intel_display_power.c    | 948 +++++++++---------
>  .../drm/i915/display/intel_display_power.h    |  31 +-
>  .../i915/display/intel_display_power_map.c    |  56 +-
>  .../i915/display/intel_display_power_well.c   | 548 +++++-----
>  .../i915/display/intel_display_power_well.h   |  35 +-
>  drivers/gpu/drm/i915/display/intel_dpio_phy.c |   7 +-
>  drivers/gpu/drm/i915/display/intel_hdcp.c     |   2 +-
>  .../drm/i915/display/intel_modeset_setup.c    |   2 +-
>  drivers/gpu/drm/i915/display/intel_pps.c      |   4 +-
>  drivers/gpu/drm/i915/display/intel_psr.c      |   6 +-
>  drivers/gpu/drm/i915/i915_driver.c            |  32 +-
>  drivers/gpu/drm/xe/display/xe_display.c       |  28 +-
>  15 files changed, 870 insertions(+), 843 deletions(-)
> 
> -- 
> 2.39.5
>
Illipilli, TejasreeX Nov. 29, 2024, 4:08 p.m. UTC | #3
Hi,

https://patchwork.freedesktop.org/series/141846/ - Re-reported.

Thanks,
Tejasree


-----Original Message-----
From: I915-ci-infra <i915-ci-infra-bounces@lists.freedesktop.org> On Behalf Of Jani Nikula
Sent: Friday, November 29, 2024 1:50 PM
To: I915-ci-infra@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: ✗ i915.CI.BAT: failure for drm/i915/display: power conversion to struct intel_display (rev2)

On Thu, 28 Nov 2024, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/display: power conversion to struct intel_display (rev2)
> URL   : https://patchwork.freedesktop.org/series/141846/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_15759 -> Patchwork_141846v2 
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_141846v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_141846v2, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
>
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/index.html
>
> Participating hosts (45 -> 44)
> ------------------------------
>
>   Missing    (1): fi-snb-2520m 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_141846v2:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1:
>     - fi-cfl-8109u:       [PASS][1] -> [DMESG-WARN][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/fi-cfl-8109u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/fi-cfl-810
> 9u/igt@kms_pipe_crc_basic@hang-read-crc@pipe-a-dp-1.html

Unrelated, please re-report.

BR,
Jani.


>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_141846v2 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@i915_selftest@live@workarounds:
>     - bat-arlh-3:         [PASS][3] -> [ABORT][4] ([i915#12061]) +1 other test abort
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-arlh-3/igt@i915_selftest@live@workarounds.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-arlh-3/igt@i915_selftest@live@workarounds.html
>     - bat-mtlp-6:         [PASS][5] -> [ABORT][6] ([i915#12061]) +1 other test abort
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-mtlp-6/igt@i915_selftest@live@workarounds.html
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-mtlp-6
> /igt@i915_selftest@live@workarounds.html
>
>   * igt@kms_flip@basic-flip-vs-modeset@b-dp1:
>     - bat-apl-1:          [PASS][7] -> [DMESG-WARN][8] ([i915#12918]) +1 other test dmesg-warn
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-apl-1/igt@kms_flip@basic-flip-vs-modeset@b-dp1.html
>    [8]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-apl-1/
> igt@kms_flip@basic-flip-vs-modeset@b-dp1.html
>
>   * igt@kms_pipe_crc_basic@hang-read-crc:
>     - fi-cfl-8109u:       [PASS][9] -> [DMESG-WARN][10] ([i915#12914]) +1 other test dmesg-warn
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/fi-cfl-8109u/igt@kms_pipe_crc_basic@hang-read-crc.html
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/fi-cfl-810
> 9u/igt@kms_pipe_crc_basic@hang-read-crc.html
>
>   
> #### Possible fixes ####
>
>   * igt@i915_selftest@live@gt_pm:
>     - bat-twl-2:          [ABORT][11] ([i915#12919]) -> [PASS][12] +1 other test pass
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-twl-2/igt@i915_selftest@live@gt_pm.html
>    [12]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-twl-2/
> igt@i915_selftest@live@gt_pm.html
>
>   * igt@i915_selftest@live@workarounds:
>     - {bat-arls-6}:       [ABORT][13] ([i915#12061]) -> [PASS][14] +1 other test pass
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15759/bat-arls-6/igt@i915_selftest@live@workarounds.html
>    [14]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/bat-arls-6
> /igt@i915_selftest@live@workarounds.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
>   [i915#12914]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12914
>   [i915#12918]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12918
>   [i915#12919]: 
> https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_15759 -> Patchwork_141846v2
>
>   CI-20190529: 20190529
>   CI_DRM_15759: 5379d0a88558b73308ad82f163e80b863626e90b @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8129: 363499a879fee5b9b7eda8acf7c772bce3423493 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_141846v2: 5379d0a88558b73308ad82f163e80b863626e90b @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
> == Logs ==
>
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_141846v2/index.html

--
Jani Nikula, Intel