| Message ID | 20241202-b4-gs101_max77759_fg-v1-4-98d2fa7bfe30@uclouvain.be (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Google Pixel 6 (oriole): max77759 fuel gauge enablement and driver support | expand |
On 02/12/2024 14:07, Thomas Antoine via B4 Relay wrote: > From: Thomas Antoine <t.antoine@uclouvain.be> > > Add the node for the max77759 fuel gauge as a slave of the i2c. > > The fuel gauge has been tested and seems to give coherent results. > Manual activation of the charger via i2cset shows that the sign of > the current does indicate charging/discharging status. > > Signed-off-by: Thomas Antoine <t.antoine@uclouvain.be> > --- > arch/arm64/boot/dts/exynos/google/gs101-oriole.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > index 387fb779bd29ea3812331a7951f03b181c5fe659..4c45dd6fd0173889234b7b04d7abb4b382c7706c 100644 > --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts > @@ -90,6 +90,13 @@ eeprom: eeprom@50 { > &hsi2c_12 { > status = "okay"; > /* TODO: add the devices once drivers exist */ Is this still applicable? > + > + fuel-gauge@36 { > + compatible = "maxim,max77759-fg"; > + reg = <0x36>; > + reg-names = "m5"; No interrupts? > + }; > + Do not add stray blank lines. Best regards, Krzysztof
On 12/2/24 14:41, Krzysztof Kozlowski wrote: > On 02/12/2024 14:07, Thomas Antoine via B4 Relay wrote: >> From: Thomas Antoine <t.antoine@uclouvain.be> >> &hsi2c_12 { >> status = "okay"; >> /* TODO: add the devices once drivers exist */ > > > Is this still applicable? Yes, there are other devices on the bus (the Maxim max77759 pmic, charger and TPCI, the Maxim max20339 OVP and the NXP PCA9468). >> + >> + fuel-gauge@36 { >> + compatible = "maxim,max77759-fg"; >> + reg = <0x36>; >> + reg-names = "m5"; > > > No interrupts? There are interrupts in the stock devicetree but they didn't compile out of the box when adding them to the node without any other modification and I didn't try further given the device worked without them. I can try to get them to work for v2. >> + }; >> + > > > Do not add stray blank lines. Will remove in v2. Best regards, Thomas Antoine
diff --git a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts index 387fb779bd29ea3812331a7951f03b181c5fe659..4c45dd6fd0173889234b7b04d7abb4b382c7706c 100644 --- a/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts +++ b/arch/arm64/boot/dts/exynos/google/gs101-oriole.dts @@ -90,6 +90,13 @@ eeprom: eeprom@50 { &hsi2c_12 { status = "okay"; /* TODO: add the devices once drivers exist */ + + fuel-gauge@36 { + compatible = "maxim,max77759-fg"; + reg = <0x36>; + reg-names = "m5"; + }; + }; &pinctrl_far_alive {