diff mbox

[v2,06/11] arm/dts: am33xx: Add dt data for usbss

Message ID 1342516407-16515-7-git-send-email-ajay.gupta@ti.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ajay Kumar Gupta July 17, 2012, 9:13 a.m. UTC
Added device tree data for usbss on am33xx. There are two musb controllers
on am33xx platform so have port0_mode and port1_mode additional data.

Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
---
 arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
 1 files changed, 11 insertions(+), 0 deletions(-)

Comments

Sergei Shtylyov July 17, 2012, 12:38 p.m. UTC | #1
Hello.

On 17-07-2012 13:13, Ajay Kumar Gupta wrote:

> Added device tree data for usbss on am33xx. There are two musb controllers
> on am33xx platform so have port0_mode and port1_mode additional data.

> Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> ---
>   arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
>   1 files changed, 11 insertions(+), 0 deletions(-)

> diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
> index 59509c4..b572803 100644
> --- a/arch/arm/boot/dts/am33xx.dtsi
> +++ b/arch/arm/boot/dts/am33xx.dtsi
> @@ -154,5 +154,16 @@
>   			#size-cells = <0>;
>   			ti,hwmods = "i2c3";
>   		};
> +
> +		usb_otg_hs: usb_otg_hs@47400000 {

    The "reg" property is absent, so why did you give the node name the 
address postfix?

> +			compatible = "ti,musb-am33xx";
> +			ti,hwmods = "usb_otg_hs";
> +			multipoint = <1>;
> +			num_eps = <16>;
> +			ram_bits = <12>;
> +			port0_mode = <3>;
> +			port1_mode = <1>;
> +			power = <250>;
> +		};

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ajay Kumar Gupta July 18, 2012, 10:03 a.m. UTC | #2
Hi,
> On 17-07-2012 13:13, Ajay Kumar Gupta wrote:
> 
> > Added device tree data for usbss on am33xx. There are two musb
> controllers
> > on am33xx platform so have port0_mode and port1_mode additional data.
> 
> > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > ---
> >   arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
> >   1 files changed, 11 insertions(+), 0 deletions(-)
> 
> > diff --git a/arch/arm/boot/dts/am33xx.dtsi
> b/arch/arm/boot/dts/am33xx.dtsi
> > index 59509c4..b572803 100644
> > --- a/arch/arm/boot/dts/am33xx.dtsi
> > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > @@ -154,5 +154,16 @@
> >   			#size-cells = <0>;
> >   			ti,hwmods = "i2c3";
> >   		};
> > +
> > +		usb_otg_hs: usb_otg_hs@47400000 {
> 
>     The "reg" property is absent, so why did you give the node name the
> address postfix?

Currently "reg" property is coming from "ti hwmods".

Thanks,
Ajay
> 
> > +			compatible = "ti,musb-am33xx";
> > +			ti,hwmods = "usb_otg_hs";
> > +			multipoint = <1>;
> > +			num_eps = <16>;
> > +			ram_bits = <12>;
> > +			port0_mode = <3>;
> > +			port1_mode = <1>;
> > +			power = <250>;
> > +		};
> 
> WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Ajay Kumar Gupta July 18, 2012, 12:37 p.m. UTC | #3
Hi
> > On 17-07-2012 13:13, Ajay Kumar Gupta wrote:
> >
> > > Added device tree data for usbss on am33xx. There are two musb
> > controllers
> > > on am33xx platform so have port0_mode and port1_mode additional
> data.
> >
> > > Signed-off-by: Ajay Kumar Gupta <ajay.gupta@ti.com>
> > > ---
> > >   arch/arm/boot/dts/am33xx.dtsi |   11 +++++++++++
> > >   1 files changed, 11 insertions(+), 0 deletions(-)
> >
> > > diff --git a/arch/arm/boot/dts/am33xx.dtsi
> > b/arch/arm/boot/dts/am33xx.dtsi
> > > index 59509c4..b572803 100644
> > > --- a/arch/arm/boot/dts/am33xx.dtsi
> > > +++ b/arch/arm/boot/dts/am33xx.dtsi
> > > @@ -154,5 +154,16 @@
> > >   			#size-cells = <0>;
> > >   			ti,hwmods = "i2c3";
> > >   		};
> > > +
> > > +		usb_otg_hs: usb_otg_hs@47400000 {
> >
> >     The "reg" property is absent, so why did you give the node name
> the
> > address postfix?
> 
> Currently "reg" property is coming from "ti hwmods".

I meant base addresses are coming from hwmods and so there is no "reg"
property added here. I will update the patch dropping address postfix.

Ajay

> > > +			compatible = "ti,musb-am33xx";
> > > +			ti,hwmods = "usb_otg_hs";
> > > +			multipoint = <1>;
> > > +			num_eps = <16>;
> > > +			ram_bits = <12>;
> > > +			port0_mode = <3>;
> > > +			port1_mode = <1>;
> > > +			power = <250>;
> > > +		};
> >
> > WBR, Sergei
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/am33xx.dtsi b/arch/arm/boot/dts/am33xx.dtsi
index 59509c4..b572803 100644
--- a/arch/arm/boot/dts/am33xx.dtsi
+++ b/arch/arm/boot/dts/am33xx.dtsi
@@ -154,5 +154,16 @@ 
 			#size-cells = <0>;
 			ti,hwmods = "i2c3";
 		};
+
+		usb_otg_hs: usb_otg_hs@47400000 {
+			compatible = "ti,musb-am33xx";
+			ti,hwmods = "usb_otg_hs";
+			multipoint = <1>;
+			num_eps = <16>;
+			ram_bits = <12>;
+			port0_mode = <3>;
+			port1_mode = <1>;
+			power = <250>;
+		};
 	};
 };