| Message ID | 20241203124943.52572-1-shameerali.kolothum.thodi@huawei.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | migration/multifd: Fix compile error caused by page_size usage | expand |
Shameer Kolothum via <qemu-devel@nongnu.org> writes: > From Commit 90fa121c6c07 ("migration/multifd: Inline page_size and > page_count") onwards page_size is not part of MutiFD*Params but uses > an inline constant instead. > > However, it missed updating an old usage, causing a compile error. > > Fixes: 90fa121c6c07 ("migration/multifd: Inline page_size and page_count") > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> Reviewed-by: Fabiano Rosas <farosas@suse.de>
On Tue, Dec 03, 2024 at 10:17:14AM -0300, Fabiano Rosas wrote: > Shameer Kolothum via <qemu-devel@nongnu.org> writes: > > > From Commit 90fa121c6c07 ("migration/multifd: Inline page_size and > > page_count") onwards page_size is not part of MutiFD*Params but uses > > an inline constant instead. > > > > However, it missed updating an old usage, causing a compile error. > > > > Fixes: 90fa121c6c07 ("migration/multifd: Inline page_size and page_count") > > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> > > Reviewed-by: Fabiano Rosas <farosas@suse.de> Wanna pick this up for your qtest pull for 10.0 altogether?
Peter Xu <peterx@redhat.com> writes: > On Tue, Dec 03, 2024 at 10:17:14AM -0300, Fabiano Rosas wrote: >> Shameer Kolothum via <qemu-devel@nongnu.org> writes: >> >> > From Commit 90fa121c6c07 ("migration/multifd: Inline page_size and >> > page_count") onwards page_size is not part of MutiFD*Params but uses >> > an inline constant instead. >> > >> > However, it missed updating an old usage, causing a compile error. >> > >> > Fixes: 90fa121c6c07 ("migration/multifd: Inline page_size and page_count") >> > Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> >> >> Reviewed-by: Fabiano Rosas <farosas@suse.de> > > Wanna pick this up for your qtest pull for 10.0 altogether? Yep
diff --git a/migration/multifd-uadk.c b/migration/multifd-uadk.c index 6e6a290ae9..6895c1f65a 100644 --- a/migration/multifd-uadk.c +++ b/migration/multifd-uadk.c @@ -169,7 +169,7 @@ static int multifd_uadk_send_prepare(MultiFDSendParams *p, Error **errp) .src_len = page_size, .dst = buf, /* Set dst_len to double the src in case compressed out >= page_size */ - .dst_len = p->page_size * 2, + .dst_len = page_size * 2, }; if (uadk_data->handle) {
From Commit 90fa121c6c07 ("migration/multifd: Inline page_size and page_count") onwards page_size is not part of MutiFD*Params but uses an inline constant instead. However, it missed updating an old usage, causing a compile error. Fixes: 90fa121c6c07 ("migration/multifd: Inline page_size and page_count") Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com> --- migration/multifd-uadk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)