| Message ID | 20241203130655.45293-4-donald.hunter@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Johannes Berg |
| Headers | show |
| Series | netlink: specs: add a spec for nl80211 wiphy | expand |
On Tue, 3 Dec 2024 13:06:51 +0000 Donald Hunter wrote: > Add support for translating arrays of scalars into enum names. But not formatting hints.. ? ;) > Signed-off-by: Donald Hunter <donald.hunter@gmail.com> > --- > tools/net/ynl/lib/ynl.py | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py > index 0d39a83574d5..f07a8404f71a 100644 > --- a/tools/net/ynl/lib/ynl.py > +++ b/tools/net/ynl/lib/ynl.py > @@ -627,6 +627,8 @@ class YnlFamily(SpecFamily): > decoded = self._decode_struct(attr.raw, attr_spec.struct_name) > elif attr_spec.sub_type: > decoded = attr.as_c_array(attr_spec.sub_type) > + if 'enum' in attr_spec: > + decoded = [ self._decode_enum(x, attr_spec) for x in decoded] nit: missing space after 'decoded' or extra space before self, with that fixed: Acked-by: Jakub Kicinski <kuba@kernel.org>
On Wed, 4 Dec 2024 at 02:03, Jakub Kicinski <kuba@kernel.org> wrote: > > On Tue, 3 Dec 2024 13:06:51 +0000 Donald Hunter wrote: > > Add support for translating arrays of scalars into enum names. > > But not formatting hints.. ? ;) Oooh, good catch. This does suggest that a refactor is needed for scalar handling. > > Signed-off-by: Donald Hunter <donald.hunter@gmail.com> > > --- > > tools/net/ynl/lib/ynl.py | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py > > index 0d39a83574d5..f07a8404f71a 100644 > > --- a/tools/net/ynl/lib/ynl.py > > +++ b/tools/net/ynl/lib/ynl.py > > @@ -627,6 +627,8 @@ class YnlFamily(SpecFamily): > > decoded = self._decode_struct(attr.raw, attr_spec.struct_name) > > elif attr_spec.sub_type: > > decoded = attr.as_c_array(attr_spec.sub_type) > > + if 'enum' in attr_spec: > > + decoded = [ self._decode_enum(x, attr_spec) for x in decoded] > > nit: missing space after 'decoded' or extra space before self, with > that fixed: ack. > Acked-by: Jakub Kicinski <kuba@kernel.org>
diff --git a/tools/net/ynl/lib/ynl.py b/tools/net/ynl/lib/ynl.py index 0d39a83574d5..f07a8404f71a 100644 --- a/tools/net/ynl/lib/ynl.py +++ b/tools/net/ynl/lib/ynl.py @@ -627,6 +627,8 @@ class YnlFamily(SpecFamily): decoded = self._decode_struct(attr.raw, attr_spec.struct_name) elif attr_spec.sub_type: decoded = attr.as_c_array(attr_spec.sub_type) + if 'enum' in attr_spec: + decoded = [ self._decode_enum(x, attr_spec) for x in decoded] else: decoded = attr.as_bin() if attr_spec.display_hint:
The nl80211 family encodes the list of supported ciphers as a C array of u32 values. Add support for translating arrays of scalars into enum names. Signed-off-by: Donald Hunter <donald.hunter@gmail.com> --- tools/net/ynl/lib/ynl.py | 2 ++ 1 file changed, 2 insertions(+)