| Message ID | 6b9e55dbf544297d5acf743f6fa473791ab10644.1733242798.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | gpio: GPIO_MVEBU should not default to y when compile-testing | expand |
On Tue, Dec 03, 2024 at 05:23:16PM +0100, Geert Uytterhoeven wrote: > Merely enabling compile-testing should not enable additional > functionality. Sorry for being dumb, but i don't actually see what is wrong here. There are 4 GPIO drivers which have def_bool y COMPILE_TEST is about building as much as possible, in order to find build bugs. So i don't get what you mean by additional functionality. No additional functionality within the MVEBU driver gets enabled by COMPILE_TEST. Andrew
On Tue, Dec 3, 2024 at 9:13 PM Andrew Lunn <andrew@lunn.ch> wrote: > > On Tue, Dec 03, 2024 at 05:23:16PM +0100, Geert Uytterhoeven wrote: > > Merely enabling compile-testing should not enable additional > > functionality. > > Sorry for being dumb, but i don't actually see what is wrong here. > > There are 4 GPIO drivers which have > > def_bool y > > COMPILE_TEST is about building as much as possible, in order to find > build bugs. So i don't get what you mean by additional > functionality. No additional functionality within the MVEBU driver > gets enabled by COMPILE_TEST. > > Andrew No, Geert is right. I have been yelled at by Linus Torvalds already for too eagerly enabling too many options. COMPILE_TEST is really about making it possible to build more things with make allmodconfig, not necessarily defaulting to y for everything. Bart
On Tue, Dec 03, 2024 at 09:29:02PM +0100, Bartosz Golaszewski wrote: > On Tue, Dec 3, 2024 at 9:13 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > On Tue, Dec 03, 2024 at 05:23:16PM +0100, Geert Uytterhoeven wrote: > > > Merely enabling compile-testing should not enable additional > > > functionality. > > > > Sorry for being dumb, but i don't actually see what is wrong here. > > > > There are 4 GPIO drivers which have > > > > def_bool y > > > > COMPILE_TEST is about building as much as possible, in order to find > > build bugs. So i don't get what you mean by additional > > functionality. No additional functionality within the MVEBU driver > > gets enabled by COMPILE_TEST. > > > > Andrew > > No, Geert is right. I have been yelled at by Linus Torvalds already > for too eagerly enabling too many options. COMPILE_TEST is really > about making it possible to build more things with make allmodconfig, > not necessarily defaulting to y for everything. So are you saying COMPILE_TEST should allow something to be enabled, but should not actually enable it? Andrew
Hi Andrew, On Tue, Dec 3, 2024 at 9:59 PM Andrew Lunn <andrew@lunn.ch> wrote: > On Tue, Dec 03, 2024 at 09:29:02PM +0100, Bartosz Golaszewski wrote: > > On Tue, Dec 3, 2024 at 9:13 PM Andrew Lunn <andrew@lunn.ch> wrote: > > > > > > On Tue, Dec 03, 2024 at 05:23:16PM +0100, Geert Uytterhoeven wrote: > > > > Merely enabling compile-testing should not enable additional > > > > functionality. > > > > > > Sorry for being dumb, but i don't actually see what is wrong here. > > > > > > There are 4 GPIO drivers which have > > > > > > def_bool y None of these depend on || COMPILE_TEST. > > > COMPILE_TEST is about building as much as possible, in order to find > > > build bugs. So i don't get what you mean by additional > > > functionality. No additional functionality within the MVEBU driver > > > gets enabled by COMPILE_TEST. > > > > No, Geert is right. I have been yelled at by Linus Torvalds already > > for too eagerly enabling too many options. COMPILE_TEST is really > > about making it possible to build more things with make allmodconfig, > > not necessarily defaulting to y for everything. > > So are you saying COMPILE_TEST should allow something to be enabled, > but should not actually enable it? It is meant for relaxing dependencies, i.e. to allow you to do build-testing of drivers that cannot possibly work on the system you are compiling a kernel for. Gr{oetje,eeting}s, Geert
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> On Tue, 03 Dec 2024 17:23:16 +0100, Geert Uytterhoeven wrote: > Merely enabling compile-testing should not enable additional > functionality. > > Applied, thanks! [1/1] gpio: GPIO_MVEBU should not default to y when compile-testing commit: 70327137eb3eb64f346191dcd0ee5140d5ab34d8 Best regards,
diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index f483201637062cab..d371ce2578ee9703 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -491,8 +491,9 @@ config GPIO_MT7621 Say yes here to support the Mediatek MT7621 SoC GPIO device. config GPIO_MVEBU - def_bool y + bool "Marvell Orion and EBU GPIO support" if COMPILE_TEST depends on PLAT_ORION || ARCH_MVEBU || COMPILE_TEST + default PLAT_ORION || ARCH_MVEBU select GENERIC_IRQ_CHIP select REGMAP_MMIO
Merely enabling compile-testing should not enable additional functionality. Fixes: 956ee0c5c969c9ca ("gpio: mvebu: allow building the module with COMPILE_TEST=y") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpio/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)