| Message ID | 20241203-dtbinding-max77759-v3-1-e1a1d86aca8e@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 89da9eba122d3da8d2994c30d6d5e490a745d0b2 |
| Headers | show |
| Series | [v3] dt-bindings: usb: max33359: add max77759-tcpci flavor | expand |
On Tue, Dec 03, 2024 at 12:17:35PM +0000, André Draszik wrote: > Maxim's MAX77759 is a companion PMIC for USB Type-C applications. It > comprises the following in one package: > * top (including GPIO) > * charger > * fuel gauge > * TCPCi > > While in the same package, TCPCi and Fuel Gauge have separate I2C > addresses, interrupt lines and interrupt status registers and can be > treated independently. > > While the TCPCi part appears identical to max33359 on the surface, it > should still have a dedicated compatible, though, as it is a different > implementation. This will allow for handling differences in case they > are discovered in the future. > > max77759 is used on Google Pixel 6 and Pixel 6 Pro. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml index 20b62228371b..a31e00e6b967 100644 --- a/Documentation/devicetree/bindings/usb/maxim,max33359.yaml +++ b/Documentation/devicetree/bindings/usb/maxim,max33359.yaml @@ -13,8 +13,12 @@ description: Maxim TCPCI Type-C PD controller properties: compatible: - enum: - - maxim,max33359 + oneOf: + - enum: + - maxim,max33359 + - items: + - const: maxim,max77759-tcpci + - const: maxim,max33359 reg: maxItems: 1
Maxim's MAX77759 is a companion PMIC for USB Type-C applications. It comprises the following in one package: * top (including GPIO) * charger * fuel gauge * TCPCi While in the same package, TCPCi and Fuel Gauge have separate I2C addresses, interrupt lines and interrupt status registers and can be treated independently. While the TCPCi part appears identical to max33359 on the surface, it should still have a dedicated compatible, though, as it is a different implementation. This will allow for handling differences in case they are discovered in the future. max77759 is used on Google Pixel 6 and Pixel 6 Pro. Add a dedicated compatible, maxim,max77759-tcpci, to allow for potential differences in the future. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- Changes in v3: - change compatible from maxim,max77759 to maxim,max77759-tcpci - the former should be reserved for a top-level MFD device for the remaining components - drop Acked-by tags due to compatible change - Link to v2: https://lore.kernel.org/r/20241128-dtbinding-max77759-v1-1-733ce24c0802@linaro.org Changes in v2: - collect tags - split out from original series (Krzysztof) - link to original series: https://lore.kernel.org/all/20241127-gs101-phy-lanes-orientation-dts-v1-2-5222d8508b71@linaro.org/ --- Documentation/devicetree/bindings/usb/maxim,max33359.yaml | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- base-commit: ed9a4ad6e5bd3a443e81446476718abebee47e82 change-id: 20241128-dtbinding-max77759-b3ddbd264544 Best regards,