[net,v8,0/3] vsock/test: fix wrong setsockopt() parameters

Message

Konstantin Shkolnyy Dec. 3, 2024, 3:06 p.m. UTC

Parameters were created using wrong C types, which caused them to be of
wrong size on some architectures, causing problems.

The problem with SO_RCVLOWAT was found on s390 (big endian), while x86-64
didn't show it. After the fix, all tests pass on s390.
Then Stefano Garzarella pointed out that SO_VM_SOCKETS_* calls might have
a similar problem, which turned out to be true, hence, the second patch.

Changes for v8:
- Fix whitespace warnings from "checkpatch.pl --strict"
- Add maintainers to Cc:
Changes for v7:
- Rebase on top of https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net.git
- Add the "net" tags to the subjects
Changes for v6:
- rework the patch #3 to avoid creating a new file for new functions,
and exclude vsock_perf from calling the new functions.
- add "Reviewed-by:" to the patch #2.
Changes for v5:
- in the patch #2 replace the introduced uint64_t with unsigned long long
to match documentation
- add a patch #3 that verifies every setsockopt() call.
Changes for v4:
- add "Reviewed-by:" to the first patch, and add a second patch fixing
SO_VM_SOCKETS_* calls, which depends on the first one (hence, it's now
a patch series.)
Changes for v3:
- fix the same problem in vsock_perf and update commit message
Changes for v2:
- add "Fixes:" lines to the commit message

Konstantin Shkolnyy (3):
  vsock/test: fix failures due to wrong SO_RCVLOWAT parameter
  vsock/test: fix parameter types in SO_VM_SOCKETS_* calls
  vsock/test: verify socket options after setting them

 tools/testing/vsock/control.c             |   9 +-
 tools/testing/vsock/msg_zerocopy_common.c |  10 --
 tools/testing/vsock/msg_zerocopy_common.h |   1 -
 tools/testing/vsock/util.c                | 142 ++++++++++++++++++++++
 tools/testing/vsock/util.h                |   7 ++
 tools/testing/vsock/vsock_perf.c          |  20 ++-
 tools/testing/vsock/vsock_test.c          |  75 ++++++------
 tools/testing/vsock/vsock_test_zerocopy.c |   2 +-
 tools/testing/vsock/vsock_uring_test.c    |   2 +-
 9 files changed, 204 insertions(+), 64 deletions(-)

Comments

[e-mail] Dec. 5, 2024, 10:50 a.m. UTC | #1

Hello:

This series was applied to netdev/net.git (main)
by Paolo Abeni <[e-mail]>:

On Tue,  3 Dec 2024 09:06:53 -0600 you wrote:
> Parameters were created using wrong C types, which caused them to be of
> wrong size on some architectures, causing problems.
> 
> The problem with SO_RCVLOWAT was found on s390 (big endian), while x86-64
> didn't show it. After the fix, all tests pass on s390.
> Then Stefano Garzarella pointed out that SO_VM_SOCKETS_* calls might have
> a similar problem, which turned out to be true, hence, the second patch.
> 
> [...]

Here is the summary with links:
  - [net,v8,1/3] vsock/test: fix failures due to wrong SO_RCVLOWAT parameter
    https://git.kernel.org/netdev/net/c/7ce1c0921a80
  - [net,v8,2/3] vsock/test: fix parameter types in SO_VM_SOCKETS_* calls
    https://git.kernel.org/netdev/net/c/3f36ee29e732
  - [net,v8,3/3] vsock/test: verify socket options after setting them
    https://git.kernel.org/netdev/net/c/86814d8ffd55

You are awesome, thank you!