[v4,00/15] media: i2c: ds90ub9xx: Misc fixes and improvements

Message

Tomi Valkeinen Dec. 6, 2024, 8:26 a.m. UTC

This series fixes various small issues in the drivers, and adds a few
things (a couple of pixel formats and a debugging feature).

It also takes a few steps in adding more i2c read/write error handlings
to the drivers, but covers only the easy places.

Adding error handling to all reads/writes needs more thinking, perhaps
adding a "ret" parameter to the calls, similar to the cci_* functions,
or perhaps adding helpers for writing multiple registers from a given
table. Also, in some places rolling back from an error will require
work.

Signed-off-by: Tomi Valkeinen <[e-mail]>
---
Changes in v4:
- Add Jai's Rb
- Use HZ_PER_MHZ in MHZ() macro
- Use num_rxports when setting up the DEBUG_I2C_RX_ID
- Add Reported-by's to patches that add error handling. Note: The
  patches don't close the issue, so I use "Link:" instead of "Closes:"
  as directed in Documentation/process/5.Posting.rst. However, checkpatch
  seems to want "Closes", so it warns about these.
- Link to v3: https://lore.kernel.org/r/[e-mail]

Changes in v3:
- Include bitfield.h for FIELD_PREP()
- Cc stable for relevant fixes
- Link to v2: https://lore.kernel.org/r/[e-mail]

Changes in v2:
- Address comments from Andy
- Add two new patches:
	- media: i2c: ds90ub960: Fix shadowing of local variables
	- media: i2c: ds90ub960: Use HZ_PER_MHZ
- Link to v1: https://lore.kernel.org/r/[e-mail]

---
Tomi Valkeinen (15):
      media: i2c: ds90ub9x3: Fix extra fwnode_handle_put()
      media: i2c: ds90ub960: Fix UB9702 refclk register access
      media: i2c: ds90ub960: Fix use of non-existing registers on UB9702
      media: i2c: ds90ub960: Fix logging SP & EQ status only for UB9702
      media: i2c: ds90ub960: Fix UB9702 VC map
      media: i2c: ds90ub960: Use HZ_PER_MHZ
      media: i2c: ds90ub960: Add support for I2C_RX_ID
      media: i2c: ds90ub960: Add RGB24, RAW8 and RAW10 formats
      media: i2c: ds90ub953: Clear CRC errors in ub953_log_status()
      media: i2c: ds90ub960: Drop unused indirect block define
      media: i2c: ds90ub960: Reduce sleep in ub960_rxport_wait_locks()
      media: i2c: ds90ub960: Handle errors in ub960_log_status_ub960_sp_eq()
      media: i2c: ds90ub913: Add error handling to ub913_hw_init()
      media: i2c: ds90ub953: Add error handling for i2c reads/writes
      media: i2c: ds90ub960: Fix shadowing of local variables

 drivers/media/i2c/ds90ub913.c |  26 ++++--
 drivers/media/i2c/ds90ub953.c |  56 +++++++++----
 drivers/media/i2c/ds90ub960.c | 188 ++++++++++++++++++++++++++++--------------
 3 files changed, 188 insertions(+), 82 deletions(-)
---
base-commit: adc218676eef25575469234709c2d87185ca223a
change-id: 20241004-ub9xx-fixes-bba80dc48627

Best regards,

Comments

Tomi Valkeinen Dec. 6, 2024, 9:50 a.m. UTC | #1

Hi Ricardo,

On 06/12/2024 11:45, Patchwork Integration wrote:
> Dear Tomi Valkeinen:
> 
> Thanks for your patches! Unfortunately media-ci detected some issues:
> 
> # Test media-patchstyle:rebase
> fatal: invalid upstream 'origin/base_branch'
> 
> # Test bisect:rebase
> fatal: invalid upstream 'origin/base_branch'
> 
> # Test checkpatch:rebase
> fatal: invalid upstream 'origin/base_branch'
> 

What about this one?

  Tomi

> 
> Please fix your series, and upload a new version. If you have a patchwork
> account, do not forget to mark the current series as Superseded.
> 
> Best regards, and Happy Hacking!
> Media CI robot out on behalf of the linux-media community.
> 
> ---
> Check the latest rules for contributing your patches at:
> https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> 
> For more details, check the full report at:
> https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/67825296/artifacts/report.htm .
> 
> If you believe that the CI is wrong, kindly open an issue at
> https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> to this message.

Ricardo Ribalda Dec. 6, 2024, 9:54 a.m. UTC | #2

On Fri, 6 Dec 2024 at 10:50, Tomi Valkeinen
<[e-mail]> wrote:
>
> Hi Ricardo,
>
> On 06/12/2024 11:45, Patchwork Integration wrote:
> > Dear Tomi Valkeinen:
> >
> > Thanks for your patches! Unfortunately media-ci detected some issues:
> >
> > # Test media-patchstyle:rebase
> > fatal: invalid upstream 'origin/base_branch'
> >
> > # Test bisect:rebase
> > fatal: invalid upstream 'origin/base_branch'
> >
> > # Test checkpatch:rebase
> > fatal: invalid upstream 'origin/base_branch'
> >
>
> What about this one?

You were lucky enough to send the patch while the server was updating :).

Sorry again

>
>   Tomi
>
> >
> > Please fix your series, and upload a new version. If you have a patchwork
> > account, do not forget to mark the current series as Superseded.
> >
> > Best regards, and Happy Hacking!
> > Media CI robot out on behalf of the linux-media community.
> >
> > ---
> > Check the latest rules for contributing your patches at:
> > https://docs.kernel.org/driver-api/media/maintainer-entry-profile.html
> >
> > For more details, check the full report at:
> > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/67825296/artifacts/report.htm .
> >
> > If you believe that the CI is wrong, kindly open an issue at
> > https://gitlab.freedesktop.org/linux-media/media-ci/-/issues or reply-all
> > to this message.
>

Andy Shevchenko Dec. 6, 2024, 3:34 p.m. UTC | #3

On Fri, Dec 06, 2024 at 10:26:36AM +0200, Tomi Valkeinen wrote:
> This series fixes various small issues in the drivers, and adds a few
> things (a couple of pixel formats and a debugging feature).
> 
> It also takes a few steps in adding more i2c read/write error handlings
> to the drivers, but covers only the easy places.
> 
> Adding error handling to all reads/writes needs more thinking, perhaps
> adding a "ret" parameter to the calls, similar to the cci_* functions,
> or perhaps adding helpers for writing multiple registers from a given
> table. Also, in some places rolling back from an error will require
> work.

FWIW,
Reviewed-by: Andy Shevchenko <[e-mail]>