| Message ID | 20241205194020.785846-2-igor.belwon@mentallysanemainliners.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: exynos990: Add cmu nodes | expand |
On 05/12/2024 20:40, Igor Belwon wrote: > Add CMU nodes for: > - cmu_top: provides clocks for other blocks > - cmu_hsi0: provides clocks for usb31 > > Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org> > --- > arch/arm64/boot/dts/exynos/exynos990.dtsi | 27 +++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynos990.dtsi b/arch/arm64/boot/dts/exynos/exynos990.dtsi > index c1986f00e443..49bb1e156843 100644 > --- a/arch/arm64/boot/dts/exynos/exynos990.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynos990.dtsi > @@ -5,6 +5,7 @@ > * Copyright (c) 2024, Igor Belwon <igor.belwon@mentallysanemainliners.org> > */ > > +#include <dt-bindings/clock/samsung,exynos990.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > > / { > @@ -199,6 +200,23 @@ pinctrl_peric1: pinctrl@10730000 { > interrupts = <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>; > }; > > + cmu_hsi0: clock-controller@10a00000 { > + compatible = "samsung,exynos990-cmu-hsi0"; > + reg = <0x10a00000 0x8000>; > + #clock-cells = <1>; > + > + clocks = <&oscclk>, > + <&cmu_top CLK_DOUT_CMU_HSI0_BUS>, > + <&cmu_top CLK_DOUT_CMU_HSI0_USB31DRD>, > + <&cmu_top CLK_DOUT_CMU_HSI0_USBDP_DEBUG>, > + <&cmu_top CLK_DOUT_CMU_HSI0_DPGTC>; > + clock-names = "oscclk", "dout_cmu_hsi0_bus", One per line. > + "dout_cmu_hsi0_usb31drd", Misaligned. > + "dout_cmu_hsi0_usbdp_debug", > + "dout_cmu_hsi0_dpgtc"; > + Drop stray blank line. > + }; > + Best regards, Krzysztof
Hi Krzysztof Thanks for the review. I just have a question - do you prefer having the two (pmu and cmu) device tree changes spread out, or should I merge them into one patchset? Thanks and best regards Igor
diff --git a/arch/arm64/boot/dts/exynos/exynos990.dtsi b/arch/arm64/boot/dts/exynos/exynos990.dtsi index c1986f00e443..49bb1e156843 100644 --- a/arch/arm64/boot/dts/exynos/exynos990.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos990.dtsi @@ -5,6 +5,7 @@ * Copyright (c) 2024, Igor Belwon <igor.belwon@mentallysanemainliners.org> */ +#include <dt-bindings/clock/samsung,exynos990.h> #include <dt-bindings/interrupt-controller/arm-gic.h> / { @@ -199,6 +200,23 @@ pinctrl_peric1: pinctrl@10730000 { interrupts = <GIC_SPI 417 IRQ_TYPE_LEVEL_HIGH>; }; + cmu_hsi0: clock-controller@10a00000 { + compatible = "samsung,exynos990-cmu-hsi0"; + reg = <0x10a00000 0x8000>; + #clock-cells = <1>; + + clocks = <&oscclk>, + <&cmu_top CLK_DOUT_CMU_HSI0_BUS>, + <&cmu_top CLK_DOUT_CMU_HSI0_USB31DRD>, + <&cmu_top CLK_DOUT_CMU_HSI0_USBDP_DEBUG>, + <&cmu_top CLK_DOUT_CMU_HSI0_DPGTC>; + clock-names = "oscclk", "dout_cmu_hsi0_bus", + "dout_cmu_hsi0_usb31drd", + "dout_cmu_hsi0_usbdp_debug", + "dout_cmu_hsi0_dpgtc"; + + }; + pinctrl_hsi1: pinctrl@13040000 { compatible = "samsung,exynos990-pinctrl"; reg = <0x13040000 0x1000>; @@ -231,6 +249,15 @@ pinctrl_cmgp: pinctrl@15c30000 { compatible = "samsung,exynos990-pinctrl"; reg = <0x15c30000 0x1000>; }; + + cmu_top: clock-controller@1a330000 { + compatible = "samsung,exynos990-cmu-top"; + reg = <0x1a330000 0x8000>; + #clock-cells = <1>; + + clocks = <&oscclk>; + clock-names = "oscclk"; + }; }; timer {
Add CMU nodes for: - cmu_top: provides clocks for other blocks - cmu_hsi0: provides clocks for usb31 Signed-off-by: Igor Belwon <igor.belwon@mentallysanemainliners.org> --- arch/arm64/boot/dts/exynos/exynos990.dtsi | 27 +++++++++++++++++++++++ 1 file changed, 27 insertions(+)