| Message ID | 20241205111939.1796244-6-dario.binacchi@amarulasolutions.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Support spread spectrum clocking for i.MX8N PLLs | expand |
On Thu, Dec 05, 2024 at 12:17:40PM +0100, Dario Binacchi wrote: > Define clocks and clock-names properties of the anatop device node. This we see from the diff. Say something useful, instead of repeating subject and patch contents. > > Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> > > --- > > (no changes since v4) > > Changes in v4: > - New > > .../bindings/clock/fsl,imx8m-anatop.yaml | 53 ++++++++++++++++++- > 1 file changed, 52 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml > index bbd22e95b319..f439b0a94ce2 100644 > --- a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml > +++ b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml > @@ -30,22 +30,73 @@ properties: > interrupts: > maxItems: 1 > > + clocks: > + minItems: 2 > + maxItems: 3 > + > + clock-names: > + minItems: 2 > + maxItems: 3 > + > '#clock-cells': > const: 1 > > required: > - compatible > - reg > + - clocks > + - clock-names That's an ABI break and nothing in commit msg mentions it, nothing explains impact or rationale behind. > - '#clock-cells' Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml index bbd22e95b319..f439b0a94ce2 100644 --- a/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml +++ b/Documentation/devicetree/bindings/clock/fsl,imx8m-anatop.yaml @@ -30,22 +30,73 @@ properties: interrupts: maxItems: 1 + clocks: + minItems: 2 + maxItems: 3 + + clock-names: + minItems: 2 + maxItems: 3 + '#clock-cells': const: 1 required: - compatible - reg + - clocks + - clock-names - '#clock-cells' +allOf: + - if: + properties: + compatible: + contains: + const: fsl,imx8mq-anatop + then: + properties: + clocks: + items: + - description: 32k osc + - description: 25m osc + - description: 27m osc + clock-names: + items: + - const: ckil + - const: osc_25m + - const: osc_27m + else: + properties: + clocks: + items: + - description: 32k osc + - description: 24m osc + + clock-names: + items: + - const: osc_32k + - const: osc_24m + additionalProperties: false examples: - | - anatop: clock-controller@30360000 { + clock-controller@30360000 { compatible = "fsl,imx8mn-anatop", "fsl,imx8mm-anatop"; reg = <0x30360000 0x10000>; #clock-cells = <1>; + clocks = <&osc_32k>, <&osc_24m>; + clock-names = "osc_32k", "osc_24m"; + }; + + - | + clock-controller@30360000 { + compatible = "fsl,imx8mq-anatop"; + reg = <0x30360000 0x10000>; + #clock-cells = <1>; + clocks = <&ckil>, <&osc_25m>, <&osc_27m>; + clock-names = "ckil", "osc_25m", "osc_27m"; }; ...
Define clocks and clock-names properties of the anatop device node. Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com> --- (no changes since v4) Changes in v4: - New .../bindings/clock/fsl,imx8m-anatop.yaml | 53 ++++++++++++++++++- 1 file changed, 52 insertions(+), 1 deletion(-)