diff mbox series

[2/3] kbuild: Drop support for include/asm-<arch> in headers_check.pl

Message ID 19fb5b49396239d28020015ba2640d77dacdb6c2.1733404444.git.geert+renesas@glider.be (mailing list archive)
State New
Headers show
Series Update reference to include/asm-<arch> | expand

Commit Message

Geert Uytterhoeven Dec. 5, 2024, 1:20 p.m. UTC
"include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
time ago.  All assembler header files are now included using
"#include <asm/*>", so there is no longer a need to rewrite paths.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 usr/include/headers_check.pl | 4 ----
 1 file changed, 4 deletions(-)

Comments

Masahiro Yamada Dec. 7, 2024, 2:27 p.m. UTC | #1
On Thu, Dec 5, 2024 at 10:20 PM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
>
> "include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
> time ago.  All assembler header files are now included using
> "#include <asm/*>", so there is no longer a need to rewrite paths.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---


After this commit, the second argument $arch is no longer
used.

Please clean up

my ($dir, $arch, @files) = @ARGV;







>  usr/include/headers_check.pl | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/usr/include/headers_check.pl b/usr/include/headers_check.pl
> index b6aec5e4365f9bf2..7070c891ea294b4d 100755
> --- a/usr/include/headers_check.pl
> +++ b/usr/include/headers_check.pl
> @@ -54,10 +54,6 @@ sub check_include
>                 my $inc = $1;
>                 my $found;
>                 $found = stat($dir . "/" . $inc);
> -               if (!$found) {
> -                       $inc =~ s#asm/#asm-$arch/#;
> -                       $found = stat($dir . "/" . $inc);
> -               }
>                 if (!$found) {
>                         printf STDERR "$filename:$lineno: included file '$inc' is not exported\n";
>                         $ret = 1;
> --
> 2.34.1
>
>
Masahiro Yamada Dec. 10, 2024, 10:16 a.m. UTC | #2
I applied this with the follow-up squashed. Thanks.
(https://lore.kernel.org/all/CAK7LNAR8dy-=EcsZFb-tjXSk2sK7sHrV0WSSV4E8dzRh5Veceg@mail.gmail.com/T/#t)

This should be dropped from Andrew Morton's tree.




On Sat, Dec 7, 2024 at 11:27 PM Masahiro Yamada <masahiroy@kernel.org> wrote:
>
> On Thu, Dec 5, 2024 at 10:20 PM Geert Uytterhoeven
> <geert+renesas@glider.be> wrote:
> >
> > "include/asm-<arch>" was replaced by "arch/<arch>/include/asm" a long
> > time ago.  All assembler header files are now included using
> > "#include <asm/*>", so there is no longer a need to rewrite paths.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
>
>
> After this commit, the second argument $arch is no longer
> used.
>
> Please clean up
>
> my ($dir, $arch, @files) = @ARGV;
>
>
>
>
>
>
>
> >  usr/include/headers_check.pl | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/usr/include/headers_check.pl b/usr/include/headers_check.pl
> > index b6aec5e4365f9bf2..7070c891ea294b4d 100755
> > --- a/usr/include/headers_check.pl
> > +++ b/usr/include/headers_check.pl
> > @@ -54,10 +54,6 @@ sub check_include
> >                 my $inc = $1;
> >                 my $found;
> >                 $found = stat($dir . "/" . $inc);
> > -               if (!$found) {
> > -                       $inc =~ s#asm/#asm-$arch/#;
> > -                       $found = stat($dir . "/" . $inc);
> > -               }
> >                 if (!$found) {
> >                         printf STDERR "$filename:$lineno: included file '$inc' is not exported\n";
> >                         $ret = 1;
> > --
> > 2.34.1
> >
> >
>
>
> --
> Best Regards
> Masahiro Yamada



--
Best Regards
Masahiro Yamada
diff mbox series

Patch

diff --git a/usr/include/headers_check.pl b/usr/include/headers_check.pl
index b6aec5e4365f9bf2..7070c891ea294b4d 100755
--- a/usr/include/headers_check.pl
+++ b/usr/include/headers_check.pl
@@ -54,10 +54,6 @@  sub check_include
 		my $inc = $1;
 		my $found;
 		$found = stat($dir . "/" . $inc);
-		if (!$found) {
-			$inc =~ s#asm/#asm-$arch/#;
-			$found = stat($dir . "/" . $inc);
-		}
 		if (!$found) {
 			printf STDERR "$filename:$lineno: included file '$inc' is not exported\n";
 			$ret = 1;