| Message ID | 20241210092614.3951748-1-wenst@chromium.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names | expand |
On Tue, 10 Dec 2024 17:26:12 +0800, Chen-Yu Tsai wrote: > The MT6397 PMIC bindings specify exact names for its sub-nodes. The > names used in the current dts don't match, causing a validation error. > > Fix up the names. Also drop the label for the regulators node, since > any reference should be against the individual regulator sub-nodes. > > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > --- > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade New warnings running 'make CHECK_DTBS=y mediatek/mt8173-evb.dtb' for 20241210092614.3951748-1-wenst@chromium.org: arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vcore: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vgpu: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vdrm: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vio18: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vtcxo: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_va28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vio28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vusb: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vcama: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmc: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmch: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vemc3v3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp1: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp2: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp4: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp5: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp6: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vibr: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml#
On Wed, Dec 11, 2024 at 5:43 AM Rob Herring (Arm) <robh@kernel.org> wrote: > > > On Tue, 10 Dec 2024 17:26:12 +0800, Chen-Yu Tsai wrote: > > The MT6397 PMIC bindings specify exact names for its sub-nodes. The > > names used in the current dts don't match, causing a validation error. > > > > Fix up the names. Also drop the label for the regulators node, since > > any reference should be against the individual regulator sub-nodes. > > > > Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") > > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> > > --- > > arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > My bot found new DTB warnings on the .dts files added or changed in this > series. > > Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings > are fixed by another series. Ultimately, it is up to the platform > maintainer whether these warnings are acceptable or not. No need to reply > unless the platform maintainer has comments. > > If you already ran DT checks and didn't see these error(s), then > make sure dt-schema is up to date: > > pip3 install dtschema --upgrade > > > New warnings running 'make CHECK_DTBS=y mediatek/mt8173-evb.dtb' for 20241210092614.3951748-1-wenst@chromium.org: > > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vpca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca15: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vsramca7: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vcore: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vgpu: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vdrm: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: buck_vio18: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vtcxo: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_va28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vio28: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vusb: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vcama: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmc: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vmch: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vemc3v3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp1: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp2: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp3: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp4: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp5: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vgp6: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# > arch/arm64/boot/dts/mediatek/mt8173-evb.dtb: regulators: ldo_vibr: Unevaluated properties are not allowed ('regulator-compatible' was unexpected) > from schema $id: http://devicetree.org/schemas/regulator/mediatek,mt6397-regulator.yaml# Ack. I already prepared another series to address these. ChenYu
On Tue, 10 Dec 2024 17:26:12 +0800, Chen-Yu Tsai wrote: > The MT6397 PMIC bindings specify exact names for its sub-nodes. The > names used in the current dts don't match, causing a validation error. > > Fix up the names. Also drop the label for the regulators node, since > any reference should be against the individual regulator sub-nodes. > > > [...] Applied to v6.13-next/dts64, thanks! [1/2] arm64: dts: mediatek: mt8173-elm: Fix MT6397 PMIC sub-node names commit: beb06b727194f68b0a4b5183e50c88265ce185af [2/2] arm64: dts: mediatek: mt8173-evb: Fix MT6397 PMIC sub-node names commit: 9545ba142865b9099d43c972b9ebcf463606499a Cheers, Angelo
diff --git a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi index b91072f4723f..b5d4b5baf478 100644 --- a/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi @@ -931,7 +931,7 @@ pmic: pmic { interrupt-controller; #interrupt-cells = <2>; - clock: mt6397clock { + clock: clocks { compatible = "mediatek,mt6397-clk"; #clock-cells = <1>; }; @@ -942,7 +942,7 @@ pio6397: pinctrl { #gpio-cells = <2>; }; - regulator: mt6397regulator { + regulators { compatible = "mediatek,mt6397-regulator"; mt6397_vpca15_reg: buck_vpca15 { @@ -1108,7 +1108,7 @@ mt6397_vibr_reg: ldo_vibr { }; }; - rtc: mt6397rtc { + rtc: rtc { compatible = "mediatek,mt6397-rtc"; }; };
The MT6397 PMIC bindings specify exact names for its sub-nodes. The names used in the current dts don't match, causing a validation error. Fix up the names. Also drop the label for the regulators node, since any reference should be against the individual regulator sub-nodes. Fixes: 689b937bedde ("arm64: dts: mediatek: add mt8173 elm and hana board") Signed-off-by: Chen-Yu Tsai <wenst@chromium.org> --- arch/arm64/boot/dts/mediatek/mt8173-elm.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)