| Message ID | 20241206025139.2148833-2-trunixs.kim@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v4,1/1] arm64: dts: exynosautov920: add watchdog DT node | expand |
On 06/12/2024 03:51, Taewan Kim wrote: > From: Byoungtae Cho <bt.cho@samsung.com> > > Adds two watchdog devices for ExynosAutoV920 SoC. > > Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> > Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> > --- > .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > index c759134c909e..7b9591255e91 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi > @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 { > "noc"; > }; > > + watchdog_cl0: watchdog@10060000 { You need to do careful rebase, not just accept whatever tools shown you. This is now placed in incorrect order - not keeping sorting by unit address. Best regards, Krzysztof
on 11/12/2024 01:50 UTC+09:00, Taewan Kim wrote: >> From: Byoungtae Cho <bt.cho@samsung.com> >> >> Adds two watchdog devices for ExynosAutoV920 SoC. >> >> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> >> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> >> --- >> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ >> 1 file changed, 20 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >> index c759134c909e..7b9591255e91 100644 >> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >> @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 { >> "noc"; >> }; >> >> + watchdog_cl0: watchdog@10060000 { > >You need to do careful rebase, not just accept whatever tools shown you. > >This is now placed in incorrect order - not keeping sorting by unit address. I seems to me that the addresses are sorted correctly in order. Could you kindly check again? clock-controller@1002_0000 watchdog@1006_0000 watchdog@1007_0000 interrupt-controller@1040_0000 And if there are any rules I might not be aware of, please let me know. Best regards, Taewan Kim
On 11/12/2024 02:50, 김태완 wrote: > on 11/12/2024 01:50 UTC+09:00, Taewan Kim wrote: >>> From: Byoungtae Cho <bt.cho@samsung.com> >>> >>> Adds two watchdog devices for ExynosAutoV920 SoC. >>> >>> Signed-off-by: Byoungtae Cho <bt.cho@samsung.com> >>> Signed-off-by: Taewan Kim <trunixs.kim@samsung.com> >>> --- >>> .../arm64/boot/dts/exynos/exynosautov920.dtsi | 20 +++++++++++++++++++ >>> 1 file changed, 20 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >> b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >>> index c759134c909e..7b9591255e91 100644 >>> --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >>> +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi >>> @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 { >>> "noc"; >>> }; >>> >>> + watchdog_cl0: watchdog@10060000 { >> >> You need to do careful rebase, not just accept whatever tools shown you. >> >> This is now placed in incorrect order - not keeping sorting by unit address. > > I seems to me that the addresses are sorted correctly in order. > Could you kindly check again? > > clock-controller@1002_0000 > watchdog@1006_0000 > watchdog@1007_0000 > interrupt-controller@1040_0000 > > And if there are any rules I might not be aware of, please let me know. You are right, I got impression last was 1004, but that's 1040. Thanks for correcting me. I applied now. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi index c759134c909e..7b9591255e91 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov920.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov920.dtsi @@ -183,6 +183,26 @@ cmu_misc: clock-controller@10020000 { "noc"; }; + watchdog_cl0: watchdog@10060000 { + compatible = "samsung,exynosautov920-wdt"; + reg = <0x10060000 0x100>; + interrupts = <GIC_SPI 953 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&xtcxo>, <&xtcxo>; + clock-names = "watchdog", "watchdog_src"; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,cluster-index = <0>; + }; + + watchdog_cl1: watchdog@10070000 { + compatible = "samsung,exynosautov920-wdt"; + reg = <0x10070000 0x100>; + interrupts = <GIC_SPI 952 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&xtcxo>, <&xtcxo>; + clock-names = "watchdog", "watchdog_src"; + samsung,syscon-phandle = <&pmu_system_controller>; + samsung,cluster-index = <1>; + }; + gic: interrupt-controller@10400000 { compatible = "arm,gic-v3"; #interrupt-cells = <3>;