| Message ID | 20241210-x1e80100-usb-qmp-supply-fix-v1-5-0adda5d30bbd@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: x1e*: Fix USB QMP PHY supplies | expand |
On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold <stephan.gerhold@linaro.org> wrote: > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 > (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 > are actually powered by &vreg_l2j_1p2. > > Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies from > the x1e80100-crd device tree, assume that the fix also applies here. Though I can't verify schematics (perhaps Laurentiu can?), can confirm USBs still work as expected with this change. Tested-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> > > Cc: stable@vger.kernel.org > Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345") > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > --- > arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > index b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a43adec291a31f9beed 100644 > --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > @@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy { > }; > > &usb_1_ss0_qmpphy { > - vdda-phy-supply = <&vreg_l3e_1p2>; > + vdda-phy-supply = <&vreg_l2j_1p2>; > vdda-pll-supply = <&vreg_l1j_0p9>; > > status = "okay"; > @@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy { > }; > > &usb_1_ss1_qmpphy { > - vdda-phy-supply = <&vreg_l3e_1p2>; > + vdda-phy-supply = <&vreg_l2j_1p2>; > vdda-pll-supply = <&vreg_l2d_0p9>; > > status = "okay"; > > -- > 2.47.0 >
Internal Use - Confidential > -----Original Message----- > From: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> > Sent: Tuesday, December 10, 2024 10:45 PM > > On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold <stephan.gerhold@linaro.org> > wrote: > > > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 > (i.e. > > USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 are > > actually powered by &vreg_l2j_1p2. > > > > Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies > > from the x1e80100-crd device tree, assume that the fix also applies here. > > Though I can't verify schematics (perhaps Laurentiu can?)can confirm USBs > still work as expected with this change. Yep, just checked the schematics and can confirm. --- Best Regards, Laurentiu > Tested-by: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> > > > > > Cc: stable@vger.kernel.org > > Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell > > XPS 13 9345") > > Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> > > --- > > arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > > b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > > index > > > b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a4 > 3adec > > 291a31f9beed 100644 > > --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > > +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts > > @@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy { }; > > > > &usb_1_ss0_qmpphy { > > - vdda-phy-supply = <&vreg_l3e_1p2>; > > + vdda-phy-supply = <&vreg_l2j_1p2>; > > vdda-pll-supply = <&vreg_l1j_0p9>; > > > > status = "okay"; > > @@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy { }; > > > > &usb_1_ss1_qmpphy { > > - vdda-phy-supply = <&vreg_l3e_1p2>; > > + vdda-phy-supply = <&vreg_l2j_1p2>; > > vdda-pll-supply = <&vreg_l2d_0p9>; > > > > status = "okay"; > > > > -- > > 2.47.0 > >
On Wed, Dec 11, 2024 at 11:35:37AM +0000, Tudor, Laurentiu wrote: > > Internal Use - Confidential Looks like you need to fix your mail setup for when you're interacting with the community and mailing lists. > > -----Original Message----- > > From: Aleksandrs Vinarskis <alex.vinarskis@gmail.com> > > Sent: Tuesday, December 10, 2024 10:45 PM > > > > On Tue, 10 Dec 2024 at 10:07, Stephan Gerhold <stephan.gerhold@linaro.org> > > wrote: > > > > > > On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 > > (i.e. > > > USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 are > > > actually powered by &vreg_l2j_1p2. > > > > > > Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies > > > from the x1e80100-crd device tree, assume that the fix also applies here. > > > > Though I can't verify schematics (perhaps Laurentiu can?)can confirm USBs > > still work as expected with this change. > > Yep, just checked the schematics and can confirm. Thanks for confirming. Johan
diff --git a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts index b112092fbb9fd955adca1ae8a76294c776fa2d1e..1aec536218bc2c9197410a43adec291a31f9beed 100644 --- a/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts +++ b/arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts @@ -1093,7 +1093,7 @@ &usb_1_ss0_hsphy { }; &usb_1_ss0_qmpphy { - vdda-phy-supply = <&vreg_l3e_1p2>; + vdda-phy-supply = <&vreg_l2j_1p2>; vdda-pll-supply = <&vreg_l1j_0p9>; status = "okay"; @@ -1125,7 +1125,7 @@ &usb_1_ss1_hsphy { }; &usb_1_ss1_qmpphy { - vdda-phy-supply = <&vreg_l3e_1p2>; + vdda-phy-supply = <&vreg_l2j_1p2>; vdda-pll-supply = <&vreg_l2d_0p9>; status = "okay";
On the X1E80100 CRD, &vreg_l3e_1p2 only powers &usb_mp_qmpphy0/1 (i.e. USBSS_3 and USBSS_4). The QMP PHYs for USB_0, USB_1 and USB_2 are actually powered by &vreg_l2j_1p2. Since x1e80100-dell-xps13-9345 mostly just mirrors the power supplies from the x1e80100-crd device tree, assume that the fix also applies here. Cc: stable@vger.kernel.org Fixes: f5b788d0e8cd ("arm64: dts: qcom: Add support for X1-based Dell XPS 13 9345") Signed-off-by: Stephan Gerhold <stephan.gerhold@linaro.org> --- arch/arm64/boot/dts/qcom/x1e80100-dell-xps13-9345.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)