diff mbox series

drm/rockchip: avoid 64-bit division

Message ID 20241212091100.3154773-1-geert+renesas@glider.be (mailing list archive)
State Not Applicable
Headers show
Series drm/rockchip: avoid 64-bit division | expand

Checks

Context Check Description
netdev/tree_selection success Not a local patch

Commit Message

Geert Uytterhoeven Dec. 12, 2024, 9:10 a.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Dividing a 64-bit integer prevents building this for 32-bit targets:

ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/rockchip/rockchipdrm.ko] undefined!

As this function is not performance criticial, just Use the div_u64() helper.

Fixes: 128a9bf8ace2 ("drm/rockchip: Add basic RK3588 HDMI output support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Reviewed-by: Nathan Chancellor <nathan@kernel.org>
---
 drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Geert Uytterhoeven Dec. 12, 2024, 9:13 a.m. UTC | #1 
On Thu, Dec 12, 2024 at 10:11 AM Geert Uytterhoeven
<geert+renesas@glider.be> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Dividing a 64-bit integer prevents building this for 32-bit targets:
>
> ERROR: modpost: "__aeabi_uldivmod" [drivers/gpu/drm/rockchip/rockchipdrm.ko] undefined!
>
> As this function is not performance criticial, just Use the div_u64() helper.
>
> Fixes: 128a9bf8ace2 ("drm/rockchip: Add basic RK3588 HDMI output support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Reviewed-by: Nathan Chancellor <nathan@kernel.org>

Please ignore this patch. Something went wrong with my scripting.
Sorry for the inconvenience.

Gr{oetje,eeting}s,

                        Geert
diff mbox series

Patch

diff --git a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
index 9c796ee4c303a9a9..c8b362cc2b95fd49 100644
--- a/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
+++ b/drivers/gpu/drm/rockchip/dw_hdmi_qp-rockchip.c
@@ -82,7 +82,7 @@  static void dw_hdmi_qp_rockchip_encoder_enable(struct drm_encoder *encoder)
 		 * comment in rk_hdptx_phy_power_on() from
 		 * drivers/phy/rockchip/phy-rockchip-samsung-hdptx.c
 		 */
-		phy_set_bus_width(hdmi->phy, rate / 100);
+		phy_set_bus_width(hdmi->phy, div_u64(rate, 100));
 	}
 }