diff mbox series

ARM: dts: imx27-eukrea-mbimxsd27: Fix ADS7846 interrupt

Message ID 20241212114535.558496-1-festevam@gmail.com (mailing list archive)
State New
Headers show
Series ARM: dts: imx27-eukrea-mbimxsd27: Fix ADS7846 interrupt | expand

Commit Message

Fabio Estevam Dec. 12, 2024, 11:45 a.m. UTC 
From: Fabio Estevam <festevam@denx.de>

According to ti,ads7843.yaml the ADS7846 interrupt should be described
via interrupt-parent and interrupts properties.

Do it accordingly to fix the following dt-schema warning:

ads7846@0: interrupts: [[9], [25], [8]] is too long

Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Dec. 12, 2024, 12:08 p.m. UTC | #1 
On 12/12/2024 12:45, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> According to ti,ads7843.yaml the ADS7846 interrupt should be described

That's not true. Above binding does not tell it at all. Nothing about
parent.

> via interrupt-parent and interrupts properties.
> 
> Do it accordingly to fix the following dt-schema warning:
> 
> ads7846@0: interrupts: [[9], [25], [8]] is too long

Not entirely. Your reasons are just not correct. There is different
error there - wrong interrupt specifier because you have some specific
interrupt controller (GPIO). Author probably wanted interrupts extended.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts b/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts
index d78793601306..7ee1e8c3bb08 100644
--- a/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx27-eukrea-mbimxsd27-baseboard.dts
@@ -76,7 +76,8 @@  ads7846@0 {
 		pinctrl-names = "default";
 		pinctrl-0 = <&pinctrl_touch>;
 		reg = <0>;
-		interrupts = <&gpio4 25 IRQ_TYPE_LEVEL_LOW>;
+		interrupt-parent = <&gpio4>;
+		interrupts = <25 IRQ_TYPE_LEVEL_LOW>;
 		spi-cpol;
 		spi-max-frequency = <1500000>;
 		ti,keep-vref-on;