| Message ID | 20241211133618.2014083-1-marcel.hamer@windriver.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b05d30c2b6df7e2172b18bf1baee9b202f9c6b53 |
| Delegated to: | Kalle Valo |
| Headers | show |
| Series | brcmfmac: add missing header include for brcmf_dbg | expand |
On December 11, 2024 2:36:34 PM Marcel Hamer <marcel.hamer@windriver.com> wrote: > Including the fwil.h header file can lead to a build error: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \ > In function ‘brcmf_fil_cmd_int_set’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \ > declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration] > 90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, > cmd, data); > | ^~~~~~~~~ > > The error is often avoided because the debug.h header file is included > before the fwil.h header file. > > This makes sure the header include order is irrelevant by explicitly adding the > debug.h header. I understand the change, but not sure if it is actually solving anything. Then again there are plenty of include files including others so... Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> > Fixes: 31343230abb1 ("wifi: brcmfmac: export firmware interface functions") > Signed-off-by: Marcel Hamer <marcel.hamer@windriver.com> > --- > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 2 ++ > 1 file changed, 2 insertions(+)
Marcel Hamer <marcel.hamer@windriver.com> wrote: > Including the fwil.h header file can lead to a build error: > > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \ > In function ‘brcmf_fil_cmd_int_set’: > drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \ > declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration] > 90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, cmd, data); > | ^~~~~~~~~ > > The error is often avoided because the debug.h header file is included > before the fwil.h header file. > > This makes sure the header include order is irrelevant by explicitly adding the > debug.h header. > > Fixes: 31343230abb1 ("wifi: brcmfmac: export firmware interface functions") > Signed-off-by: Marcel Hamer <marcel.hamer@windriver.com> > Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com> Patch applied to wireless-next.git, thanks. b05d30c2b6df wifi: brcmfmac: add missing header include for brcmf_dbg
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h index 31e080e4da66..ab3d6cfcb02b 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h @@ -6,6 +6,8 @@ #ifndef _fwil_h_ #define _fwil_h_ +#include "debug.h" + /******************************************************************************* * Dongle command codes that are interpreted by firmware ******************************************************************************/
Including the fwil.h header file can lead to a build error: drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h: \ In function ‘brcmf_fil_cmd_int_set’: drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h:90:9: error: implicit \ declaration of function ‘brcmf_dbg’ [-Werror=implicit-function-declaration] 90 | brcmf_dbg(FIL, "ifidx=%d, cmd=%d, value=%d\n", ifp->ifidx, cmd, data); | ^~~~~~~~~ The error is often avoided because the debug.h header file is included before the fwil.h header file. This makes sure the header include order is irrelevant by explicitly adding the debug.h header. Fixes: 31343230abb1 ("wifi: brcmfmac: export firmware interface functions") Signed-off-by: Marcel Hamer <marcel.hamer@windriver.com> --- drivers/net/wireless/broadcom/brcm80211/brcmfmac/fwil.h | 2 ++ 1 file changed, 2 insertions(+)