| Message ID | 20241213-dts-qcom-cdsp-mpss-base-address-v3-20-2e0036fccd8d@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: qcom: Fix remoteproc memory base and length | expand |
On 13.12.2024 3:54 PM, Krzysztof Kozlowski wrote: > The address space in MPSS/Modem PAS (Peripheral Authentication Service) > remoteproc node should point to the QDSP PUB address space > (QDSP6...SS_PUB) which has a length of 0x10000. Value of 0x4040 was > copied from older DTS, but it grew since then. > > This should have no functional impact on Linux users, because PAS loader > does not use this address space at all. > > Cc: stable@vger.kernel.org > Fixes: 41c72f36b286 ("arm64: dts: qcom: sdx75: Add remoteproc node") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes in v3: > New patch > --- > arch/arm64/boot/dts/qcom/sdx75.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi > index 5f7e59ecf1ca6298cb252ee0654bc7eaeefbd303..a7cb6bacc4ad5551486d2ded930c1a256d27655e 100644 > --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi > @@ -893,7 +893,7 @@ tcsr: syscon@1fc0000 { > > remoteproc_mpss: remoteproc@4080000 { > compatible = "qcom,sdx75-mpss-pas"; > - reg = <0 0x04080000 0 0x4040>; > + reg = <0 0x04080000 0 0x10000>; I think this should be 0x04400000 instead Konrad
On 13/12/2024 15:56, Konrad Dybcio wrote: > On 13.12.2024 3:54 PM, Krzysztof Kozlowski wrote: >> The address space in MPSS/Modem PAS (Peripheral Authentication Service) >> remoteproc node should point to the QDSP PUB address space >> (QDSP6...SS_PUB) which has a length of 0x10000. Value of 0x4040 was >> copied from older DTS, but it grew since then. >> >> This should have no functional impact on Linux users, because PAS loader >> does not use this address space at all. >> >> Cc: stable@vger.kernel.org >> Fixes: 41c72f36b286 ("arm64: dts: qcom: sdx75: Add remoteproc node") >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> >> --- >> >> Changes in v3: >> New patch >> --- >> arch/arm64/boot/dts/qcom/sdx75.dtsi | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi >> index 5f7e59ecf1ca6298cb252ee0654bc7eaeefbd303..a7cb6bacc4ad5551486d2ded930c1a256d27655e 100644 >> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi >> @@ -893,7 +893,7 @@ tcsr: syscon@1fc0000 { >> >> remoteproc_mpss: remoteproc@4080000 { >> compatible = "qcom,sdx75-mpss-pas"; >> - reg = <0 0x04080000 0 0x4040>; >> + reg = <0 0x04080000 0 0x10000>; > > I think this should be 0x04400000 instead There are two QDSP6SS blocks - one at 0x0408_0000 and other you mention at 0x0440_0000 (MSS_VQ6). I think in all other DTS, e.g. SM8550, we describe the first, so 0x0408. Best regards, Krzysztof
On 13.12.2024 4:06 PM, Krzysztof Kozlowski wrote: > On 13/12/2024 15:56, Konrad Dybcio wrote: >> On 13.12.2024 3:54 PM, Krzysztof Kozlowski wrote: >>> The address space in MPSS/Modem PAS (Peripheral Authentication Service) >>> remoteproc node should point to the QDSP PUB address space >>> (QDSP6...SS_PUB) which has a length of 0x10000. Value of 0x4040 was >>> copied from older DTS, but it grew since then. >>> >>> This should have no functional impact on Linux users, because PAS loader >>> does not use this address space at all. >>> >>> Cc: stable@vger.kernel.org >>> Fixes: 41c72f36b286 ("arm64: dts: qcom: sdx75: Add remoteproc node") >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> >>> --- >>> >>> Changes in v3: >>> New patch >>> --- >>> arch/arm64/boot/dts/qcom/sdx75.dtsi | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi >>> index 5f7e59ecf1ca6298cb252ee0654bc7eaeefbd303..a7cb6bacc4ad5551486d2ded930c1a256d27655e 100644 >>> --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi >>> @@ -893,7 +893,7 @@ tcsr: syscon@1fc0000 { >>> >>> remoteproc_mpss: remoteproc@4080000 { >>> compatible = "qcom,sdx75-mpss-pas"; >>> - reg = <0 0x04080000 0 0x4040>; >>> + reg = <0 0x04080000 0 0x10000>; >> >> I think this should be 0x04400000 instead > > > There are two QDSP6SS blocks - one at 0x0408_0000 and other you mention > at 0x0440_0000 (MSS_VQ6). I think in all other DTS, e.g. SM8550, we > describe the first, so 0x0408. Ok right I looked at the wrong one Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Konrad
diff --git a/arch/arm64/boot/dts/qcom/sdx75.dtsi b/arch/arm64/boot/dts/qcom/sdx75.dtsi index 5f7e59ecf1ca6298cb252ee0654bc7eaeefbd303..a7cb6bacc4ad5551486d2ded930c1a256d27655e 100644 --- a/arch/arm64/boot/dts/qcom/sdx75.dtsi +++ b/arch/arm64/boot/dts/qcom/sdx75.dtsi @@ -893,7 +893,7 @@ tcsr: syscon@1fc0000 { remoteproc_mpss: remoteproc@4080000 { compatible = "qcom,sdx75-mpss-pas"; - reg = <0 0x04080000 0 0x4040>; + reg = <0 0x04080000 0 0x10000>; interrupts-extended = <&intc GIC_SPI 250 IRQ_TYPE_EDGE_RISING>, <&smp2p_modem_in 0 IRQ_TYPE_EDGE_RISING>,
The address space in MPSS/Modem PAS (Peripheral Authentication Service) remoteproc node should point to the QDSP PUB address space (QDSP6...SS_PUB) which has a length of 0x10000. Value of 0x4040 was copied from older DTS, but it grew since then. This should have no functional impact on Linux users, because PAS loader does not use this address space at all. Cc: stable@vger.kernel.org Fixes: 41c72f36b286 ("arm64: dts: qcom: sdx75: Add remoteproc node") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes in v3: New patch --- arch/arm64/boot/dts/qcom/sdx75.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)