Message ID | 20241216023124.3817798-1-shengjiu.wang@nxp.com (mailing list archive) |
---|---|
State | New |
Headers | show |
Series | ALSA: compress_offload: Fix get_user usage | expand |
On Mon, Dec 16, 2024 at 10:32 AM Shengjiu Wang <shengjiu.wang@nxp.com> wrote: > > ERROR: modpost: "__get_user_bad" [sound/core/snd-compress.ko] undefined! > > Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode") > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202412141955.FBjr5T5q-lkp@intel.com/ > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > --- > sound/core/compress_offload.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c > index 6f2d389abd04..dadf074359ec 100644 > --- a/sound/core/compress_offload.c > +++ b/sound/core/compress_offload.c > @@ -1182,7 +1182,7 @@ static int snd_compr_task_seq(struct snd_compr_stream *stream, unsigned long arg > > if (stream->runtime->state != SNDRV_PCM_STATE_SETUP) > return -EPERM; > - retval = get_user(seqno, (__u64 __user *)arg); > + retval = get_user(seqno, (__u32 __user *)arg); This change may not be accurate. Do we have get_user() for 64bit? Best regards Shengjiu Wang > if (retval < 0) > return retval; > retval = 0; > -- > 2.37.1 > >
diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 6f2d389abd04..dadf074359ec 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -1182,7 +1182,7 @@ static int snd_compr_task_seq(struct snd_compr_stream *stream, unsigned long arg if (stream->runtime->state != SNDRV_PCM_STATE_SETUP) return -EPERM; - retval = get_user(seqno, (__u64 __user *)arg); + retval = get_user(seqno, (__u32 __user *)arg); if (retval < 0) return retval; retval = 0;
ERROR: modpost: "__get_user_bad" [sound/core/snd-compress.ko] undefined! Fixes: 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202412141955.FBjr5T5q-lkp@intel.com/ Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- sound/core/compress_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)