mbox series

[net-next,v2,0/5] mdio support updates

Message ID 20241216071957.2587354-1-nikita.yoush@cogentembedded.com (mailing list archive)
Headers show
Series mdio support updates | expand

Message

Nikita Yushchenko Dec. 16, 2024, 7:19 a.m. UTC
This series cleans up rswitch mdio support, and adds C22 operations.

Nikita Yushchenko (5):
  net: renesas: rswitch: do not write to MPSM register at init time
  net: renesas: rswitch: use FIELD_PREP for remaining MPIC register
    fields
  net: renesas: rswitch: align mdio C45 operations with datasheet
  net: renesas: rswitch: use generic MPSM operation for mdio C45
  net: renesas: rswitch: add mdio C22 support
---
v1: https://lore.kernel.org/netdev/20241208155236.108582-1-nikita.yoush@cogentembedded.com/

changes since v1:
- rebase against net-next/main as of commit 92c932b9946c ("Merge branch
  'mptcp-pm-userspace-misc-cleanups'"),
- remove no longer used definitions for MMIS1 register bits,
- add patch to use FIELD_PREP for MPIC register fields, to keep the same
  style as in already merged patch.
---
 drivers/net/ethernet/renesas/rswitch.c | 84 ++++++++++++++++----------
 drivers/net/ethernet/renesas/rswitch.h | 33 ++++------
 2 files changed, 65 insertions(+), 52 deletions(-)

Comments

Yoshihiro Shimoda Dec. 16, 2024, 11:54 a.m. UTC | #1
Hello Nikita-san,

> From: Nikita Yushchenko, Sent: Monday, December 16, 2024 4:20 PM
> 
> This series cleans up rswitch mdio support, and adds C22 operations.
> 
> Nikita Yushchenko (5):
>   net: renesas: rswitch: do not write to MPSM register at init time
>   net: renesas: rswitch: use FIELD_PREP for remaining MPIC register
>     fields
>   net: renesas: rswitch: align mdio C45 operations with datasheet
>   net: renesas: rswitch: use generic MPSM operation for mdio C45
>   net: renesas: rswitch: add mdio C22 support

Thank you for the patches. The patches look good to me. So,

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

And, I tested the patches on my environment (R-Car S4 Spider), and
it worked without any regression. So,

Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
> v1:
<snip URL>
> 
> changes since v1:
> - rebase against net-next/main as of commit 92c932b9946c ("Merge branch
>   'mptcp-pm-userspace-misc-cleanups'"),
> - remove no longer used definitions for MMIS1 register bits,
> - add patch to use FIELD_PREP for MPIC register fields, to keep the same
>   style as in already merged patch.
> ---
>  drivers/net/ethernet/renesas/rswitch.c | 84 ++++++++++++++++----------
>  drivers/net/ethernet/renesas/rswitch.h | 33 ++++------
>  2 files changed, 65 insertions(+), 52 deletions(-)
> 
> --
> 2.39.5