| Message ID | 20241216113052.15696-12-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Refine dts for Radxa ROCK 5C | expand |
On 16/12/2024 12:30, FUKAUMI Naoki wrote: > Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with You have so many typos in almost each commit msg. Here both in subject and commit msg. Run spell check before you send to the lists. Don't expect the reviewers to be your computer tools. Explain what is being fixed here. Why would you prefer to match with vendor kernel? > vendor kernel[1]. > > [1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > > Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C") > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > --- Best regards, Krzysztof
On 12/16/24 22:41, Krzysztof Kozlowski wrote: > On 16/12/2024 12:30, FUKAUMI Naoki wrote: >> Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with > > > > You have so many typos in almost each commit msg. Here both in subject > and commit msg. > > Run spell check before you send to the lists. Don't expect the reviewers > to be your computer tools. Sorry for my poor English. I'll check it next time. > Explain what is being fixed here. Why would you prefer to match with > vendor kernel? Not my preference, but the only reference. Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. >> vendor kernel[1]. >> >> [1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts >> >> Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C") >> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >> --- > > > > > Best regards, > Krzysztof >
On 17/12/2024 01:43, FUKAUMI Naoki wrote: > On 12/16/24 22:41, Krzysztof Kozlowski wrote: >> On 16/12/2024 12:30, FUKAUMI Naoki wrote: >>> Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with >> >> >> >> You have so many typos in almost each commit msg. Here both in subject >> and commit msg. >> >> Run spell check before you send to the lists. Don't expect the reviewers >> to be your computer tools. > > Sorry for my poor English. I'll check it next time. I am not pointing out English. I am pointing out not using standard tool, spellcheck, to fix issues in effortless way. > >> Explain what is being fixed here. Why would you prefer to match with >> vendor kernel? > > Not my preference, but the only reference. Then why the reference is correct? Provide some arguments why this should be changed to the "reference" and not the "reference" fixed. Best regards, Krzysztof
On 12/17/24 15:24, Krzysztof Kozlowski wrote: > On 17/12/2024 01:43, FUKAUMI Naoki wrote: >> On 12/16/24 22:41, Krzysztof Kozlowski wrote: >>> On 16/12/2024 12:30, FUKAUMI Naoki wrote: >>>> Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with >>> >>> >>> >>> You have so many typos in almost each commit msg. Here both in subject >>> and commit msg. >>> >>> Run spell check before you send to the lists. Don't expect the reviewers >>> to be your computer tools. >> >> Sorry for my poor English. I'll check it next time. > > I am not pointing out English. I am pointing out not using standard > tool, spellcheck, to fix issues in effortless way. > >> >>> Explain what is being fixed here. Why would you prefer to match with >>> vendor kernel? >> >> Not my preference, but the only reference. > > Then why the reference is correct? Provide some arguments why this > should be changed to the "reference" and not the "reference" fixed. Are you serious? Why do you think the current code is correct? It's written by me, typo and copy-pasto generator. Need more argument? Best regards, -- FUKAUMI Naoki Typo and Copy-Pasto Generator > Best regards, > Krzysztof >
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts index fbe491e63852..60eabe22ef02 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts @@ -639,7 +639,6 @@ vcc_2v0_pldo_s3: dcdc-reg7 { regulator-boot-on; regulator-min-microvolt = <2000000>; regulator-max-microvolt = <2000000>; - regulator-ramp-delay = <12500>; regulator-state-mem { regulator-on-in-suspend; @@ -793,7 +792,8 @@ vdda_0v75_s0: nldo-reg3 { regulator-max-microvolt = <750000>; regulator-state-mem { - regulator-off-in-suspend; + regulator-on-in-suspend; + regulator-suspend-microvolt = <750000>; }; };
Fix proparties for dcdc-reg7 and nldo-reg3 regulators to match with vendor kernel[1]. [1] https://github.com/radxa/kernel/blob/linux-6.1-stan-rkr1/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts Fixes: 3ddf5cdb77e6 ("arm64: dts: rockchip: add Radxa ROCK 5C") Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- Changes in v5: - Reword commit message Changes in v4: - none Changes in v3: - none Changes in v2: - split from "arm64: dts: rockchip: fix pmic properties for Radxa ROCK 5C" --- arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)