| Message ID | 20241216113052.15696-3-naoki@radxa.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: rockchip: Refine dts for Radxa ROCK 5C | expand |
On 2024-12-16 12:30, FUKAUMI Naoki wrote: > Use more common name "pwm-fan" for pwm-fan node. No functinal change. > > Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> Looking good to me, as a preparatory patch. Please, feel free to include: Reviewed-by: Dragan Simic <dsimic@manjaro.org> > --- > Changes in v5 > - Reword commit message > Changes in v4 > - new > --- > arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > index 23e9b447b6f0..630f026d856c 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts > @@ -68,7 +68,7 @@ led-1 { > }; > }; > > - fan { > + pwm-fan { > compatible = "pwm-fan"; > #cooling-cells = <2>; > cooling-levels = <0 64 128 192 255>;
On 16/12/2024 12:30, FUKAUMI Naoki wrote:
> Use more common name "pwm-fan" for pwm-fan node. No functinal change.
No, generic name is fan.
Best regards,
Krzysztof
On 16/12/2024 13:43, Dragan Simic wrote: > On 2024-12-16 12:30, FUKAUMI Naoki wrote: >> Use more common name "pwm-fan" for pwm-fan node. No functinal change. >> >> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> > > Looking good to me, as a preparatory patch. Please, feel free > to include: > > Reviewed-by: Dragan Simic <dsimic@manjaro.org> That's just incorrect. If you really want to review such trivial patches, perform a full review. Best regards, Krzysztof
On 12/16/24 22:37, Krzysztof Kozlowski wrote: > On 16/12/2024 12:30, FUKAUMI Naoki wrote: >> Use more common name "pwm-fan" for pwm-fan node. No functinal change. > > No, generic name is fan. https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/ Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > Best regards, > Krzysztof >
On 16/12/2024 14:48, FUKAUMI Naoki wrote: > On 12/16/24 22:37, Krzysztof Kozlowski wrote: >> On 16/12/2024 12:30, FUKAUMI Naoki wrote: >>> Use more common name "pwm-fan" for pwm-fan node. No functinal change. >> >> No, generic name is fan. > > https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/ > And? That's incorrect advice. There is no such device as "pwm-fan". There is a "fan" and whether it is pwm or gpio it does not matter. See DT spec and generic names recommendation. Best regards, Krzysztof
On 12/16/24 22:56, Krzysztof Kozlowski wrote: > On 16/12/2024 14:48, FUKAUMI Naoki wrote: >> On 12/16/24 22:37, Krzysztof Kozlowski wrote: >>> On 16/12/2024 12:30, FUKAUMI Naoki wrote: >>>> Use more common name "pwm-fan" for pwm-fan node. No functinal change. >>> >>> No, generic name is fan. >> >> https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/ >> > And? That's incorrect advice. There is no such device as "pwm-fan". > There is a "fan" and whether it is pwm or gpio it does not matter. > > See DT spec and generic names recommendation. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67 Is it wrong? Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > Best regards, > Krzysztof >
On 16/12/2024 15:19, FUKAUMI Naoki wrote: > On 12/16/24 22:56, Krzysztof Kozlowski wrote: >> On 16/12/2024 14:48, FUKAUMI Naoki wrote: >>> On 12/16/24 22:37, Krzysztof Kozlowski wrote: >>>> On 16/12/2024 12:30, FUKAUMI Naoki wrote: >>>>> Use more common name "pwm-fan" for pwm-fan node. No functinal change. >>>> >>>> No, generic name is fan. >>> >>> https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/ >>> >> And? That's incorrect advice. There is no such device as "pwm-fan". >> There is a "fan" and whether it is pwm or gpio it does not matter. >> >> See DT spec and generic names recommendation. > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67 > > Is it wrong? Yes. Best regards, Krzysztof
On 12/16/24 23:27, Krzysztof Kozlowski wrote: > On 16/12/2024 15:19, FUKAUMI Naoki wrote: >> On 12/16/24 22:56, Krzysztof Kozlowski wrote: >>> On 16/12/2024 14:48, FUKAUMI Naoki wrote: >>>> On 12/16/24 22:37, Krzysztof Kozlowski wrote: >>>>> On 16/12/2024 12:30, FUKAUMI Naoki wrote: >>>>>> Use more common name "pwm-fan" for pwm-fan node. No functinal change. >>>>> >>>>> No, generic name is fan. >>>> >>>> https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/ >>>> >>> And? That's incorrect advice. There is no such device as "pwm-fan". >>> There is a "fan" and whether it is pwm or gpio it does not matter. >>> >>> See DT spec and generic names recommendation. >> >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67 >> >> Is it wrong? > Yes. Okay, please fix it. Feel free to use: Reported-by: FUKAUMI Naoki <naoki@radxa.com> Best regards, -- FUKAUMI Naoki Radxa Computer (Shenzhen) Co., Ltd. > Best regards, > Krzysztof >
Hello Krzysztof, On 2024-12-16 14:42, Krzysztof Kozlowski wrote: > On 16/12/2024 13:43, Dragan Simic wrote: >> On 2024-12-16 12:30, FUKAUMI Naoki wrote: >>> Use more common name "pwm-fan" for pwm-fan node. No functinal change. >>> >>> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> >> >> Looking good to me, as a preparatory patch. Please, feel free >> to include: >> >> Reviewed-by: Dragan Simic <dsimic@manjaro.org> > > That's just incorrect. If you really want to review such trivial > patches, perform a full review. Well, I don't see what's wrong with reviewing two fan-related patches that go together? Moreover, in this case it's about using a generic name, which you prefer, or using a more common name, which I prefer. However, as a maintainer, your preference matters more.
On 2024-12-16 15:38, FUKAUMI Naoki wrote: > On 12/16/24 23:27, Krzysztof Kozlowski wrote: >> On 16/12/2024 15:19, FUKAUMI Naoki wrote: >>> On 12/16/24 22:56, Krzysztof Kozlowski wrote: >>>> On 16/12/2024 14:48, FUKAUMI Naoki wrote: >>>>> On 12/16/24 22:37, Krzysztof Kozlowski wrote: >>>>>> On 16/12/2024 12:30, FUKAUMI Naoki wrote: >>>>>>> Use more common name "pwm-fan" for pwm-fan node. No functinal >>>>>>> change. >>>>>> >>>>>> No, generic name is fan. >>>>> >>>>> >>>>> https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/ >>>>> >>>> And? That's incorrect advice. There is no such device as "pwm-fan". >>>> There is a "fan" and whether it is pwm or gpio it does not matter. >>>> >>>> See DT spec and generic names recommendation. >>> >>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67 >>> >>> Is it wrong? >> Yes. > > Okay, please fix it. Good point. > Feel free to use: > > Reported-by: FUKAUMI Naoki <naoki@radxa.com>
On Mon Dec 16, 2024 at 3:38 PM CET, FUKAUMI Naoki wrote: > On 12/16/24 23:27, Krzysztof Kozlowski wrote: > > On 16/12/2024 15:19, FUKAUMI Naoki wrote: > >> On 12/16/24 22:56, Krzysztof Kozlowski wrote: > >>> On 16/12/2024 14:48, FUKAUMI Naoki wrote: > >>>> On 12/16/24 22:37, Krzysztof Kozlowski wrote: > >>>>> On 16/12/2024 12:30, FUKAUMI Naoki wrote: > >>>>>> Use more common name "pwm-fan" for pwm-fan node. No functinal change. > >>>>> > >>>>> No, generic name is fan. > >>>> > >>>> https://lore.kernel.org/all/71aa84af7a030e66487076e0976c8cad@manjaro.org/ > >>>> > >>> And? That's incorrect advice. There is no such device as "pwm-fan". > >>> There is a "fan" and whether it is pwm or gpio it does not matter. > >>> > >>> See DT spec and generic names recommendation. > >> > >> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/hwmon/pwm-fan.yaml#n67 > >> > >> Is it wrong? > > Yes. There's an(other) issue with the binding: line 91 references `&fan0` while it isn't defined (in the binding example) Cheers, Diederik
diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts index 23e9b447b6f0..630f026d856c 100644 --- a/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts +++ b/arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts @@ -68,7 +68,7 @@ led-1 { }; }; - fan { + pwm-fan { compatible = "pwm-fan"; #cooling-cells = <2>; cooling-levels = <0 64 128 192 255>;
Use more common name "pwm-fan" for pwm-fan node. No functinal change. Signed-off-by: FUKAUMI Naoki <naoki@radxa.com> --- Changes in v5 - Reword commit message Changes in v4 - new --- arch/arm64/boot/dts/rockchip/rk3588s-rock-5c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)