| Message ID | 20241213173901.599226-3-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Geert Uytterhoeven |
| Headers | show |
| Series | Add RZ/G3E pinctrl support | expand |
Hi Biju, On Fri, Dec 13, 2024 at 6:39 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > Add documentation for the pin controller found on the Renesas RZ/G3E > (R9A09G047) SoC. The RZ/G3E PFC is similar to the RZ/V2H SoC but has more > pins(P00-PS3). > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v2->v3: > * Updated the macros with hardware indices in the hardware manual. > * The changes are trivial, so retained ack tag from Conor. Thanks for the update! > --- a/include/dt-bindings/pinctrl/rzg2l-pinctrl.h > +++ b/include/dt-bindings/pinctrl/rzg2l-pinctrl.h > @@ -24,16 +24,35 @@ > #define PORT_P9 9 > #define PORT_PA 10 > #define PORT_PB 11 > +#define PORT_PC 12 > +#define PORT_PD 13 > +#define PORT_PE 14 > +#define PORT_PF 15 > +#define PORT_PG 16 > +#define PORT_PH 17 > +#define PORT_PI 18 Port PI does not exist on any supported SoC. Hence please drop it, so DTS writers cannot use it by accident. > +#define PORT_PJ 19 > +#define PORT_PK 20 > +#define PORT_PL 21 > +#define PORT_PM 22 > +#define PORT_PN 23 > +#define PORT_PO 24 > +#define PORT_PP 25 > +#define PORT_PQ 26 > +#define PORT_PR 27 Same for ports PN-PR. I understand you need to keep the definition for PORT_P9, as it is shared with RZ/V2H. However, that could be fixed by having separate RZV2H_P* and RZG3E_P* port definitions, like you had for RZ/G3E in v2. You already have SoC-specific *_PORT_PINMUX() and *_GPIO() macros below. A disadvantage is that it may grow this file when new SoCs are added. But that can be mitigated by splitting it in multiple files: --- include/dt-bindings/pinctrl/renesas,r9a09g047-pinctrl.h --- #include <dt-bindings/pinctrl/rzg2l-pinctrl.h> #define RZG3E_... ... --- include/dt-bindings/pinctrl/renesas,r9a09g057-pinctrl.h --- #include <dt-bindings/pinctrl/rzg2l-pinctrl.h> #define RZV2H_... ... What do you think? > +#define PORT_PS 28 > > /* > * Create the pin index from its bank and position numbers and store in > * the upper 16 bits the alternate function identifier > */ > #define RZG2L_PORT_PINMUX(b, p, f) ((b) * RZG2L_PINS_PER_PORT + (p) | ((f) << 16)) > +#define RZG3E_PORT_PINMUX(b, p, f) RZG2L_PORT_PINMUX(PORT_P##b, p, f) > #define RZV2H_PORT_PINMUX(b, p, f) RZG2L_PORT_PINMUX(PORT_P##b, p, f) > > /* Convert a port and pin label to its global pin index */ > #define RZG2L_GPIO(port, pin) ((port) * RZG2L_PINS_PER_PORT + (pin)) > +#define RZG3E_GPIO(port, pin) RZG2L_GPIO(PORT_P##port, pin) > #define RZV2H_GPIO(port, pin) RZG2L_GPIO(PORT_P##port, pin) > > #endif /* __DT_BINDINGS_RZG2L_PINCTRL_H */ Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert Uytterhoeven, Thanks for the feedback. > -----Original Message----- > From: Geert Uytterhoeven <geert@linux-m68k.org> > Sent: 16 December 2024 15:22 > Subject: Re: [PATCH v3 2/7] dt-bindings: pinctrl: renesas: Document RZ/G3E SoC > > Hi Biju, > > On Fri, Dec 13, 2024 at 6:39 PM Biju Das <biju.das.jz@bp.renesas.com> wrote: > > Add documentation for the pin controller found on the Renesas RZ/G3E > > (R9A09G047) SoC. The RZ/G3E PFC is similar to the RZ/V2H SoC but has > > more pins(P00-PS3). > > > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v2->v3: > > * Updated the macros with hardware indices in the hardware manual. > > * The changes are trivial, so retained ack tag from Conor. > > Thanks for the update! > > > --- a/include/dt-bindings/pinctrl/rzg2l-pinctrl.h > > +++ b/include/dt-bindings/pinctrl/rzg2l-pinctrl.h > > @@ -24,16 +24,35 @@ > > #define PORT_P9 9 > > #define PORT_PA 10 > > #define PORT_PB 11 > > +#define PORT_PC 12 > > +#define PORT_PD 13 > > +#define PORT_PE 14 > > +#define PORT_PF 15 > > +#define PORT_PG 16 > > +#define PORT_PH 17 > > +#define PORT_PI 18 > > Port PI does not exist on any supported SoC. > Hence please drop it, so DTS writers cannot use it by accident. OK. > > > +#define PORT_PJ 19 > > +#define PORT_PK 20 > > +#define PORT_PL 21 > > +#define PORT_PM 22 > > +#define PORT_PN 23 > > +#define PORT_PO 24 > > +#define PORT_PP 25 > > +#define PORT_PQ 26 > > +#define PORT_PR 27 > > Same for ports PN-PR. > > I understand you need to keep the definition for PORT_P9, as it is shared with RZ/V2H. > > However, that could be fixed by having separate RZV2H_P* and RZG3E_P* port definitions, like you had > for RZ/G3E in v2. You already have SoC-specific *_PORT_PINMUX() and *_GPIO() macros below. > A disadvantage is that it may grow this file when new SoCs are added. > But that can be mitigated by splitting it in multiple files: > > --- include/dt-bindings/pinctrl/renesas,r9a09g047-pinctrl.h --- > > #include <dt-bindings/pinctrl/rzg2l-pinctrl.h> > > #define RZG3E_... > ... > > --- include/dt-bindings/pinctrl/renesas,r9a09g057-pinctrl.h --- > > #include <dt-bindings/pinctrl/rzg2l-pinctrl.h> > > #define RZV2H_... > ... > > What do you think? Yes, it is clean by using supported ports. I will send next version based on this. Cheers, Biju
diff --git a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml index a1805b6e3f63..768bb3c2b456 100644 --- a/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml +++ b/Documentation/devicetree/bindings/pinctrl/renesas,rzg2l-pinctrl.yaml @@ -26,6 +26,7 @@ properties: - renesas,r9a07g043-pinctrl # RZ/G2UL{Type-1,Type-2} and RZ/Five - renesas,r9a07g044-pinctrl # RZ/G2{L,LC} - renesas,r9a08g045-pinctrl # RZ/G3S + - renesas,r9a09g047-pinctrl # RZ/G3E - renesas,r9a09g057-pinctrl # RZ/V2H(P) - items: @@ -125,7 +126,7 @@ additionalProperties: drive-push-pull: true renesas,output-impedance: description: - Output impedance for pins on the RZ/V2H(P) SoC. The value provided by this + Output impedance for pins on the RZ/{G3E,V2H(P)} SoC. The value provided by this property corresponds to register bit values that can be set in the PFC_IOLH_mn register, which adjusts the drive strength value and is pin-dependent. $ref: /schemas/types.yaml#/definitions/uint32 @@ -142,7 +143,9 @@ allOf: properties: compatible: contains: - const: renesas,r9a09g057-pinctrl + enum: + - renesas,r9a09g047-pinctrl + - renesas,r9a09g057-pinctrl then: properties: resets: diff --git a/include/dt-bindings/pinctrl/rzg2l-pinctrl.h b/include/dt-bindings/pinctrl/rzg2l-pinctrl.h index c70308961dfa..ab6f71d9504d 100644 --- a/include/dt-bindings/pinctrl/rzg2l-pinctrl.h +++ b/include/dt-bindings/pinctrl/rzg2l-pinctrl.h @@ -24,16 +24,35 @@ #define PORT_P9 9 #define PORT_PA 10 #define PORT_PB 11 +#define PORT_PC 12 +#define PORT_PD 13 +#define PORT_PE 14 +#define PORT_PF 15 +#define PORT_PG 16 +#define PORT_PH 17 +#define PORT_PI 18 +#define PORT_PJ 19 +#define PORT_PK 20 +#define PORT_PL 21 +#define PORT_PM 22 +#define PORT_PN 23 +#define PORT_PO 24 +#define PORT_PP 25 +#define PORT_PQ 26 +#define PORT_PR 27 +#define PORT_PS 28 /* * Create the pin index from its bank and position numbers and store in * the upper 16 bits the alternate function identifier */ #define RZG2L_PORT_PINMUX(b, p, f) ((b) * RZG2L_PINS_PER_PORT + (p) | ((f) << 16)) +#define RZG3E_PORT_PINMUX(b, p, f) RZG2L_PORT_PINMUX(PORT_P##b, p, f) #define RZV2H_PORT_PINMUX(b, p, f) RZG2L_PORT_PINMUX(PORT_P##b, p, f) /* Convert a port and pin label to its global pin index */ #define RZG2L_GPIO(port, pin) ((port) * RZG2L_PINS_PER_PORT + (pin)) +#define RZG3E_GPIO(port, pin) RZG2L_GPIO(PORT_P##port, pin) #define RZV2H_GPIO(port, pin) RZG2L_GPIO(PORT_P##port, pin) #endif /* __DT_BINDINGS_RZG2L_PINCTRL_H */