diff mbox series

[1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support

Message ID 20241216120029.143944-2-biju.das.jz@bp.renesas.com (mailing list archive)
State New
Delegated to: Geert Uytterhoeven
Headers show
Series Add RZ/G3E RIIC support | expand

Commit Message

Biju Das Dec. 16, 2024, noon UTC
Document support for the I2C Bus Interface (RIIC) found in the Renesas
RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
(R9A09G057) RIIC IP.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 Documentation/devicetree/bindings/i2c/renesas,riic.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Geert Uytterhoeven Dec. 16, 2024, 4:18 p.m. UTC | #1
On Mon, Dec 16, 2024 at 1:01 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document support for the I2C Bus Interface (RIIC) found in the Renesas
> RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> (R9A09G057) RIIC IP.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Geert Uytterhoeven Dec. 16, 2024, 4:34 p.m. UTC | #2
Hi Biju,

On Mon, Dec 16, 2024 at 1:01 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document support for the I2C Bus Interface (RIIC) found in the Renesas
> RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> (R9A09G057) RIIC IP.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

> --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> @@ -26,7 +26,9 @@ properties:
>            - const: renesas,riic-rz      # RZ/A or RZ/G2L
>
>        - items:
> -          - const: renesas,riic-r9a08g045   # RZ/G3S
> +          - enum:
> +              - renesas,riic-r9a08g045   # RZ/G3S
> +              - renesas,riic-r9a09g047   # RZ/G3E
>            - const: renesas,riic-r9a09g057   # RZ/V2H(P)
>
>        - const: renesas,riic-r9a09g057   # RZ/V2H(P)

BTW, I think you want to make resets required for renesas,riic-r9a09g057, too.
Or perhaps make it required unless compatible with
renesas,riic-r7s72100 or renesas,riic-r7s9210.

Gr{oetje,eeting}s,

                        Geert
Conor Dooley Dec. 16, 2024, 6:36 p.m. UTC | #3
On Mon, Dec 16, 2024 at 12:00:23PM +0000, Biju Das wrote:
> Document support for the I2C Bus Interface (RIIC) found in the Renesas
> RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> (R9A09G057) RIIC IP.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>
Biju Das Dec. 16, 2024, 8:23 p.m. UTC | #4
Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 16 December 2024 16:34
> Subject: Re: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
> 
> Hi Biju,
> 
> On Mon, Dec 16, 2024 at 1:01 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Document support for the I2C Bus Interface (RIIC) found in the Renesas
> > RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> > (R9A09G057) RIIC IP.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> > --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> > @@ -26,7 +26,9 @@ properties:
> >            - const: renesas,riic-rz      # RZ/A or RZ/G2L
> >
> >        - items:
> > -          - const: renesas,riic-r9a08g045   # RZ/G3S
> > +          - enum:
> > +              - renesas,riic-r9a08g045   # RZ/G3S
> > +              - renesas,riic-r9a09g047   # RZ/G3E
> >            - const: renesas,riic-r9a09g057   # RZ/V2H(P)
> >
> >        - const: renesas,riic-r9a09g057   # RZ/V2H(P)
> 
> BTW, I think you want to make resets required for renesas,riic-r9a09g057, too.
> Or perhaps make it required unless compatible with
> renesas,riic-r7s72100 or renesas,riic-r7s9210.

Thanks for pointing out. I will make reset required property for
renesas,riic-r9a09g057 compatible devices.

Cheers,
Biju
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
index 505a8ec92266..830d5baa32c8 100644
--- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
+++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
@@ -26,7 +26,9 @@  properties:
           - const: renesas,riic-rz      # RZ/A or RZ/G2L
 
       - items:
-          - const: renesas,riic-r9a08g045   # RZ/G3S
+          - enum:
+              - renesas,riic-r9a08g045   # RZ/G3S
+              - renesas,riic-r9a09g047   # RZ/G3E
           - const: renesas,riic-r9a09g057   # RZ/V2H(P)
 
       - const: renesas,riic-r9a09g057   # RZ/V2H(P)