| Message ID | 20241217024206.1700170-2-david@ixit.cz (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] dt-bindings: media: imx219: Rename to include vendor prefix | expand |
On Mon, Dec 16, 2024 at 09:41:51PM -0500, David Heidelberg wrote: > Use the reg property instead of text in the description. > Drop useless description of reg property. > > Signed-off-by: David Heidelberg <david@ixit.cz> > --- > Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml You are using non-standard tools to generate patches. See checkpatch warnings. Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Oh, the checkpatch script keeps warning me every time I commit—I guess it needs to be addressed. I currently use: [diff] srcprefix = ./ dstprefix = ./ Originally, my intention was to use: [diff] noprefix = true This was to make it easier to copy-paste directly into the shell (git log -p, etc.). However, it ended up breaking too many applications. Setting srcprefix and dstprefix instead keeps everything working properly. Is there any chance a patch allowing a ./ prefix could make it into checkpatch? What do you think, Krzysztof? Thank you, David On 17/12/2024 02:40, Krzysztof Kozlowski wrote: > On Mon, Dec 16, 2024 at 09:41:51PM -0500, David Heidelberg wrote: >> Use the reg property instead of text in the description. >> Drop useless description of reg property. >> >> Signed-off-by: David Heidelberg <david@ixit.cz> >> --- >> Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++--- >> 1 file changed, 2 insertions(+), 3 deletions(-) >> >> diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml > > You are using non-standard tools to generate patches. See checkpatch > warnings. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
diff --git ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml index 8b23e5fc6a24..066eeb7af5e3 100644 --- ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml +++ ./Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml @@ -12,7 +12,7 @@ maintainers: description: |- The Sony imx219 is a 1/4.0-inch CMOS active pixel digital image sensor with an active array size of 3280H x 2464V. It is programmable through - I2C interface. The I2C address is fixed to 0x10 as per sensor data sheet. + I2C interface. Image data is sent through MIPI CSI-2, which is configured as either 2 or 4 data lanes. @@ -21,8 +21,7 @@ properties: const: sony,imx219 reg: - description: I2C device address - maxItems: 1 + const: 0x10 clocks: maxItems: 1
Use the reg property instead of text in the description. Drop useless description of reg property. Signed-off-by: David Heidelberg <david@ixit.cz> --- Documentation/devicetree/bindings/media/i2c/sony,imx219.yaml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)